* [PATCH] BaseTools/WorkspaceCommon: Import used BuildToolError messages.
@ 2018-06-16 16:15 Marvin Häuser
2018-06-19 1:21 ` Zhu, Yonghong
0 siblings, 1 reply; 2+ messages in thread
From: Marvin Häuser @ 2018-06-16 16:15 UTC (permalink / raw)
To: edk2-devel@lists.01.org; +Cc: liming.gao@intel.com, yonghong.zhu@intel.com
Commit c14b58614ffb992dfc668966a19becb86614aafc added a few build
error message display calls to WorkspaceCommon.py without importing
the message resources explicitely. This commit adds imports the
missing directives.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
---
BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/BaseTools/Source/Python/Workspace/WorkspaceCommon.py b/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
index a28fbdf03021..713c1ddbddc9 100644
--- a/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
+++ b/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
@@ -16,6 +16,9 @@ from Common.DataType import SUP_MODULE_USER_DEFINED
from BuildClassObject import LibraryClassObject
import Common.GlobalData as GlobalData
from Workspace.BuildClassObject import StructurePcd
+from Common.BuildToolError import RESOURCE_NOT_AVAILABLE
+from Common.BuildToolError import OPTION_MISSING
+from Common.BuildToolError import BUILD_ERROR
class OrderedListDict(OrderedDict, defaultdict):
def __init__(self, *args, **kwargs):
--
2.17.1.windows.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] BaseTools/WorkspaceCommon: Import used BuildToolError messages.
2018-06-16 16:15 [PATCH] BaseTools/WorkspaceCommon: Import used BuildToolError messages Marvin Häuser
@ 2018-06-19 1:21 ` Zhu, Yonghong
0 siblings, 0 replies; 2+ messages in thread
From: Zhu, Yonghong @ 2018-06-19 1:21 UTC (permalink / raw)
To: Marvin.Haeuser@outlook.com, edk2-devel@lists.01.org
Cc: Gao, Liming, Zhu, Yonghong
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Best Regards,
Zhu Yonghong
-----Original Message-----
From: Marvin Häuser [mailto:Marvin.Haeuser@outlook.com]
Sent: Sunday, June 17, 2018 12:16 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>
Subject: [PATCH] BaseTools/WorkspaceCommon: Import used BuildToolError messages.
Commit c14b58614ffb992dfc668966a19becb86614aafc added a few build error message display calls to WorkspaceCommon.py without importing the message resources explicitely. This commit adds imports the missing directives.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
---
BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/BaseTools/Source/Python/Workspace/WorkspaceCommon.py b/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
index a28fbdf03021..713c1ddbddc9 100644
--- a/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
+++ b/BaseTools/Source/Python/Workspace/WorkspaceCommon.py
@@ -16,6 +16,9 @@ from Common.DataType import SUP_MODULE_USER_DEFINED from BuildClassObject import LibraryClassObject import Common.GlobalData as GlobalData from Workspace.BuildClassObject import StructurePcd
+from Common.BuildToolError import RESOURCE_NOT_AVAILABLE from
+Common.BuildToolError import OPTION_MISSING from Common.BuildToolError
+import BUILD_ERROR
class OrderedListDict(OrderedDict, defaultdict):
def __init__(self, *args, **kwargs):
--
2.17.1.windows.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-19 1:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-16 16:15 [PATCH] BaseTools/WorkspaceCommon: Import used BuildToolError messages Marvin Häuser
2018-06-19 1:21 ` Zhu, Yonghong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox