From: Marvin H?user <Marvin.Haeuser@outlook.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>,
"liming.gao@intel.com" <liming.gao@intel.com>
Subject: Re: [Patch 0/3] Use comparison logic to check UINTN parameter in GetBestLanguage API
Date: Mon, 28 May 2018 08:10:58 +0000 [thread overview]
Message-ID: <VI1PR0801MB1790EB3BD85ECEEA1EF3CDDB806E0@VI1PR0801MB1790.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BB3EC98@shsmsx102.ccr.corp.intel.com>
Hey Star and Liming,
May I propose re-considering the introduction of a third named parameter to reflect the first Language passed?
This would 1) have the advantage that the BOOLEAN parameter can remain as is, which increases readability and
2) require at least two parameters related to the language list passed. Having to write "NULL, NULL" is way more obvious than just having to write "NULL" when (accidentally?) not passing any language.
And error caused by this change would be calls that do not pass an expected amount of parameters for the call to make sense.
Thanks,
Marvin.
> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Zeng,
> Star
> Sent: Monday, May 28, 2018 9:54 AM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>
> Subject: Re: [edk2] [Patch 0/3] Use comparison logic to check UINTN
> parameter in GetBestLanguage API
>
> Reviewed-by: Star Zeng <star.zeng@intel.com>
>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Monday, May 28, 2018 3:31 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch 0/3] Use comparison logic to check UINTN parameter
> in GetBestLanguage API
>
> Liming Gao (3):
> MdePkg UefiLib: Use comparison logic to check UINTN parameter
> IntelFrameworkPkg UefiLib: Use comparison logic to check UINTN
> parameter
> MdeModulePkg Variable: Use comparison logic to check UINTN parameter
>
> IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c | 6 +++---
> MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariable.c | 8
> ++++----
> MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 8 ++++----
> MdePkg/Library/UefiLib/UefiLib.c | 6 +++---
> 4 files changed, 14 insertions(+), 14 deletions(-)
>
> --
> 2.8.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-05-28 8:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 7:30 [Patch 0/3] Use comparison logic to check UINTN parameter in GetBestLanguage API Liming Gao
2018-05-28 7:30 ` [Patch 1/3] MdePkg UefiLib: Use comparison logic to check UINTN parameter Liming Gao
2018-05-28 7:30 ` [Patch 2/3] IntelFrameworkPkg " Liming Gao
2018-05-28 7:30 ` [Patch 3/3] MdeModulePkg Variable: " Liming Gao
2018-05-28 7:53 ` [Patch 0/3] Use comparison logic to check UINTN parameter in GetBestLanguage API Zeng, Star
2018-05-28 8:10 ` Marvin H?user [this message]
2018-05-29 3:36 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0801MB1790EB3BD85ECEEA1EF3CDDB806E0@VI1PR0801MB1790.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox