From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.92.73.66; helo=eur04-he1-obe.outbound.protection.outlook.com; envelope-from=marvin.haeuser@outlook.com; receiver=edk2-devel@lists.01.org Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073066.outbound.protection.outlook.com [40.92.73.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0822C203B8CE5 for ; Mon, 28 May 2018 01:11:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GD2/QUkcAbsec9gxZ0F8snsyAA6g+Vx2XXUWH7MvLxw=; b=O59wfOslyDpINvu3MsCr96YvkT2W0ifDPc8bXeQfmAt8bq3Zi0t8m1yeLocDDSC2F8Glp8D4LrO+FF1CN010ZJHnfpCWj2kdLXwx/T0nBtWcznGB1i00vn9VjomKmgWLdeU8sjwRpEMqX2630pF/R5Cf0DY9GBQfnejDLXzS7bqjIciq9g+kAiANasgKu+e9oPyvi8JaD6k3vwuSirYS7RZO3LqlkQfgH9Nyp4fKaPu3eYQqkYtcU3jsrw+xyeWJKH4w0xcByO2WIzflw/XGH4fh558Gm8CdPymGjXH5ZqjQ+tNYeChNrXBR66xg8Eg+EHlkIN5jUk2l/TVnrHYn4g== Received: from HE1EUR04FT028.eop-eur04.prod.protection.outlook.com (10.152.26.60) by HE1EUR04HT028.eop-eur04.prod.protection.outlook.com (10.152.27.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.820.8; Mon, 28 May 2018 08:10:58 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com (10.152.26.58) by HE1EUR04FT028.mail.protection.outlook.com (10.152.27.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.820.8 via Frontend Transport; Mon, 28 May 2018 08:10:58 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::7010:5d5e:8dcf:d92e]) by VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::7010:5d5e:8dcf:d92e%17]) with mapi id 15.20.0797.017; Mon, 28 May 2018 08:10:58 +0000 From: Marvin H?user To: "edk2-devel@lists.01.org" CC: "Zeng, Star" , "liming.gao@intel.com" Thread-Topic: [edk2] [Patch 0/3] Use comparison logic to check UINTN parameter in GetBestLanguage API Thread-Index: AQHT9laPXJv1/SQN60yGzPStF7InMqRExV6AgAADvqA= Date: Mon, 28 May 2018 08:10:58 +0000 Message-ID: References: <1527492652-17544-1-git-send-email-liming.gao@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BB3EC98@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BB3EC98@shsmsx102.ccr.corp.intel.com> Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:9DA46D21CD2F7E4529C1AF7B86B985A25106EB1BBC52C132E315C3B1C28A5DE9; UpperCasedChecksum:DCAF6213AD758F2FD679E0E14CE215EF5C728598226DE4A7B3D0008654355A81; SizeAsReceived:7314; Count:46 x-tmn: [8AjdpNcJFdM2w7Y1ZiI8ma32fEcfaTpM] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1EUR04HT028; 7:jcYpsMikqOLd7I4lIR8KMVnA9sLaPnCXFA8SRcm1+DmJXjTgyCJ39aNDnzbC3ymIcD+QDnVHKSWJghHGs9VxpoVedJKsCVjAAerYMyTCkC+T4LRrNVUUc9XM32jsUHNJZe+OTfqmgthka+lHJEun4zc2YJ1UZqy+A1VvFYqWbAjiF6KttXfQjGccFTD7OGTdOn4FOkFRRQh2IaKtTnuOw4Ub1r6XweVaFBRtEFodpg80LzA3kH9UAdwZZe1xwnVh x-incomingheadercount: 46 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101448)(1601125466)(1701031045); SRVR:HE1EUR04HT028; x-ms-traffictypediagnostic: HE1EUR04HT028: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(444000031); SRVR:HE1EUR04HT028; BCL:0; PCL:0; RULEID:; SRVR:HE1EUR04HT028; x-forefront-prvs: 06860EDC7B x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(13464003)(199004)(189003)(8676002)(305945005)(486006)(81156014)(82202002)(72206003)(229853002)(6436002)(2900100001)(2351001)(6246003)(6306002)(55016002)(4326008)(54906003)(5660300001)(25786009)(6916009)(87572001)(966005)(5640700003)(426003)(8936002)(74316002)(20460500001)(11346002)(446003)(14454004)(476003)(105586002)(3660700001)(106356001)(68736007)(3280700002)(104016004)(33656002)(7696005)(2501003)(5250100002)(76176011)(86362001)(6346003)(26005)(102836004)(97736004)(99286004)(53546011); DIR:OUT; SFP:1901; SCL:1; SRVR:HE1EUR04HT028; H:VI1PR0801MB1790.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:; received-spf: None (protection.outlook.com: outlook.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Marvin.Haeuser@outlook.com; x-microsoft-antispam-message-info: uu/mjQqZqRLbdn5jCSuOSF/NpJscbNrF8DWBx+gLdYOkr0jq30I5TB1gES8NW/4pSHbhbk7pY3E9dzp8+a5SaaNVgbRmD6NnFxLUlv596aXlfhJ3WqDC2Q0wjoVdkqrHym/a1vMbwPFUkfhYWIjKrPt4b8xPrs4M5CmRPLuuQgoLF0+N/Ep2lJEYErlxHtSR MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 9e208c29-d2e9-421c-84ca-08d5c4728b81 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-Network-Message-Id: 9e208c29-d2e9-421c-84ca-08d5c4728b81 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-originalarrivaltime: 28 May 2018 08:10:58.7848 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR04HT028 Subject: Re: [Patch 0/3] Use comparison logic to check UINTN parameter in GetBestLanguage API X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 May 2018 08:11:02 -0000 Content-Language: de-DE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hey Star and Liming, May I propose re-considering the introduction of a third named parameter to= reflect the first Language passed? This would 1) have the advantage that the BOOLEAN parameter can remain as i= s, which increases readability and 2) require at least two parameters related to the language list passed. Hav= ing to write "NULL, NULL" is way more obvious than just having to write "NU= LL" when (accidentally?) not passing any language. And error caused by this change would be calls that do not pass an expected= amount of parameters for the call to make sense. Thanks, Marvin. > -----Original Message----- > From: edk2-devel On Behalf Of Zeng, > Star > Sent: Monday, May 28, 2018 9:54 AM > To: Gao, Liming ; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: Re: [edk2] [Patch 0/3] Use comparison logic to check UINTN > parameter in GetBestLanguage API >=20 > Reviewed-by: Star Zeng >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Liming Gao > Sent: Monday, May 28, 2018 3:31 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 0/3] Use comparison logic to check UINTN parameter > in GetBestLanguage API >=20 > Liming Gao (3): > MdePkg UefiLib: Use comparison logic to check UINTN parameter > IntelFrameworkPkg UefiLib: Use comparison logic to check UINTN > parameter > MdeModulePkg Variable: Use comparison logic to check UINTN parameter >=20 > IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c | 6 +++--- > MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariable.c | 8 > ++++---- > MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 8 ++++---- > MdePkg/Library/UefiLib/UefiLib.c | 6 +++--- > 4 files changed, 14 insertions(+), 14 deletions(-) >=20 > -- > 2.8.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel