From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.92.68.31; helo=eur02-he1-obe.outbound.protection.outlook.com; envelope-from=marvin.haeuser@outlook.com; receiver=edk2-devel@lists.01.org Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-oln040092068031.outbound.protection.outlook.com [40.92.68.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D0E4121BADAB3 for ; Fri, 20 Jul 2018 13:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ywlUwBn7KL3VVvPQS/dLXD35lNKSJNfzwnZhRjE63u4=; b=TSSFMdKrkmk0XhCcw8EsIDprir9wQRclMLyTIZ9yNzAH5CyY71jnAv8hMTL1F4CcSoKA/foeqMU5TJqWH//It2lrFQ8EYkMRXRF7ZeZsGQm/OtEAZCNFILfGTMoxQhLVjS1VN9bBM69LDPfhLS6K4WK1J9BF+DHFxTa8M1j2Es7bLSw5C6ZahsRdlNqHpxB32HIP2WPSR1dX+rYxoKaKjVg4H6XJ1VENRaHV7yrGQAtQYTW8ykNPZjxUabKQr4niT0bXuoO/xQeCs5GExxw7dEbqbAZqcthvZ36W8Ss4LneIQqrgwh6kOhTGNb4upbxeXGYWU+YRnnjvzqMhhi8/7A== Received: from AM5EUR02FT032.eop-EUR02.prod.protection.outlook.com (10.152.8.55) by AM5EUR02HT105.eop-EUR02.prod.protection.outlook.com (10.152.9.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.952.17; Fri, 20 Jul 2018 20:10:30 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com (10.152.8.58) by AM5EUR02FT032.mail.protection.outlook.com (10.152.8.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.952.17 via Frontend Transport; Fri, 20 Jul 2018 20:10:30 +0000 Received: from VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::7532:4dc6:e9f7:4765]) by VI1PR0801MB1790.eurprd08.prod.outlook.com ([fe80::7532:4dc6:e9f7:4765%2]) with mapi id 15.20.0973.018; Fri, 20 Jul 2018 20:10:30 +0000 From: =?iso-8859-1?Q?Marvin_H=E4user?= To: "edk2-devel@lists.01.org" , "ruiyu.ni@intel.com" CC: "jaben.carsey@intel.com" Thread-Topic: [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support unspecified local Timezone. Thread-Index: AQHT7dyPP02JU0LAdUmmha366FmPxqQz9xxQgCrXKhCAOh4XMA== Date: Fri, 20 Jul 2018 20:10:30 +0000 Message-ID: References: In-Reply-To: Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:0F4EBF3B50F4BFA417EE981376696011726D200CDE4F98DEBD3F93D32299A3D7; UpperCasedChecksum:9ACCD640911A241B665F626895E29999AB9388E9149AAE11F37C03E73A69A87A; SizeAsReceived:7461; Count:46 x-tmn: [HeeBFlHHkXC6oKBTzn93yiUfFlzTagwn] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM5EUR02HT105; 7:XD5vF0eAZIkjdPPBRZPzmUrf415Ftv7S9i2FVj9bEDbFOcFvHBV9sfEj6Pej2CZMAbazyBJgoksCYTxS7QH9lK2HnQOnHD884oekiWGYqYixa8OZdaxVPQIuh+krSR2CJZP6+Tv1rHI6Rd9e/aY2EsmhjrqTyOXSDgscdtQ0cdLUC9Z/QnqMTRhRsoagRf+0DaVM0/wxxlQCAVtekLSokZmtFs2DfEdD8BfamNXT5b/CQStT+KNfnpoeQdzyg96d x-incomingheadercount: 46 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101448)(1601125500)(1701031045); SRVR:AM5EUR02HT105; x-ms-traffictypediagnostic: AM5EUR02HT105: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(82015058); SRVR:AM5EUR02HT105; BCL:0; PCL:0; RULEID:; SRVR:AM5EUR02HT105; x-forefront-prvs: 073966E86B x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(13464003)(189003)(199004)(5250100002)(6246003)(4326008)(20460500001)(82202002)(6436002)(229853002)(2900100001)(5660300001)(110136005)(55016002)(86362001)(8676002)(305945005)(74316002)(6306002)(486006)(25786009)(33656002)(68736007)(81156014)(15760500003)(76176011)(6346003)(105586002)(102836004)(26005)(104016004)(106356001)(53546011)(14454004)(11346002)(97736004)(8936002)(446003)(56003)(966005)(72206003)(19627235002)(476003)(14444005)(7696005)(87572001)(426003)(99286004)(256004)(2501003); DIR:OUT; SFP:1901; SCL:1; SRVR:AM5EUR02HT105; H:VI1PR0801MB1790.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:; received-spf: None (protection.outlook.com: outlook.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Marvin.Haeuser@outlook.com; x-microsoft-antispam-message-info: cn1r2mG2u+ND0tWQp78mTwozpxEiejKbnGaVqP5M00XzQIHkkm21Ir2A35+bF6JvmoTelNNWMrHJTbqPQR05/bATeTel/6i6A35frvmt0X1tJ63PkoPro4Lcjt2ujNUqBaDg4HZgnrKV6Bn6pr8nrEwrh4FtEeWULE0usd1TtLKnETMBKYHiotOeB85v+hkxypgR644Q9hHVxmmM3k27017iqVdyonpYo49jtr8bNIU= MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-Network-Message-Id: f9013131-4763-4444-3ab0-08d5ee7cd7ae X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 7181d4b0-87d6-4f4e-ba33-0d3746212cec X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2018 20:10:30.4087 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5EUR02HT105 Subject: Re: [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support unspecified local Timezone. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jul 2018 20:10:35 -0000 Content-Language: de-DE Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hey Ruiyu, Sorry if I'm bothering you, but this V2 was still not reviewed or pushed. Regards, Marvin. > -----Original Message----- > From: Marvin H=E4user > Sent: Wednesday, June 13, 2018 10:30 PM > To: edk2-devel@lists.01.org; ruiyu.ni@intel.com > Cc: jaben.carsey@intel.com > Subject: RE: [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support > unspecified local Timezone. >=20 > Good day Ruiyu, >=20 > Sorry, but you have not ack'd this V2 yet. Is there anything wrong you wa= nt > me to correct? >=20 > Thanks, > Marvin. >=20 > > -----Original Message----- > > From: Carsey, Jaben > > Sent: Thursday, May 17, 2018 4:15 PM > > To: Marvin H=E4user ; edk2- > > devel@lists.01.org > > Cc: Ni, Ruiyu > > Subject: RE: [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support > > unspecified local Timezone. > > > > Still looks good to me. Ray? > > > > > -----Original Message----- > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > > > Of Marvin H=E4user > > > Sent: Thursday, May 17, 2018 5:43 AM > > > To: edk2-devel@lists.01.org > > > Cc: Carsey, Jaben ; Ni, Ruiyu > > > > > > Subject: [edk2] [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: > > > Support unspecified local Timezone. > > > Importance: High > > > > > > EFI_RUNTIME_SERVICES.GetTime() might return an unspecified > Timezone, > > > such as when SetTime() has not been called after the PC-AT CMOS RTC > > > was cut off power. Consider this case by not attempting Timezone > > > translations for when it is invalid. > > > > > > V2: > > > - Do not change the copyright date as requested. > > > - Added R-bs from V1 as no functional changes have been made. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Marvin Haeuser > > > Reviewed-by: Jaben Carsey > > > Reviewed-by: Ruiyu Ni > > > --- > > > ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > > > b/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > > > index 7d2e15f5206b..e502685a1dbb 100644 > > > --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > > > +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > > > @@ -506,7 +506,7 @@ PrintLsOutput( > > > // Change the file time to local time. > > > // > > > Status =3D gRT->GetTime(&LocalTime, NULL); > > > - if (!EFI_ERROR (Status)) { > > > + if (!EFI_ERROR (Status) && (LocalTime.TimeZone !=3D > > > EFI_UNSPECIFIED_TIMEZONE)) { > > > if ((Node->Info->CreateTime.TimeZone !=3D > > > EFI_UNSPECIFIED_TIMEZONE) && > > > (Node->Info->CreateTime.Month >=3D 1 && Node->Info- > > > >CreateTime.Month <=3D 12)) { > > > // > > > -- > > > 2.17.0.windows.1 > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel