From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.7.59; helo=eur04-he1-obe.outbound.protection.outlook.com; envelope-from=lokesh.bv@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70059.outbound.protection.outlook.com [40.107.7.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B285A21A00AE6 for ; Tue, 27 Nov 2018 00:04:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RDT0NPvIgSSYZkz4Q7wlHmBOhrIehDVsCj9wDQ4GIBw=; b=XTWBstGcHGIf0krXgHH7mAIWWnfVOFz4NxrHV+EVn4gzGMaJ59CsfA8XimXAJb+s5EYSQ3UGQCmFekua5DXpEW3dybn/yPJARgGLrMmmz17yFdSnsAuwo6wa9oLMDa/ZQZi1S3yBGDjzpTo38RuXIKiVG/AOc5N4sBw+48cZN5A= Received: from VI1PR0802MB2334.eurprd08.prod.outlook.com (10.172.14.9) by VI1PR0802MB2207.eurprd08.prod.outlook.com (10.172.12.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1361.15; Tue, 27 Nov 2018 08:04:31 +0000 Received: from VI1PR0802MB2334.eurprd08.prod.outlook.com ([fe80::5420:4872:5b1f:6b5f]) by VI1PR0802MB2334.eurprd08.prod.outlook.com ([fe80::5420:4872:5b1f:6b5f%4]) with mapi id 15.20.1361.019; Tue, 27 Nov 2018 08:04:29 +0000 From: Lokesh Belathur Veerappa To: Supreeth Venkatesh , "edk2-devel@lists.01.org" , "eric.jin@intel.com" Thread-Topic: [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool Thread-Index: AQHUgJ1R9u7APhthKkC9p+Evt5f+EKVii02AgACqfkA= Date: Tue, 27 Nov 2018 08:04:29 +0000 Message-ID: References: <1542696618-2284-1-git-send-email-lokesh.bv@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Lokesh.BV@arm.com; x-originating-ip: [217.140.105.40] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0802MB2207; 6:D4JJ7WG2gbkWldv/Nq1LVU+mJSw6hdYdv+CZ5/Kp2W12Z0kaIBtEBj0UrOHnFP04+VXBax3rYAaqA5nBsjB5S87QB2tZLBfjC1Vfb7K2oq+36V7DaTIo109QbxllLKYeAxOUx+yteaVnMzuam9pE6vzC/gppSzPIxHK7ztnvfeOo8uAPOmOTCLa/CE22QhtDIcXaha9AM+mXXBCJtcYy2fKRxZI31ngWvbKXK/nITzMG6n2ZZdmMpLTq3N7A9+EtI0FPFxj5LEC3Q8ZtDNgyH54kDgbjdqJpDyZM9sCknFkV4gzYUKpXok7MCxyx7LlzpGA1Abn59li1YeTaEnFZ5SB+309z8yXuMyXs/PeeACY2zW13eyKvJiJMIhpWFA/udQ8h6xSAWIjY/27dabWWsDqYY/+Ci3W5uXnWAFd9BHMirs5zzf2VzMkLePgEko4/n6zIUDbQbwBrj+xzPBpSeQ==; 5:e6d684XcH4xWnimzi7BXt8xEpFFm53zuV3Mb/WsxoZOxnirCPVdQSAizd774Jc+dry0VnZlgAO1Y9SzxBJV8CDixF9YiYo/dJKuD1y5H/m2qm2OG/wr8O7kOZTZFPeRsw+A1iq5NCNfdLxiyM0Y0+7yHToILJyONZGHcYaDVxr0=; 7:P6RI83+04mWR9fspdZ0iLv3e34WEjCPPVe84tfofttOO9DkqbiBHInSJgDMXgoENjf2wkIRJhS6sgsDvM8JFItim9PHHNsz1IUs3SVRwG9uAWQ4qF+IO1Nm72pptYQkN3tdD7NHWXMsjUT4HYM+y8g== x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: 17a14069-0b3e-48bc-37a0-08d6543ef4f7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0802MB2207; x-ms-traffictypediagnostic: VI1PR0802MB2207: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231443)(944501410)(52105112)(93006095)(93001095)(10201501046)(6055026)(148016)(149066)(150057)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:VI1PR0802MB2207; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0802MB2207; x-forefront-prvs: 086943A159 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(39860400002)(346002)(396003)(376002)(189003)(199004)(40434004)(13464003)(68736007)(305945005)(8676002)(5660300001)(53936002)(74316002)(25786009)(55016002)(9686003)(8936002)(71190400001)(71200400001)(81166006)(81156014)(2501003)(486006)(2201001)(476003)(6246003)(6436002)(7736002)(446003)(86362001)(66066001)(11346002)(2906002)(99286004)(105586002)(97736004)(3846002)(186003)(316002)(110136005)(5024004)(14444005)(33656002)(72206003)(256004)(106356001)(7696005)(76176011)(102836004)(53546011)(6506007)(229853002)(14454004)(26005)(478600001)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0802MB2207; H:VI1PR0802MB2334.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: jVCO36wl8lVIyv7YMc2+Uj0dXQFN3e0oy2z3nJfsynsI5V0ZlxBe1Y0dn0Jvn3R0r1lrf+DLExigqFJts6aCdrlEUy9mAmSD1kg/5g5AFcxz/SdWW0aTQLVMVa6O7p27kcZPtfPDn1e+Zqa1KC2WI/Pl4f8w56gGhKDcGSG3wEnpVPkUeXlBQWbEmd2kK1WkUxpvdirR/euRIryB9VwD0xbb+OWg8nJyJBYHIrrnWvqkbvtjpRXPj/BBXPqVEJuDHLjFzy/tadhYzZkTKbVOZCSnuCDtbrltH83qMQmUyxStJsML/Bpuy1iVmi26vJr5UZIjy98b3iYAcvFtJUYocYOS34d/iw6S3Ld16l7TFbs= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17a14069-0b3e-48bc-37a0-08d6543ef4f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Nov 2018 08:04:29.2840 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2207 Subject: Re: [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection by GenBin tool X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 X-List-Received-Date: Tue, 27 Nov 2018 08:04:36 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Supreeth, The 'GenBin' tool has to be rebuilt with this change. The GenBin tool buil= d support is added in the patch "[edk2-test][PATCH] SctPkg/build: Add suppo= rt for GenBin tool build". I will upload a single patch which includes both the changes. Please verify= and merge it. Thanks, Lokesh -----Original Message----- From: Supreeth Venkatesh Sent: Tuesday, November 27, 2018 1:56 AM To: Lokesh Belathur Veerappa ; edk2-devel@lists.01.org; = eric.jin@intel.com Cc: Lokesh Belathur Veerappa Subject: RE: [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending det= ection by GenBin tool With the latest edk2, I am getting this compilation error (even when this p= atch is applied). I will be looking at it tomorrow. Please check this out if you get a chance= . GenBin /data/users/supreeth/supven01/work/sct_workspace/edk2/SctPkg/TestCa= se/UEFI/EFI/Protocol/Decompress/BlackBoxTest/Dependency/UncompressedFile2/U= ncompressedFile2.ini /data/users/supreeth/supven01/work/sct_workspace/edk2/= Build/UefiSct/DEBUG_GCC49/AARCH64/Decompress_UncompressedFile2.ucmp Error: Invalid format (Line 30) Error: Cannot generate the binary file GNUmakefile:232: recipe for target '/data/users/supreeth/supven01/work/sct_= workspace/edk2/Build/UefiSct/DEBUG_GCC49/AARCH64/Decompress_UncompressedFil= e2.ucmp' failed make: *** [/data/users/supreeth/supven01/work/sct_workspace/edk2/Build/Uefi= Sct/DEBUG_GCC49/AARCH64/Decompress_UncompressedFile2.ucmp] Error 255 build.py... : error 7000: Failed to execute command make tbuild [/data/users/supreeth/supven01/work/sct_workspace/edk2/Build/Ue= fiSct/DEBUG_GCC49/AARCH64/SctPkg/TestCase/UEFI/EFI/Protocol/Decompress/Blac= kBoxTest/Dependency/UncompressedFile2/UncompressedFile2] Thanks, Supreeth -----Original Message----- From: Lokesh B V Sent: Tuesday, November 20, 2018 12:50 AM To: edk2-devel@lists.01.org; Supreeth Venkatesh ; eric.jin@intel.com Cc: Lokesh Belathur Veerappa Subject: [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detecti= on by GenBin tool Some windows editors uses "\r\n" for line feed. While processing uefi testc= ase info file, the GenBin tool logic to skip line feed doesn't consider the= presence of carraige return(\r) in line feed. So this results in incorrect= format error. Signed-off-by: Lokesh B V --- uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c b/uefi-sct/SctPkg= /Tools/Source/GenBin/GenBin.c index 61bb35b..ce271a1 100644 --- a/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c +++ b/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c @@ -176,6 +176,7 @@ Trim ( for (Index1 =3D 0; Index1 < Length; Index1++) { if ((String[Index1] !=3D ' ' ) && (String[Index1] !=3D '\t') && + (String[Index1] !=3D '\r') && (String[Index1] !=3D '\n')) { break; } @@ -193,6 +194,7 @@ Trim ( for (Index1 =3D 0; Index1 < Length; Index1++) { if ((String[Length - 1 - Index1] !=3D ' ' ) && (String[Length - 1 - Index1] !=3D '\t') && + (String[Length - 1 - Index1] !=3D '\r') && (String[Length - 1 - Index1] !=3D '\n')) { break; } -- 2.7.4 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.