public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Lokesh Belathur Veerappa <Lokesh.BV@arm.com>
To: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"eric.jin@intel.com" <eric.jin@intel.com>
Subject: Re: [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7
Date: Tue, 27 Nov 2018 08:07:05 +0000	[thread overview]
Message-ID: <VI1PR0802MB2334CACCF496738A45A1BC44E7D00@VI1PR0802MB2334.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <VI1PR0802MB2334ACD498003E88E40A296DE7DA0@VI1PR0802MB2334.eurprd08.prod.outlook.com>

Hello Supreeth,

I verified this patch against latest edk2. Please verify from your side and merge it.

Thanks,
Lokesh

-----Original Message-----
From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Lokesh Belathur Veerappa
Sent: Wednesday, November 21, 2018 11:00 AM
To: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>; edk2-devel@lists.01.org; eric.jin@intel.com
Subject: Re: [edk2] [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7

Hi Supreeth,

Yes it has been compiled and tested against edk2 with SHA da2c81ee96eba5d5c8ef91fd870ac98d3cf72beb.

-----Original Message-----
From: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
Sent: Tuesday, November 20, 2018 8:34 PM
To: Lokesh Belathur Veerappa <Lokesh.BV@arm.com>; edk2-devel@lists.01.org; eric.jin@intel.com
Cc: Lokesh Belathur Veerappa <Lokesh.BV@arm.com>
Subject: RE: [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7

Thanks Lokesh for the patch.
Has this been compiled and sanity tested against latest edk2?
Let me know SHA of edk2 tested, so that I can test it against that SHA and push it.

If so, Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>

-----Original Message-----
From: Lokesh B V <lokesh.bv@arm.com>
Sent: Tuesday, November 20, 2018 12:50 AM
To: edk2-devel@lists.01.org; Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>; eric.jin@intel.com
Cc: Lokesh Belathur Veerappa <Lokesh.BV@arm.com>
Subject: [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7

EDK2 supports EFI version 2.7 and so allow UEFI-SCT to be usable with this version of EFI.

Signed-off-by: Lokesh B V <lokesh.bv@arm.com>
---
 uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
index d24c201..c861437 100644
--- a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
+++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
@@ -46,6 +46,8 @@ Abstract:
 #define EFI_SCT_NAME                        L"UEFI2.5 Self Certification Test(SCT2)"
 #elif (EFI_SPECIFICATION_VERSION == EFI_2_60_SYSTEM_TABLE_REVISION)
 #define EFI_SCT_NAME                        L"UEFI2.6 Self Certification Test(SCT2)"
+#elif (EFI_SPECIFICATION_VERSION == EFI_2_70_SYSTEM_TABLE_REVISION)
+#define EFI_SCT_NAME                        L"UEFI2.7 Self Certification Test(SCT2)"
 #else
 #error Unknown EFI_SPECIFICATION_VERSION  #endif
--
2.7.4

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


  reply	other threads:[~2018-11-27  8:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20  6:49 [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7 Lokesh B V
2018-11-20  8:09 ` Jin, Eric
2018-11-20 15:03 ` Supreeth Venkatesh
2018-11-21  5:30   ` Lokesh Belathur Veerappa
2018-11-27  8:07     ` Lokesh Belathur Veerappa [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-11-28  9:29 Lokesh B V
2018-11-28 22:30 ` Supreeth Venkatesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0802MB2334CACCF496738A45A1BC44E7D00@VI1PR0802MB2334.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox