public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "lersek@redhat.com" <lersek@redhat.com>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Subject: Re: [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build
Date: Tue, 15 Oct 2019 12:21:53 +0000	[thread overview]
Message-ID: <VI1PR0802MB238166D2C35D588FC1FAB41784930@VI1PR0802MB2381.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20191015110742.15551-1-ard.biesheuvel@linaro.org>

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

-----Original Message-----
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Sent: 15 October 2019 12:08 PM
To: devel@edk2.groups.io
Cc: lersek@redhat.com; Sami Mujawar <Sami.Mujawar@arm.com>; leif.lindholm@linaro.org; Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build

DynamicTablesPkg can be built for ARM as well as for AARCH64, but on the former, doing so will result in a build failure due to the lack of 64-bit division helpers provided by the ArmPkg intrinsics library.
So add the missing reference, for both ARM and AARCH64 (which may start relying on intrinsics due to future changes)

Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2269
Reported-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 DynamicTablesPkg/DynamicTablesPkg.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.dsc
index ef958077ed48..19beaaf370f8 100644
--- a/DynamicTablesPkg/DynamicTablesPkg.dsc
+++ b/DynamicTablesPkg/DynamicTablesPkg.dsc
@@ -32,6 +32,7 @@ [LibraryClasses]
   UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf

 [LibraryClasses.ARM, LibraryClasses.AARCH64]
+  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
   PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf

 [Components.common]
--
2.17.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  reply	other threads:[~2019-10-15 12:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15 11:07 [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build Ard Biesheuvel
2019-10-15 12:21 ` Sami Mujawar [this message]
2019-10-15 12:51 ` Laszlo Ersek
2019-10-16 11:51 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-10-21 11:17 ` Alexei Fedorov
2019-10-21 11:37 ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0802MB238166D2C35D588FC1FAB41784930@VI1PR0802MB2381.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox