Re: [PATCH 1/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEventEx

["Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>]

Reviewed-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Sent: Wednesday, January 6, 2021 7:42 AM
> To: EDK II Development <devel@edk2.groups.io>
> Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran
> <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Arvin
> Chen <arvinx.chen@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Heinrich
> Schuchardt <xypron.glpk@gmx.de>
> Subject: [PATCH 1/2] uefi-sct/SctPkg: allowable NotifyTpl in CreateEventEx
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3057
>
> According to table Table 27. TPL Restrictions in UEFI spec 2.8 B:
>
> Event Notification Levels must be "> TPL_APPLICATION" and "<=
> TPL_HIGH_LEVEL".
>
> In the conformance test for CreateEvent() check that TPL_APPLICATION
> results in EFI_INVALID_PARAMETER if the event can be notified.
>
> Run the other conformance tests for TPL_HIGH_LEVEL, too.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c      | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> index c7f0a80f60b3..eb458de5e185 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/
> BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPrior
> +++ ityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateE
> +++ ventEx.c
> @@ -228,6 +228,7 @@ BBTestCreateEventEx_Conf_Sub1 (
>    EFI_TPL             NotifyTpls[] = {
>                          TPL_CALLBACK,
>                          TPL_NOTIFY,
> +                        TPL_HIGH_LEVEL,
>                          0
>                        };
>    EFI_GUID            *EventGroups[] = {
> @@ -317,6 +318,7 @@ BBTestCreateEventEx_Conf_Sub2 (
>    EFI_TPL             NotifyTpls[] = {
>                          TPL_CALLBACK,
>                          TPL_NOTIFY,
> +                        TPL_HIGH_LEVEL,
>                          0
>                        };
>    EFI_GUID            *EventGroups[] = {
> @@ -411,6 +413,7 @@ BBTestCreateEventEx_Conf_Sub3 (
>    EFI_TPL             NotifyTpls[] = {
>                          TPL_CALLBACK,
>                          TPL_NOTIFY,
> +                        TPL_HIGH_LEVEL,
>                          0
>                        };
>    EFI_GUID            *EventGroups[] = {
> @@ -492,6 +495,8 @@ BBTestCreateEventEx_Conf_Sub4 (
>                        };
>    EFI_TPL             InvalidNotifyTpls[] = {
>                          (EFI_TPL) (TPL_HIGH_LEVEL + 1),
> +                        (EFI_TPL) TPL_APPLICATION,
> +                        (EFI_TPL) (TPL_APPLICATION - 1),
>                          (EFI_TPL) -1,
>                          0
>                        };
> --
> 2.29.2

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.