[PATCH v1 0/2] Add a Pcd to override the 16650 HID in SSDT

[PATCH v1 0/2] Add a Pcd to override the 16650 HID in SSDT

[Joey Gouly]

This series adds PcdNonSbsaCompliantSerialHid so that firmware can
override the PNP0501 HID used by 16550 UART in the SSDT table, in case
they are not compatible with the generic PNP0501 HID.

I have tested this with acpiview, some extra testing would be
appreciated.

Changes available at https://github.com/jgouly/edk2/tree/1588_non_sbsa_hid_v1

Joey Gouly (2):
  DynamicTablesPkg: Don't use gEfiMdeModulePkgTokenSpaceGuid
  DynamicTablesPkg: Add an override for 16550 HID in SSDT

 DynamicTablesPkg/DynamicTablesPkg.dec              | 13 +++++++++----
 .../DynamicTableFactoryDxe.inf                     |  8 ++++----
 .../SsdtSerialPortFixupLib.inf                     |  4 +++-
 .../SsdtSerialPortFixupLib.c                       | 14 +++++++++++---
 4 files changed, 27 insertions(+), 12 deletions(-)

-- 
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")

[PATCH v1 1/2] DynamicTablesPkg: Don't use gEfiMdeModulePkgTokenSpaceGuid

[Joey Gouly]

Introduce gEdkiiDynamicTablesPkgTokenSpaceGuid and use that instead.

Signed-off-by: Joey Gouly <joey.gouly@arm.com>
---
 DynamicTablesPkg/DynamicTablesPkg.dec                                      | 10 ++++++----
 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf |  8 ++++----
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/DynamicTablesPkg/DynamicTablesPkg.dec b/DynamicTablesPkg/DynamicTablesPkg.dec
index f36a6e8bb7c17f82acff3c766b15202b064a64b5..291a45a69679ae82219ecd2f26dfabfbab1f7f65 100644
--- a/DynamicTablesPkg/DynamicTablesPkg.dec
+++ b/DynamicTablesPkg/DynamicTablesPkg.dec
@@ -1,7 +1,7 @@
 ## @file
 # dec file for Dynamic Tables Framework.
 #
-# Copyright (c) 2017 - 2020, Arm Limited. All rights reserved.<BR>
+# Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.<BR>
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -36,11 +36,13 @@ [Protocols]
 [PcdsFixedAtBuild]
 
   # Maximum number of Custom ACPI Generators
-  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomACPIGenerators|1|UINT16|0xC0000001
+  gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomACPIGenerators|1|UINT16|0xC0000001
 
   # Maximum number of Custom SMBIOS Generators
-  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomSMBIOSGenerators|1|UINT16|0xC0000002
+  gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomSMBIOSGenerators|1|UINT16|0xC0000002
 
   # Maximum number of Custom DT Generators
-  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomDTGenerators|1|UINT16|0xC0000003
+  gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomDTGenerators|1|UINT16|0xC0000003
 
+[Guids]
+  gEdkiiDynamicTablesPkgTokenSpaceGuid = { 0xab226e66, 0x31d8, 0x4613, { 0x87, 0x9d, 0xd2, 0xfa, 0xb6, 0x10, 0x26, 0x3c } }
diff --git a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf
index 56b69591ac52ca3ba51250dc01a0846b22442ce9..29ed3dc2e5029206f8852c4b11240e7b493bbc57 100644
--- a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf
+++ b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf
@@ -1,7 +1,7 @@
 ## @file
 #  Module to manage the list of available table factories.
 #
-#  Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
+#  Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
@@ -41,9 +41,9 @@ [LibraryClasses]
   UefiDriverEntryPoint
 
 [FixedPcd]
-  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomACPIGenerators
-  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomSMBIOSGenerators
-  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomDTGenerators
+  gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomACPIGenerators
+  gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomSMBIOSGenerators
+  gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomDTGenerators
 
 [Protocols]
   gEdkiiDynamicTableFactoryProtocolGuid         # PRODUCES
-- 
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")

回复: [edk2-devel] [PATCH v1 1/2] DynamicTablesPkg: Don't use gEfiMdeModulePkgTokenSpaceGuid

[gaoliming]

This change is correct. 

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+70589+4905953+8761045@groups.io
> <bounce+27952+70589+4905953+8761045@groups.io> 代表 Joey Gouly
> 发送时间: 2021年1月21日 2:20
> 收件人: devel@edk2.groups.io
> 抄送: joey.gouly@arm.com; ardb+tianocore@kernel.org;
> sami.mujawar@arm.com; jbrasen@nvidia.com; ipark@nvidia.com;
> Samer.El-Haj-Mahmoud@arm.com; nd@arm.com
> 主题: [edk2-devel] [PATCH v1 1/2] DynamicTablesPkg: Don't use
> gEfiMdeModulePkgTokenSpaceGuid
> 
> Introduce gEdkiiDynamicTablesPkgTokenSpaceGuid and use that instead.
> 
> Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> ---
>  DynamicTablesPkg/DynamicTablesPkg.dec
> | 10 ++++++----
> 
> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDx
> e.inf |  8 ++++----
>  2 files changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/DynamicTablesPkg/DynamicTablesPkg.dec
> b/DynamicTablesPkg/DynamicTablesPkg.dec
> index
> f36a6e8bb7c17f82acff3c766b15202b064a64b5..291a45a69679ae82219ecd2
> f26dfabfbab1f7f65 100644
> --- a/DynamicTablesPkg/DynamicTablesPkg.dec
> +++ b/DynamicTablesPkg/DynamicTablesPkg.dec
> @@ -1,7 +1,7 @@
>  ## @file
>  # dec file for Dynamic Tables Framework.
>  #
> -# Copyright (c) 2017 - 2020, Arm Limited. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.<BR>
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -36,11 +36,13 @@ [Protocols]
>  [PcdsFixedAtBuild]
> 
>    # Maximum number of Custom ACPI Generators
> -
> gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomACPIGenerators|1|UINT1
> 6|0xC0000001
> +
> gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomACPIGenerators|1|U
> INT16|0xC0000001
> 
>    # Maximum number of Custom SMBIOS Generators
> -
> gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomSMBIOSGenerators|1|UI
> NT16|0xC0000002
> +
> gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomSMBIOSGenerators|
> 1|UINT16|0xC0000002
> 
>    # Maximum number of Custom DT Generators
> -
> gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomDTGenerators|1|UINT16|
> 0xC0000003
> +
> gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomDTGenerators|1|UI
> NT16|0xC0000003
> 
> +[Guids]
> +  gEdkiiDynamicTablesPkgTokenSpaceGuid = { 0xab226e66, 0x31d8, 0x4613,
> { 0x87, 0x9d, 0xd2, 0xfa, 0xb6, 0x10, 0x26, 0x3c } }
> diff --git
> a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory
> Dxe.inf
> b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory
> Dxe.inf
> index
> 56b69591ac52ca3ba51250dc01a0846b22442ce9..29ed3dc2e5029206f8852c
> 4b11240e7b493bbc57 100644
> ---
> a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory
> Dxe.inf
> +++
> b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory
> Dxe.inf
> @@ -1,7 +1,7 @@
>  ## @file
>  #  Module to manage the list of available table factories.
>  #
> -#  Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
> +#  Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  ##
> @@ -41,9 +41,9 @@ [LibraryClasses]
>    UefiDriverEntryPoint
> 
>  [FixedPcd]
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomACPIGenerators
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomSMBIOSGenerators
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomDTGenerators
> +  gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomACPIGenerators
> +
> gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomSMBIOSGenerators
> +  gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomDTGenerators
> 
>  [Protocols]
>    gEdkiiDynamicTableFactoryProtocolGuid         # PRODUCES
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
> 
> 
> 
> 
> 

[PATCH v1 2/2] DynamicTablesPkg: Add an override for 16550 HID in SSDT

[Joey Gouly]

Some platforms advertise support for a 16550 UART, but are not
compatible with the PNP0500 HID. Allow them to override the HID by
setting PcdNonSbsaCompliantSerialHid.

Signed-off-by: Joey Gouly <joey.gouly@arm.com>
---
 DynamicTablesPkg/DynamicTablesPkg.dec                                             |  3 +++
 DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.inf |  4 +++-
 DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c   | 14 +++++++++++---
 3 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/DynamicTablesPkg/DynamicTablesPkg.dec b/DynamicTablesPkg/DynamicTablesPkg.dec
index 291a45a69679ae82219ecd2f26dfabfbab1f7f65..3ec4fff116a8f538be331edf341867948c025116 100644
--- a/DynamicTablesPkg/DynamicTablesPkg.dec
+++ b/DynamicTablesPkg/DynamicTablesPkg.dec
@@ -44,5 +44,8 @@ [PcdsFixedAtBuild]
   # Maximum number of Custom DT Generators
   gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomDTGenerators|1|UINT16|0xC0000003
 
+  # Non SBSA Compliant Serial HID
+  gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdNonSbsaCompliantSerialHid|""|VOID*|0x40000008
+
 [Guids]
   gEdkiiDynamicTablesPkgTokenSpaceGuid = { 0xab226e66, 0x31d8, 0x4613, { 0x87, 0x9d, 0xd2, 0xfa, 0xb6, 0x10, 0x26, 0x3c } }
diff --git a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.inf b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.inf
index af3d404393f5f1385ab2d40f45f7222ab66f9b3a..b64825982e8fb7aaf78f3fd68992e1c78d20c408 100644
--- a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.inf
+++ b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.inf
@@ -1,7 +1,7 @@
 ## @file
 #  SSDT Serial Port fixup Library
 #
-#  Copyright (c) 2020, Arm Limited. All rights reserved.<BR>
+#  Copyright (c) 2020 - 2021, Arm Limited. All rights reserved.<BR>
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
@@ -28,3 +28,5 @@ [LibraryClasses]
   AmlLib
   BaseLib
 
+[Pcd]
+  gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdNonSbsaCompliantSerialHid
diff --git a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c
index 0ff071485ef25f4ca63de0eeab5120d1beece4db..73a8087ed8a8ff84b64531a3c73d319585dfb6cf 100644
--- a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c
+++ b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c
@@ -1,7 +1,7 @@
 /** @file
   SSDT Serial Port Fixup Library.
 
-  Copyright (c) 2019 - 2020, Arm Limited. All rights reserved.<BR>
+  Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.<BR>
 
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
@@ -139,13 +139,21 @@ FixupIds (
   AML_OBJECT_NODE_HANDLE    NameOpIdNode;
   CONST CHAR8             * HidString;
   CONST CHAR8             * CidString;
+  CONST CHAR8             * NonSbsaHid;
 
   // Get the _CID and _HID value to write.
   switch (SerialPortInfo->PortSubtype) {
     case EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550:
     {
-      HidString = "PNP0501";
-      CidString = "PNP0500";
+      // If there is a non-SBSA compliant HID, use that.
+      NonSbsaHid = (CONST CHAR8*)PcdGetPtr (PcdNonSbsaCompliantSerialHid);
+      if ((NonSbsaHid != NULL) && (AsciiStrLen (NonSbsaHid) != 0)) {
+        HidString = NonSbsaHid;
+        CidString = "";
+      } else {
+        HidString = "PNP0501";
+        CidString = "PNP0500";
+      }
       break;
     }
     case EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_PL011_UART:
-- 
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")

Re: [PATCH v1 2/2] DynamicTablesPkg: Add an override for 16550 HID in SSDT

[Samer El-Haj-Mahmoud]

> -----Original Message-----
> From: Joey Gouly <joey.gouly@arm.com>
> Sent: Wednesday, January 20, 2021 1:20 PM
> To: devel@edk2.groups.io
> Cc: Joey Gouly <Joey.Gouly@arm.com>; ardb+tianocore@kernel.org; Sami
> Mujawar <Sami.Mujawar@arm.com>; Jeff Brasen (jbrasen@nvidia.com)
> <jbrasen@nvidia.com>; ipark@nvidia.com; Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>; nd <nd@arm.com>
> Subject: [PATCH v1 2/2] DynamicTablesPkg: Add an override for 16550 HID in
> SSDT
> 
> Some platforms advertise support for a 16550 UART, but are not compatible
> with the PNP0500 HID. Allow them to override the HID by setting
> PcdNonSbsaCompliantSerialHid.
> 
> Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> ---
>  DynamicTablesPkg/DynamicTablesPkg.dec                                             |  3 +++
> 
> DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFix
> upLib.inf |  4 +++-
> 
> DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFix
> upLib.c   | 14 +++++++++++---
>  3 files changed, 17 insertions(+), 4 deletions(-)
> 
> diff --git a/DynamicTablesPkg/DynamicTablesPkg.dec
> b/DynamicTablesPkg/DynamicTablesPkg.dec
> index
> 291a45a69679ae82219ecd2f26dfabfbab1f7f65..3ec4fff116a8f538be331edf34
> 1867948c025116 100644
> --- a/DynamicTablesPkg/DynamicTablesPkg.dec
> +++ b/DynamicTablesPkg/DynamicTablesPkg.dec
> @@ -44,5 +44,8 @@ [PcdsFixedAtBuild]
>    # Maximum number of Custom DT Generators
> 
> gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomDTGenerators|1|UI
> NT16|0xC0000003
> 
> +  # Non SBSA Compliant Serial HID
> +
> +
> gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdNonSbsaCompliantSerialHid|""|
> V
> + OID*|0x40000008
> +
>  [Guids]
>    gEdkiiDynamicTablesPkgTokenSpaceGuid = { 0xab226e66, 0x31d8, 0x4613, {
> 0x87, 0x9d, 0xd2, 0xfa, 0xb6, 0x10, 0x26, 0x3c } } diff --git
> a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPort
> FixupLib.inf
> b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPort
> FixupLib.inf
> index
> af3d404393f5f1385ab2d40f45f7222ab66f9b3a..b64825982e8fb7aaf78f3fd68
> 992e1c78d20c408 100644
> ---
> a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPort
> FixupLib.inf
> +++
> b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialP
> +++ ortFixupLib.inf
> @@ -1,7 +1,7 @@
>  ## @file
>  #  SSDT Serial Port fixup Library
>  #
> -#  Copyright (c) 2020, Arm Limited. All rights reserved.<BR>
> +#  Copyright (c) 2020 - 2021, Arm Limited. All rights reserved.<BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent  ## @@ -28,3 +28,5 @@
> [LibraryClasses]
>    AmlLib
>    BaseLib
> 
> +[Pcd]
> +  gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdNonSbsaCompliantSerialHid
> diff --git
> a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPort
> FixupLib.c
> b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPort
> FixupLib.c
> index
> 0ff071485ef25f4ca63de0eeab5120d1beece4db..73a8087ed8a8ff84b64531a3c
> 73d319585dfb6cf 100644
> ---
> a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPort
> FixupLib.c
> +++
> b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialP
> +++ ortFixupLib.c
> @@ -1,7 +1,7 @@
>  /** @file
>    SSDT Serial Port Fixup Library.
> 
> -  Copyright (c) 2019 - 2020, Arm Limited. All rights reserved.<BR>
> +  Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.<BR>
> 
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> @@ -139,13 +139,21 @@ FixupIds (
>    AML_OBJECT_NODE_HANDLE    NameOpIdNode;
>    CONST CHAR8             * HidString;
>    CONST CHAR8             * CidString;
> +  CONST CHAR8             * NonSbsaHid;
> 
>    // Get the _CID and _HID value to write.
>    switch (SerialPortInfo->PortSubtype) {
>      case EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550:
>      {
> -      HidString = "PNP0501";
> -      CidString = "PNP0500";
> +      // If there is a non-SBSA compliant HID, use that.
> +      NonSbsaHid = (CONST CHAR8*)PcdGetPtr
> (PcdNonSbsaCompliantSerialHid);
> +      if ((NonSbsaHid != NULL) && (AsciiStrLen (NonSbsaHid) != 0)) {
> +        HidString = NonSbsaHid;
> +        CidString = "";
> +      } else {
> +        HidString = "PNP0501";
> +        CidString = "PNP0500";
> +      }
>        break;
>      }
>      case EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_PL011_UART:
> --

Since you are using PcdNonSbsaCompliantSerialHid to indicate that this is a non-BSA compliant 16550 UART, maybe rename the PCD to reflect that? The name PcdNonSbsaCompliantSerialHid may imply that this is not a PL011/ Arm SBSA Generic UART. BSA 1.0 allows both PL011/Generic UART (the definition moved from SBSA spec to the BSA spec)  OR a 16550 standard UART. In this case, we are saying the UART is a 16550-like UART, but not exactly standard (i.e. do not use the standard 16550 IDs)

Maybe PcdNon16550CompliantSerialHid or PcdNonBsa16550CompliantSerialHid  is a better name that matches what the code is doing?

The comments will need to change as well.

Re: [PATCH v1 0/2] Add a Pcd to override the 16650 HID in SSDT

[Samer El-Haj-Mahmoud]

For the series

Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>



> -----Original Message-----
> From: Joey Gouly <joey.gouly@arm.com>
> Sent: Wednesday, January 20, 2021 1:20 PM
> To: devel@edk2.groups.io
> Cc: Joey Gouly <Joey.Gouly@arm.com>; ardb+tianocore@kernel.org; Sami
> Mujawar <Sami.Mujawar@arm.com>; Jeff Brasen (jbrasen@nvidia.com)
> <jbrasen@nvidia.com>; ipark@nvidia.com; Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>; nd <nd@arm.com>
> Subject: [PATCH v1 0/2] Add a Pcd to override the 16650 HID in SSDT
> 
> This series adds PcdNonSbsaCompliantSerialHid so that firmware can
> override the PNP0501 HID used by 16550 UART in the SSDT table, in case they
> are not compatible with the generic PNP0501 HID.
> 
> I have tested this with acpiview, some extra testing would be appreciated.
> 
> Changes available at
> https://github.com/jgouly/edk2/tree/1588_non_sbsa_hid_v1
> 
> Joey Gouly (2):
>   DynamicTablesPkg: Don't use gEfiMdeModulePkgTokenSpaceGuid
>   DynamicTablesPkg: Add an override for 16550 HID in SSDT
> 
>  DynamicTablesPkg/DynamicTablesPkg.dec              | 13 +++++++++----
>  .../DynamicTableFactoryDxe.inf                     |  8 ++++----
>  .../SsdtSerialPortFixupLib.inf                     |  4 +++-
>  .../SsdtSerialPortFixupLib.c                       | 14 +++++++++++---
>  4 files changed, 27 insertions(+), 12 deletions(-)
> 
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")