Re: [edk2-devel] [edk2-platforms][PATCH v1 3/4] Platform/ARM/N1SDP: Implement n1sdp specific PciExpressLib

["Pranav Madhu" <pranav.madhu@arm.com>]

Hi Ard,

> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Sent: Wednesday, June 10, 2020 11:50 PM
> To: devel@edk2.groups.io; Pranav Madhu <Pranav.Madhu@arm.com>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 3/4]
> Platform/ARM/N1SDP: Implement n1sdp specific PciExpressLib
>
> On 4/24/20 1:58 PM, Pranav Madhu via groups.io wrote:
> > From: Deepak Pandey <deepak.pandey@arm.com>
> >
> > A slave error is generated when host accesses the config space of
> > non-available device or unimplemented function on a given bus. So
> > implement a n1sdp specific PciExpressLib library with a workaround to
> > return 0xffffffff for all such access.
> >
> > Signed-off-by: Pranav Madhu <pranav.madhu@arm.com>
> > ---
> >   Platform/ARM/N1SdpPkg/N1SdpPlatform.dsc                       |    4 +
> >   Platform/ARM/N1SdpPkg/Library/PciExpressLib/PciExpressLib.inf |   40 +
> >   Platform/ARM/N1SdpPkg/Library/PciExpressLib/PciExpressLib.c   | 1540
> ++++++++++++++++++++
> >   3 files changed, 1584 insertions(+)
> >
> > diff --git a/Platform/ARM/N1SdpPkg/N1SdpPlatform.dsc
> b/Platform/ARM/N1SdpPkg/N1SdpPlatform.dsc
> > index 95552328065a..53be9699d99e 100644
> > --- a/Platform/ARM/N1SdpPkg/N1SdpPlatform.dsc
> > +++ b/Platform/ARM/N1SdpPkg/N1SdpPlatform.dsc
> > @@ -65,6 +65,10 @@ [LibraryClasses.common.DXE_CORE]
> >
> >   [LibraryClasses.common.DXE_DRIVER]
> >     FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> > +
> PciHostBridgeLib|Platform/ARM/N1SdpPkg/Library/PciHostBridgeLib/PciHost
> BridgeLib.inf
> > +
> PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibP
> ci.inf
> > +  PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf
> > +
> PciExpressLib|Platform/ARM/N1SdpPkg/Library/PciExpressLib/PciExpressLib.
> inf
> >
> >   [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> >     BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> > diff --git
> a/Platform/ARM/N1SdpPkg/Library/PciExpressLib/PciExpressLib.inf
> b/Platform/ARM/N1SdpPkg/Library/PciExpressLib/PciExpressLib.inf
> > new file mode 100644
> > index 000000000000..f8a85cbb8fed
> > --- /dev/null
> > +++ b/Platform/ARM/N1SdpPkg/Library/PciExpressLib/PciExpressLib.inf
> > @@ -0,0 +1,40 @@
> > +## @file
> > +#  Instance of PCI Express Library using the 256 MB PCI Express MMIO
> window.
> > +#
> > +#  PCI Express Library that uses the 256 MB PCI Express MMIO window to
> perform
> > +#  PCI Configuration cycles. Layers on top of an I/O Library instance.
> > +#
> > +#  Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.
> > +#
> > +#  SPDX-License-Identifier: BSD-2-Clause-Patent
> > +#
> > +##
> > +
> > +[Defines]
> > +  INF_VERSION                    = 0x00010005
> > +  BASE_NAME                      = BasePciExpressLib
> > +  MODULE_UNI_FILE                = BasePciExpressLib.uni
> > +  FILE_GUID                      = 52c06b64-a45e-4906-b9ee-abe1acc286bb
> > +  MODULE_TYPE                    = BASE
> > +  VERSION_STRING                 = 1.0
> > +  LIBRARY_CLASS                  = PciExpressLib
> > +
> > +[Sources]
> > +  PciExpressLib.c
> > +
> > +[Packages]
> > +  MdePkg/MdePkg.dec
> > +  Platform/ARM/N1SdpPkg/N1SdpPlatform.dec
> > +
> > +[FixedPcd]
> > +  gArmN1SdpTokenSpaceGuid.PcdPcieRootPortConfigBaseAddress
> > +  gArmN1SdpTokenSpaceGuid.PcdPcieRootPortConfigBaseSize
> > +
> > +[LibraryClasses]
> > +  BaseLib
> > +  PcdLib
> > +  DebugLib
> > +  IoLib
> > +
> > +[Pcd]
> > +  gArmN1SdpTokenSpaceGuid.PcdPcieExpressBaseAddress  ##
> CONSUMES
>
> Can you use the existing
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress instead?

Okay, will change it.

Thanks,
Pranav

<...>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.