From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (EUR01-VE1-obe.outbound.protection.outlook.com [40.107.14.89]) by mx.groups.io with SMTP id smtpd.web10.34193.1660769076530714156 for ; Wed, 17 Aug 2022 13:44:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=EKDLggJ4; spf=pass (domain: arm.com, ip: 40.107.14.89, mailfrom: samer.el-haj-mahmoud@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=HESqMjr7KPtDOEUOxlPjntf6PEj5G9nLnar1bo4EiJcHa15hwvqjlkTPLUTZkBB+924RvkyxliqOr7SKOiMSGKWtbd8vrqAC0d5ZVwPIVQJalxtMqeRjtDiGWx9UW7RrXT9xsw0pJxXBd2+E8IZ9H9uU8qaMhBxqlt+K/zrgDfatnArD8xU4VDxdahjXs7dYXxmWNlVExospzWLj8MqbMJSwFe5hx8l6BH7+sH9mck858GxTeaZ6IYFfjL9CNppDh3+lgOE3ew50kZPD16dkZ4sgtKobuV3EQb7kbBbq/muUVf2dI2XVn9B8+tco5m+3PcNQS2dbVBRdYBULrAIOfA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3H/uo3LoNjVH0KpcePJDaPIt7omkuoutOTxWHAQg/qQ=; b=i7uL0n5VNw08jLWnzjDoJ4mxxawH4I0ygArxKsd5Tt1xOPzVFNxmjLp7U/raFYIkKmh4gav6zJEjBZu+cLGubQTMXNNil2X0qscLy+T3LDK3tRFJoFO8+upTTH+u4GMF+/dVsZdlX8sTEYyPz0ut1HjK7hgVgd+xm0j+UuhyAx9m1w3+HVqhaKh7cC5O10WPbgri4luaZlGQc1mVjMNDDWoUdqh2yF+pyQVUs38DsIXdveCybicc5zVxhQSZTaLdAiD4eficxAv4tE0qOcpLGkuA1F80E7oXun6E6ejku59sfH+c1HjUaDn7CexI4x8kpwQm8LepkcuwBPl0ab+wFA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3H/uo3LoNjVH0KpcePJDaPIt7omkuoutOTxWHAQg/qQ=; b=EKDLggJ4ixlEOeMInkh9mGa+LXm2X13jqMlYmcM4oXDIBJEI4JRUidcJQI5bPHe4iBczD0DF9I4wUA6/A1jfqRmlU54NuMiTr0lha5P3uiEOqWLg2zNlvFmJH7h2yBxDc5LV6JxUGIF6W3n7F+K3Nz9BRrsKaHSy0ku6LwN1zOw= Received: from AS9P251CA0005.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:50f::17) by PAXPR08MB6493.eurprd08.prod.outlook.com (2603:10a6:102:15a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.19; Wed, 17 Aug 2022 20:44:32 +0000 Received: from AM7EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:50f:cafe::5e) by AS9P251CA0005.outlook.office365.com (2603:10a6:20b:50f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.19 via Frontend Transport; Wed, 17 Aug 2022 20:44:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT048.mail.protection.outlook.com (100.127.140.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.15 via Frontend Transport; Wed, 17 Aug 2022 20:44:32 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Wed, 17 Aug 2022 20:44:32 +0000 X-CR-MTA-TID: 64aa7808 Received: from 2342a24b7ba7.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 753252ED-D8D5-484B-B304-B7D56A654963.1; Wed, 17 Aug 2022 20:44:26 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2342a24b7ba7.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 17 Aug 2022 20:44:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UFWNYff/6pakYa7yFkWNyeuPGWfhujQddmY2QmocfaK3dljmxpvw731W7VkAgKRKpvO0vbOBcWsHKy426lzbDwYbMX6VjEIZ7oQwhr2UJ/kViI1v0rL/Sfa/gcF+CNnk16OPm8AN8OtribaomeliZjqtVBERZdqle4mJJdDkr+FKFJTzEKNmqxZzWPG0otEg4pyuCmDCIC45TBqdLJBOrQkLo1ZuG7aWMb/33md2LIYdgatYLMu0PeS4XopKt51jZpDceSAbU0Q4Hnhg1HvfiAHpO8VJ4suW6baicM3SmTBckWXKhUJ4Jal8WkP2odfG6YeD8N1QxZdfzQ+kIz63sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3H/uo3LoNjVH0KpcePJDaPIt7omkuoutOTxWHAQg/qQ=; b=UBppn3GehTHkglmp0sMNVgNjl6pF8oK/KWM/gOri3tluY4DWkYwuCg3ZS+wvd1YvjPBThTYP5TTWJwCiLXuQQFUoUP5Y9GUqCmhd7ltdZL2n4DUJz03eX+WT2+Ad0w+Ohundh0DX32tLdk7HVPzIH7BOUuyjHMSrTN/J6K6/71BXjFqP5QrGkPcbqlUamiumG9PDYVsb2R4McOQ+SdcxueEhFZtfCVhTfsE2YNG8CY5HU7t/8F8El7IuSI/iYCmympwOhtd6a7yp8o1EmCYDdxGD2bkiKYFTzqFwZREpFjW05nRc/FKunf2Gum09NGoS8Ly6OkQsnK4zMOi72iwu+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3H/uo3LoNjVH0KpcePJDaPIt7omkuoutOTxWHAQg/qQ=; b=EKDLggJ4ixlEOeMInkh9mGa+LXm2X13jqMlYmcM4oXDIBJEI4JRUidcJQI5bPHe4iBczD0DF9I4wUA6/A1jfqRmlU54NuMiTr0lha5P3uiEOqWLg2zNlvFmJH7h2yBxDc5LV6JxUGIF6W3n7F+K3Nz9BRrsKaHSy0ku6LwN1zOw= Received: from VI1PR08MB5312.eurprd08.prod.outlook.com (2603:10a6:803:139::24) by PAXPR08MB6464.eurprd08.prod.outlook.com (2603:10a6:102:df::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Wed, 17 Aug 2022 20:44:24 +0000 Received: from VI1PR08MB5312.eurprd08.prod.outlook.com ([fe80::d0ed:a69f:5951:2d06]) by VI1PR08MB5312.eurprd08.prod.outlook.com ([fe80::d0ed:a69f:5951:2d06%9]) with mapi id 15.20.5504.028; Wed, 17 Aug 2022 20:44:24 +0000 From: "Samer El-Haj-Mahmoud" To: Dimitrije Pavlov , "devel@edk2.groups.io" CC: Ard Biesheuvel , Jiewen Yao , Liming Gao , Sunny Wang , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud Subject: Re: [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argument in GetControllerName Thread-Topic: [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argument in GetControllerName Thread-Index: AQHYskaUqt0NCAIcbUGeN8qacSDtnq2zj5ag Date: Wed, 17 Aug 2022 20:44:24 +0000 Message-ID: References: <20220817143503.3279277-1-dimitrije.pavlov@arm.com> In-Reply-To: <20220817143503.3279277-1-dimitrije.pavlov@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 72E1DAEF4EC0BE46987BE2813B3A185F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9f90af53-e808-4088-cd02-08da809149dc x-ms-traffictypediagnostic: PAXPR08MB6464:EE_|AM7EUR03FT048:EE_|PAXPR08MB6493:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: P4nkht7xHF9W8eCHX/WWYDPd2M0kWSoByGrYVkgOKciZn9CMsDTbiscZOlDDcBT98EiIB1TTWkSAxfxPh22PvGx9/M2uecBs958dXtQoCMPzxEZOhr1nUdR/zdidSt5T5wPVQ6YIRAzGP0EIr0qC/RaLsHeVjjm9v6TsXCs53HYXxvlJcQLviNzITx21PRrO6a2Qh9YuqIFMmP9OEkcRdfuJ6uM9m2Vo85NgD0J9AreG7ayZmRv1R1vhGfR5nZy4zfxMDk+1edxhzvXfy+WXfDQ5AbjQ1Pb8zrUnQH12vMIMXMURCoYL5rm0iA3ojEs2UVJgos7DCtvm3PU0OUYfAmGXn0rPW2woOtrSK2w4Riuk6wjjEeAekNsv50mMG34oo/clyf5KIUPUnuW64M7HR0DSUEpgR21uOMfM+947hOLIagjc7UIqRkoUqeleORRh5TZyu9dwJ8DL2QByAVNDO0UfUl3+u1B9CNBJXiF0nkibOxv/prECDKzmnXIRCdao9BiW9r/Yh1+OV5Tx46Oes8K3qx9kOENWciWm30Ch1a7RefPvnARS65KisVi2DN6BPNyFCymoRuTINctCDjgSWWG9PKOn5A0Nwgrg/u1YJUITrwnljKFhuon+wqQWAu3jqqnJat6JHAn2LXFt8vH/S+gUzYAWMm/wvB4uekz0oDOQgZ+V0Ckn33Lu3JKCBBWIB7jxkaJ35CPFSrJEVHyss5r1ff9TsshXS7JAXHGjwxr+YUkdkn151Eaq4D+Bc5e76ht4lPzZoo2VoXat8AoDsg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB5312.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(136003)(366004)(346002)(396003)(4326008)(66946007)(76116006)(66556008)(478600001)(66476007)(64756008)(71200400001)(8936002)(66446008)(86362001)(38070700005)(186003)(8676002)(83380400001)(122000001)(38100700002)(41300700001)(6506007)(5660300002)(52536014)(2906002)(53546011)(7696005)(33656002)(54906003)(9686003)(110136005)(316002)(55016003)(26005);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6464 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 27100869-348b-4d1f-5cab-08da80914535 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9I34mwLssfZJxPhkBl8YHjcTFsukHImPNDLjKPBi8rMIG4InYnLWPcxvGi72lQsEj724t43g+NYMhrlF4j5qnCbdT2c5gj+68rHyDLVwYZnn5IRspezqcyvD9eMpGkUjNOXTsc/FKGxgPEQjnBpR+ZvIad47FpiJ7mkvpdu7WtDQ5ESZH5iHAKh2fht6mNVs/MgHhth0HeMCAqe5sTZuGTUvFlu9iDXB52YEwlIUr0KMBgIqt3oYti3rEtUhx6cqf3RH2JGXyCf4JJbFp8Bwgkppj3NSHipSea4YLDiRgY5UuZ9ngRJz8wHZBVmuHkFlq/LNbvYt02nf7LVXQkO3W4hvrco2rCALV4OEXHh3sDY+1t5Olvs1/b0p5g1jVNCk8gmj8SqHN1WaGRxrKIP/7Epo4ldjwyyaLZXuJlJM6Pd4Erjsm7eHGZWFtU+qZj1h3XnelN5+JLlsU/4er6D6PDcfT9qYe0RuvJREc0ATgym+iqN2zh3WWKFgUDga10/F9a2KDBYvOzjRUmgxkaOaQNI0XTrXusx6vgr2e5y2mBdZAeElbg1Ontm74sUbFAXRh3UChah51geNFSQR09EUX6TiK/lnNoXnnJU0U6MGBiOjW+y1E6ODu5L/NyvvMsfs4VTdNqd/uxkOK6JajReNFQuYkFzHsPY+oGyQdSNl/zWk22uuzmpuU6jmznAQw3u3cI2IxKt2I0YqgDYp54eH6K+iqeNBUdPJkMNXd1cq6j1EnZSYngAE6OLz0wm36n7j5BkrDzS7Ejc1J2nGDkW+Ew== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(39860400002)(396003)(376002)(46966006)(40470700004)(36840700001)(9686003)(6506007)(7696005)(86362001)(26005)(33656002)(53546011)(186003)(36860700001)(82740400003)(81166007)(82310400005)(83380400001)(47076005)(336012)(356005)(55016003)(40480700001)(40460700003)(5660300002)(478600001)(70206006)(52536014)(8936002)(8676002)(4326008)(2906002)(70586007)(110136005)(41300700001)(54906003)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 20:44:32.3541 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9f90af53-e808-4088-cd02-08da809149dc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6493 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-By: Samer El-Haj-Mahmoud > -----Original Message----- > From: Dimitrije Pavlov > Sent: Wednesday, August 17, 2022 10:35 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Jiewen Yao > ; Liming Gao ; Sunny > Wang ; Jeff Booher-Kaeding Kaeding@arm.com>; Samer El-Haj-Mahmoud Mahmoud@arm.com> > Subject: [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argument = in > GetControllerName > > Per the UEFI specification, a device driver implementation should return > EFI_UNSUPPORTED if the ChildHandle argument in > EFI_COMPONENT_NAME2_PROTOCOL.GetControllerName() is not NULL. > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Liming Gao > Cc: Sunny Wang > Cc: Jeff Booher-Kaeding > Cc: Samer El-Haj-Mahmoud > > Signed-off-by: Dimitrije Pavlov > --- > OvmfPkg/VirtioNetDxe/ComponentName.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/OvmfPkg/VirtioNetDxe/ComponentName.c > b/OvmfPkg/VirtioNetDxe/ComponentName.c > index e340ca2f8fe4..718096630f6f 100644 > --- a/OvmfPkg/VirtioNetDxe/ComponentName.c > +++ b/OvmfPkg/VirtioNetDxe/ComponentName.c > @@ -129,6 +129,13 @@ VirtioNetGetControllerName ( > return EFI_INVALID_PARAMETER; > } > > + // > + // This is a device driver, so ChildHandle must be NULL. > + // > + if (ChildHandle !=3D NULL) { > + return EFI_UNSUPPORTED; > + } > + > // > // confirm that the device is managed by this driver, using the VirtIo > // Protocol > -- > 2.37.2 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.