From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.83]) by mx.groups.io with SMTP id smtpd.web10.7901.1664371945216141478 for ; Wed, 28 Sep 2022 06:32:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=j5e1xDhl; spf=pass (domain: arm.com, ip: 40.107.6.83, mailfrom: samer.el-haj-mahmoud@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=OWmJuRx/K6ewWRkrIYsCH71Wmdv2AsJC3B2UNe4Rgo9u54AOmSA5u8nhB5KWBPXORAEHpt58d93ichNdZNA0GPK9jXGeQfeblaKqGpr1zt9qBVGeJQKORCfd0wrV5YFKVbTvXUvO5Gy3a65hzEaUUQU9IeJPJuanqxllmfhnYkw+cnKL9DK6/5f7HxuW2G+JyO/e0Q0vnuPejBZKzOHMVmIKEbQ1fQjA53ok94C7/LGzqVYt8f3JNppNyisXbL3fCIxQ3dw2oIef5kburQsCImgcJLmdBE5Sqg9NJfaztsS5ZBVj57ECVrcAv0KPei4ZqFFHQ/LPM4Y4KP2tqsfL/Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=scHve7bhOTyjgXROYQL0Eswzrial9VB6OTaMojSil/k=; b=QAChhswmFAhcGnaYTNLnx+b9OA30tf026hv3yFISo2i5ngBOBh3kYAGYstUq5FCnToRiwOf7uMGPUuESxDW2/PNWiSU4CkqVpv8djDBXj1ZYJiYdxwlkg4r2aLsksiCowD3bNMoO/JzI3cw/cNyozee9c6dabgmxV2zqH2iRCCHMjT+CK5nkn9BThKhcGsjQnJQ7MAiFBe3brbzkbhV4RVjE9Oyu0BA8zVwK2s/4tJSYEiwalYjTE3oAlSJw1MqJoyYkM+HY6xukmvSyLCAtoQQSXBRS9RPJuUcjN+D/Am48WxmnOEHzbbxeo7snCMcLm+hAnR0r1CXOK0HGRuRJig== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=scHve7bhOTyjgXROYQL0Eswzrial9VB6OTaMojSil/k=; b=j5e1xDhl+kGC8AI8+aRzxWQlnAHc21S2bGyPhnhow9NuwrNTsgeq5UAD9UQ0osk+LbfQTp6lBpo9/isaixPzT2Q1ORBAmJhax9l7SnX/BcBX8vhqcXG5V3VDB45tdi5XmktCuunMu+isDIODzL5loTZeJJgMOtmVE0K9qfZENhI= Received: from AM6P195CA0001.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::14) by AS1PR08MB7585.eurprd08.prod.outlook.com (2603:10a6:20b:471::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Wed, 28 Sep 2022 13:32:21 +0000 Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:81:cafe::c0) by AM6P195CA0001.outlook.office365.com (2603:10a6:209:81::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Wed, 28 Sep 2022 13:32:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Wed, 28 Sep 2022 13:32:21 +0000 Received: ("Tessian outbound d354c7aef2bc:v128"); Wed, 28 Sep 2022 13:32:20 +0000 X-CR-MTA-TID: 64aa7808 Received: from 2cdc6932451c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EF6965AF-CAEB-43CB-983A-2C86A86C5DAD.1; Wed, 28 Sep 2022 13:32:15 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2cdc6932451c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 28 Sep 2022 13:32:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mFdxjtApN2uxbPo4DDcIthTtspJ/PLsxvr8c4hFA1v6BLeo6/xmDYIdMd1wTDEgFxp7W17+fo7DvX9j7jHRwisojhFR6iSbAqARdKEiNfzaQGvCmZd5nRPybCVFgYXcChbidnOUJzX0aa4WSX5OGRAe++lO3NWkSYQ/K9U/t3faYhui2QWeMDWBXOGam28CD394DiwMern5MvyUsHnvvNhDaNZNh33cWjy2vE82iZnG3Joa3wnkiVIOd+zNp/iskXcIPtk+1uqA3HhBAHsh5KQgVo82MrUili5EqcIuHvBAUNiK6zaqIk7HuLu+x0ayVjd+IkneblgmVWG/w2qAG8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=scHve7bhOTyjgXROYQL0Eswzrial9VB6OTaMojSil/k=; b=G0Ipxjb/uuXPj/5R2e6HCdSqdb2ccgsoxH2Kac9R84/j8JWeGC9YSgrBtMDwflOlcyQIk5S15XG4MIq/Wx2Iz8493SEai3sncBSNI8reXfAHHnnU43U5GUoF4AKD2vKAXdTcsufjCeDuzHDqNsmVB4BoK3Di7ItiSd/FOhGek0VMviS35zlhfR2FVnyqSXRMP03QuKeOchGKIEGl6TY+lY+xXl8DUoStP7rD+VlurPTyIxpGnWO55AGyRFYBv7vxmMIvOA6tq9CFjaMFOvXaMAElMVtCtsvsxsCLIXorSSVqlwT3c8P6WUhs1or3Kj3v8foWCx3iOTh493qCTKX9AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=scHve7bhOTyjgXROYQL0Eswzrial9VB6OTaMojSil/k=; b=j5e1xDhl+kGC8AI8+aRzxWQlnAHc21S2bGyPhnhow9NuwrNTsgeq5UAD9UQ0osk+LbfQTp6lBpo9/isaixPzT2Q1ORBAmJhax9l7SnX/BcBX8vhqcXG5V3VDB45tdi5XmktCuunMu+isDIODzL5loTZeJJgMOtmVE0K9qfZENhI= Received: from VI1PR08MB5312.eurprd08.prod.outlook.com (2603:10a6:803:139::24) by PAXPR08MB6416.eurprd08.prod.outlook.com (2603:10a6:102:152::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep 2022 13:32:13 +0000 Received: from VI1PR08MB5312.eurprd08.prod.outlook.com ([fe80::a1cc:1fdc:8c97:dde7]) by VI1PR08MB5312.eurprd08.prod.outlook.com ([fe80::a1cc:1fdc:8c97:dde7%4]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022 13:32:12 +0000 From: "Samer El-Haj-Mahmoud" To: Sunny Wang , Dimitrije Pavlov , "devel@edk2.groups.io" CC: Ard Biesheuvel , Jiewen Yao , Liming Gao , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud Subject: Re: [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argument in GetControllerName Thread-Topic: [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argument in GetControllerName Thread-Index: AQHYskaUqt0NCAIcbUGeN8qacSDtnq22UIMAgD7ICJA= Date: Wed, 28 Sep 2022 13:32:12 +0000 Message-ID: References: <20220817143503.3279277-1-dimitrije.pavlov@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4482A8F3ED9BE84F8DBFE231740ABF54.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: VI1PR08MB5312:EE_|PAXPR08MB6416:EE_|VE1EUR03FT024:EE_|AS1PR08MB7585:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f0aef47-cc1b-4ab1-160f-08daa155df0d x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +B5x6tV2ZLUFKXnSAMMv2PinV/E3znMVcCPoul4wixzo0PgDYAdYqOJ5mnqa8OKdnL/9Poi9WIWmE1rL03n8tDhE7CrtUmDFVXsBtA5MmwAxkXS7gLCEU+B9sp+bHWa0hzkylr/JAFN6M/8jxcmRBxoAdqSrlw9zCCjyIdaR9NwqMfIaiOJO+Xz0HlS32bVgEqSCiVuBmBE/H5b9qEiTWU6x47m/yHdwzJM4wR0Pdm7ebS52gA0W0QfKcwrf61ZV+ON8ovBkoVOgLYZhi6DGsABGcqgcCFx7ZYAxpauNyT3Ins4eEBvr8PFMQRknGWIO3P2F3cEt4uEJdkNbzK9BWnIsRTytSUzCj5DpJnC+hF6bWnN9+VxjMbz8Q16Kujfw/2I5yjChzY3Rui7akTqlIA32Hqpnbp/nI8B7TsbocA0rdaGkwoUSG6Bq0xR8lpL7aEDZdtxnHJAK0buMH9ES+UaKB1JWqILfQNPMk6AQovAltnoHh3TDhSPbeYdhq9IjnFOHPrpYlOygMgYVbcX2pM1y1qB1aSfsrjXCbMD1NoTdj2jAWCuAl2n419lMn4To1pROdSgSg0TvRmqwDiksxjHLyuiPOQ5Y4TRuEXUg8lI68AieHv3gK75lI1c00ejhsEORXo9BI+VAtiOcyQu1aqGvANKEd2h+36qhs1KHCvKqU9VMtNlPPWOOKFcrwH7fQNmxbB+rudNVAsbxNT6rLr7QFkIU17Nrj1aoPS3eaXcV1Ip22dKT/nOsxLgVO6chbpM6FYZN1i69/iesOJU72w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB5312.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(346002)(376002)(136003)(396003)(451199015)(38100700002)(186003)(83380400001)(122000001)(86362001)(38070700005)(52536014)(76116006)(8936002)(5660300002)(66946007)(64756008)(66556008)(66446008)(41300700001)(33656002)(66476007)(4326008)(2906002)(71200400001)(54906003)(8676002)(6506007)(7696005)(26005)(110136005)(53546011)(9686003)(316002)(55016003)(478600001);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6416 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bbad2423-dbc9-4b7b-0fe2-08daa155da15 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hVgSYTNhp0GO7HQjDBTWykTGyhQTKxVSRdKQfKIg6c58EkVsQ7c2G7CGix1cyFcnDMRLUCtlrTBECeH2HC9k3/UQ/BP31jOaawbd1pGF9L8/SOgXJsNp1b999G+wAnfEuQKzji+16NIVvNZOX2jAOgZSTA9YNzzd3GgEvBimeRat+plQpL/fyloi+utfw8dFL41zPhntmRzTtHvSwC+h3MdelVO+CYNy0KHHfk34tmrMyLunmG+r4CKFcVsPbsNLDZbc4MLSCMM6M6z/Ng9dI8m0vQWbS2bbcKeXzVJo7FITbXPQXUa5UjNPG5pl6pcnijxY5GGaXzn9KIAm+Zv8Ck0MVxs5wtgYQRY7F29DYkWW96WYc1ZUrS6xu3vErymL7XAAE6PwWNhpjwSt3DOspN437vYJaWhFbeaCp3neBMNczBPP4iUAEl0cf5aFognPss2MlCOqBY77k+ziPBn2MrxEUPt/xLuqQ/WLyqGYrK2Rj9ingFn5tsXL98sdak13yUSkngEJ8PYrY+x5q0/5X+0QjotdhHIn6iHNuXpSzZtHSpFnslHfLel78ezDZN5sy2Vbsvo34wT03YkX84jKiUZ6sNlLDFwHtL/elNnuyJhZt1FK1WD1AUSft2RYX5uCx+LdFvj7KJVLhZ73GroZ4/+qWy+ZBaWuQC5k2J6nFw4yrG0yS8rSJ7kphi1f3T4eR21IfYZ93x+wRzy0Fbs4cXG8SSCZvKDbSmYXlVt/NBjI4s4uj97YmYZm2eXcdHqilgxzCTTuLwx3r4708P16Vg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(396003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(47076005)(336012)(186003)(41300700001)(2906002)(82740400003)(52536014)(26005)(9686003)(53546011)(6506007)(8936002)(40460700003)(7696005)(40480700001)(5660300002)(55016003)(356005)(82310400005)(81166007)(83380400001)(86362001)(33656002)(36860700001)(54906003)(110136005)(478600001)(4326008)(316002)(8676002)(70206006)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2022 13:32:21.1721 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f0aef47-cc1b-4ab1-160f-08daa155df0d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7585 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ard, Any luck getting this one merged? Thanks, --Samer > -----Original Message----- > From: Sunny Wang > Sent: Friday, August 19, 2022 10:47 AM > To: Dimitrije Pavlov ; devel@edk2.groups.io > Cc: Ard Biesheuvel ; Jiewen Yao > ; Liming Gao ; Jeff > Booher-Kaeding ; Samer El-Haj-Mahmoud > ; Sunny Wang > Subject: RE: [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argum= ent > in GetControllerName > > Looks good. > Reviewed-by: Sunny Wang > > -----Original Message----- > From: Dimitrije Pavlov > Sent: 17 August 2022 15:35 > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Jiewen Yao > ; Liming Gao ; Sunny > Wang ; Jeff Booher-Kaeding Kaeding@arm.com>; Samer El-Haj-Mahmoud Mahmoud@arm.com> > Subject: [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argument = in > GetControllerName > > Per the UEFI specification, a device driver implementation should return > EFI_UNSUPPORTED if the ChildHandle argument in > EFI_COMPONENT_NAME2_PROTOCOL.GetControllerName() is not NULL. > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Liming Gao > Cc: Sunny Wang > Cc: Jeff Booher-Kaeding > Cc: Samer El-Haj-Mahmoud > > Signed-off-by: Dimitrije Pavlov > --- > OvmfPkg/VirtioNetDxe/ComponentName.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/OvmfPkg/VirtioNetDxe/ComponentName.c > b/OvmfPkg/VirtioNetDxe/ComponentName.c > index e340ca2f8fe4..718096630f6f 100644 > --- a/OvmfPkg/VirtioNetDxe/ComponentName.c > +++ b/OvmfPkg/VirtioNetDxe/ComponentName.c > @@ -129,6 +129,13 @@ VirtioNetGetControllerName ( > return EFI_INVALID_PARAMETER; > } > > + // > + // This is a device driver, so ChildHandle must be NULL. > + // > + if (ChildHandle !=3D NULL) { > + return EFI_UNSUPPORTED; > + } > + > // > // confirm that the device is managed by this driver, using the VirtIo > // Protocol > -- > 2.37.2 > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.