Hi Ming/Sami,

I am working on adding RISCV standalone MM support along with yong.li@intel.com. Since some part of this code is common for all arch, I had a question on this particular patch https://gitlab.ba.rivosinc.com/rv/sw/int/fw/cpu/edk2/-/commit/5496c763aaddc4a47639d4652abe23aa3419263a submitted by you. I wanted to understand the implication before I align implementation with RISCV64 if you could help with that.

The question is as follows:

I see there are couple of places where non secure buffer pointer is being communicated to MM. gEfiStandaloneMmNonSecureBufferGuid and gMmCommBufferHobGuid. Unless I have mistaken, the purpose of both buffers is similar. I wonder do we expect MM to comprehend them differently? 

MmEntryPoint() now uses mMmCommunicationBuffer derived from gMmCommBufferHobGuid. CheckBufferAddr() uses mNsCommBuffer which is derived from gEfiStandaloneMmNonSecureBufferGuid. Can you please help clarify?

=D

 

_._,_._,_

_._,_._,_