From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mx.groups.io with SMTP id smtpd.web10.11255.1676895399712632276 for ; Mon, 20 Feb 2023 04:16:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=EA5EABj5; spf=pass (domain: ventanamicro.com, ip: 209.85.214.179, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pl1-f179.google.com with SMTP id ky4so2329832plb.3 for ; Mon, 20 Feb 2023 04:16:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GfYnfoR36WMpVC3XmqWuXjhB20FF0Z89kE9rcHkH1/c=; b=EA5EABj5WJsqgRhxAtD2kFDzlpBDQMYizlGdQrY31uwA4ZgmLzslf9auc4jNBipzSN FaT38fLPADXm+s3KC3ceUeIFZMDvbZcJG/+BNn/nYJBI0haoVu/Ly+bMdJKL/33NGKla sUd8qTI0aKcxZSwgupCfhFOQ+0hbUGSGYwN43forqUKmiCyIuBf73b97jUZ63Up49E0t c9ivINCvpN8vQ6mTK40kq310ZAla5ONSQT3SvgZo+utRhiytVOUERB8YrUh1uSxDdPPz LzPKYLqrGXsBEmiJqPf/fhlkUy1zrAtfsyGdREDcd17ztGRbs5raVSUv+a6F2ui2otT+ WOLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GfYnfoR36WMpVC3XmqWuXjhB20FF0Z89kE9rcHkH1/c=; b=b8Tw5f39oDJ1cHxsH4M+N5FlSJaiSGnwh5J5z3xgMKqUCmPoTm/rpBF3fQw7OPiWM2 ONwaE+3Wh6SjhU9JUp3M8NxecMWuLu3h9CB+/ngiHlNf+esUAEJe6KHebYR/VpEPsRlY oJiDH6o6XRjbbuJEeK+vUsu8qSs8TI3sVn6Ly9hI+euJpZX8ZIDpTJZIyjfEKO+KfuNS yBJuxzv+ncnaJRHXIw/NjpMUlzejs/C9LRBB9fJHZGD5m8Dxe6Dj3G1bJQz55p8YC1Cv 01jH4LSmu2lQVpVaV2fkZZpODSX85yVeZ4ObimrZQX0bKA/kT9JSi0ty8lzJa/ZCs8Vh f1uA== X-Gm-Message-State: AO0yUKVkCz+Oo5iZ/u0etQJ5yRr5JNVGRCYkDbxnQkjpcRi1k4p2G1BW KVVEzj/BrTGLGAAEi8/A6ORDkw== X-Google-Smtp-Source: AK7set8A9XEjot0HyEbo3oxE3j+F6xVd8mzRuZ5YaFRdrivkq79U7jSpK/mCtaWeQtLexm/2pgfnxg== X-Received: by 2002:a05:6a20:1604:b0:bc:e2f6:8788 with SMTP id l4-20020a056a20160400b000bce2f68788mr597521pzj.24.1676895399177; Mon, 20 Feb 2023 04:16:39 -0800 (PST) Return-Path: Received: from sunil-laptop ([49.206.14.226]) by smtp.gmail.com with ESMTPSA id v18-20020aa78512000000b005a8ba6e1464sm6083317pfn.38.2023.02.20.04.16.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 04:16:38 -0800 (PST) Date: Mon, 20 Feb 2023 17:46:32 +0530 From: "Sunil V L" To: Andrei Warkentin Cc: devel@edk2.groups.io, Daniel Schaefer , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: Re: [edk2 1/1] BaseLib: don't log in InternalSwitchStack Message-ID: References: <20230218042921.922-1-andrei.warkentin@intel.com> MIME-Version: 1.0 In-Reply-To: <20230218042921.922-1-andrei.warkentin@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thanks for these fixes!, Andrei. Could you please use below format for the subject? PackageName: ModuleName: summary of changes Also, could you create single patch series with these patches? Otherwise, Reviewed-by: Sunil V L On Fri, Feb 17, 2023 at 10:29:21PM -0600, Andrei Warkentin wrote: > InternalSwitchStack may be called with a TPL high > enough for a DebugLib implementation to assert. > > Other arch implementations don't log either. > > Cc: Sunil V L > Cc: Daniel Schaefer > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Signed-off-by: Andrei Warkentin > --- > MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c b/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c > index cf646e498aba..b78424c16383 100644 > --- a/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c > +++ b/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c > @@ -44,14 +44,6 @@ InternalSwitchStack ( > { > BASE_LIBRARY_JUMP_BUFFER JumpBuffer; > > - DEBUG (( > - DEBUG_INFO, > - "RISC-V InternalSwitchStack Entry:%x Context1:%x Context2:%x NewStack%x\n", \ > - EntryPoint, > - Context1, > - Context2, > - NewStack > - )); > JumpBuffer.RA = (UINTN)EntryPoint; > JumpBuffer.SP = (UINTN)NewStack - sizeof (VOID *); > JumpBuffer.S0 = (UINT64)(UINTN)Context1; > -- > 2.25.1 >