From: "Sunil V L" <sunilvl@ventanamicro.com>
To: Andrei Warkentin <andrei.warkentin@intel.com>
Cc: devel@edk2.groups.io, Daniel Schaefer <git@danielschaefer.me>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>
Subject: Re: [edk2 1/1] RISCV: Fix CpuSleep symbol name.
Date: Mon, 20 Feb 2023 17:52:56 +0530 [thread overview]
Message-ID: <Y/NmIOFmcuTHr9H7@sunil-laptop> (raw)
In-Reply-To: <20230218043036.983-1-andrei.warkentin@intel.com>
Same feedback regarding the subject.
Otherwise,
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
On Fri, Feb 17, 2023 at 10:30:36PM -0600, Andrei Warkentin wrote:
> CpuSleep, not _CpuSleep.
>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Andrei Warkentin <andrei.warkentin@intel.com>
> ---
> MdePkg/Library/BaseCpuLib/RiscV/Cpu.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdePkg/Library/BaseCpuLib/RiscV/Cpu.S b/MdePkg/Library/BaseCpuLib/RiscV/Cpu.S
> index 375b91d31427..d6560087e080 100644
> --- a/MdePkg/Library/BaseCpuLib/RiscV/Cpu.S
> +++ b/MdePkg/Library/BaseCpuLib/RiscV/Cpu.S
> @@ -10,9 +10,9 @@
> .align 3
> .section .text
>
> -.global ASM_PFX(_CpuSleep)
> +.global ASM_PFX(CpuSleep)
>
> -ASM_PFX(_CpuSleep):
> +ASM_PFX(CpuSleep):
> wfi
> ret
>
> --
> 2.25.1
>
prev parent reply other threads:[~2023-02-20 12:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 4:30 [edk2 1/1] RISCV: Fix CpuSleep symbol name Andrei Warkentin
2023-02-20 12:22 ` Sunil V L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/NmIOFmcuTHr9H7@sunil-laptop \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox