* [edk2 1/1] RISCV: Fix CpuSleep symbol name.
@ 2023-02-18 4:30 Andrei Warkentin
2023-02-20 12:22 ` Sunil V L
0 siblings, 1 reply; 2+ messages in thread
From: Andrei Warkentin @ 2023-02-18 4:30 UTC (permalink / raw)
To: devel
Cc: Andrei Warkentin, Sunil V L, Daniel Schaefer, Michael D Kinney,
Liming Gao, Zhiguang Liu
CpuSleep, not _CpuSleep.
Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: Daniel Schaefer <git@danielschaefer.me>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Andrei Warkentin <andrei.warkentin@intel.com>
---
MdePkg/Library/BaseCpuLib/RiscV/Cpu.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Library/BaseCpuLib/RiscV/Cpu.S b/MdePkg/Library/BaseCpuLib/RiscV/Cpu.S
index 375b91d31427..d6560087e080 100644
--- a/MdePkg/Library/BaseCpuLib/RiscV/Cpu.S
+++ b/MdePkg/Library/BaseCpuLib/RiscV/Cpu.S
@@ -10,9 +10,9 @@
.align 3
.section .text
-.global ASM_PFX(_CpuSleep)
+.global ASM_PFX(CpuSleep)
-ASM_PFX(_CpuSleep):
+ASM_PFX(CpuSleep):
wfi
ret
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2 1/1] RISCV: Fix CpuSleep symbol name.
2023-02-18 4:30 [edk2 1/1] RISCV: Fix CpuSleep symbol name Andrei Warkentin
@ 2023-02-20 12:22 ` Sunil V L
0 siblings, 0 replies; 2+ messages in thread
From: Sunil V L @ 2023-02-20 12:22 UTC (permalink / raw)
To: Andrei Warkentin
Cc: devel, Daniel Schaefer, Michael D Kinney, Liming Gao,
Zhiguang Liu
Same feedback regarding the subject.
Otherwise,
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
On Fri, Feb 17, 2023 at 10:30:36PM -0600, Andrei Warkentin wrote:
> CpuSleep, not _CpuSleep.
>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Andrei Warkentin <andrei.warkentin@intel.com>
> ---
> MdePkg/Library/BaseCpuLib/RiscV/Cpu.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdePkg/Library/BaseCpuLib/RiscV/Cpu.S b/MdePkg/Library/BaseCpuLib/RiscV/Cpu.S
> index 375b91d31427..d6560087e080 100644
> --- a/MdePkg/Library/BaseCpuLib/RiscV/Cpu.S
> +++ b/MdePkg/Library/BaseCpuLib/RiscV/Cpu.S
> @@ -10,9 +10,9 @@
> .align 3
> .section .text
>
> -.global ASM_PFX(_CpuSleep)
> +.global ASM_PFX(CpuSleep)
>
> -ASM_PFX(_CpuSleep):
> +ASM_PFX(CpuSleep):
> wfi
> ret
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-20 12:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-18 4:30 [edk2 1/1] RISCV: Fix CpuSleep symbol name Andrei Warkentin
2023-02-20 12:22 ` Sunil V L
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox