public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sunil V L" <sunilvl@ventanamicro.com>
To: devel@edk2.groups.io, andrei.warkentin@intel.com
Cc: Daniel Schaefer <git@danielschaefer.me>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Jian J Wang <jian.j.wang@intel.com>
Subject: Re: [edk2-devel] [edk2 1/1] Dxe: add RISCV64 to mMachineTypeInfo
Date: Mon, 20 Feb 2023 17:57:49 +0530	[thread overview]
Message-ID: <Y/NnRTe4jp+ttCB2@sunil-laptop> (raw)
In-Reply-To: <20230218043626.1755-1-andrei.warkentin@intel.com>

Please update the subject.

Otherwise,
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

Thanks!
Sunil
On Fri, Feb 17, 2023 at 10:36:26PM -0600, Andrei Warkentin wrote:
> This fixes messages like:
> "Image type AARCH64 can't be loaded on <Unknown> UEFI system"
> 
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Signed-off-by: Andrei Warkentin <andrei.warkentin@intel.com>
> ---
>  MdeModulePkg/Core/Dxe/Image/Image.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/Image/Image.c
> index 06cc6744b8c6..8704ebea9a7c 100644
> --- a/MdeModulePkg/Core/Dxe/Image/Image.c
> +++ b/MdeModulePkg/Core/Dxe/Image/Image.c
> @@ -81,7 +81,8 @@ GLOBAL_REMOVE_IF_UNREFERENCED MACHINE_TYPE_INFO  mMachineTypeInfo[] = {
>    { EFI_IMAGE_MACHINE_IA64,           L"IA64"    },
>    { EFI_IMAGE_MACHINE_X64,            L"X64"     },
>    { EFI_IMAGE_MACHINE_ARMTHUMB_MIXED, L"ARM"     },
> -  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64" }
> +  { EFI_IMAGE_MACHINE_AARCH64,        L"AARCH64" },
> +  { EFI_IMAGE_MACHINE_RISCV64,        L"RISCV64" },
>  };
>  
>  UINT16  mDxeCoreImageMachineType = 0;
> -- 
> 2.25.1
> 
> 
> 
> 
> 
> 

      reply	other threads:[~2023-02-20 12:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-18  4:36 [edk2 1/1] Dxe: add RISCV64 to mMachineTypeInfo Andrei Warkentin
2023-02-20 12:27 ` Sunil V L [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y/NnRTe4jp+ttCB2@sunil-laptop \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox