From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mx.groups.io with SMTP id smtpd.web11.5881.1675879983917961106 for ; Wed, 08 Feb 2023 10:13:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=C8qwDCVa; spf=pass (domain: ventanamicro.com, ip: 209.85.216.45, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pj1-f45.google.com with SMTP id j1so13331814pjd.0 for ; Wed, 08 Feb 2023 10:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gUxIAmthnSefMdz8N9JmvqTHL6xpML+oeFt8Q9okgVk=; b=C8qwDCVadt9DgsrNGC/pV20vzpBW0wg5AP06+6jslHHcip5+wT8PEsIaOk/NiMrJNq Ob98u7aCnEW45L0ZP0Ne0712XLnGw/EXhy30D7R2EMsZfMsykJIS2TJtvGE0tfMtdoUn ejZsxQStbVETbqmFMUoOe9qj7O4Vs5YEpX/fJ2mNatYfy9btwdXg9U7Il2jPIRO2DE2m ETguAA6dR2Ha7DPbQQdVpLy+kYryjv11/xqhelIjMOGvHRqc4Z9mn6kGYeel8XivNpqn sUPi4VTmNSmwLDk+MdPuGqmfS3lnrnQXVZw1PM228gdl1BQMv/0OFtNfVmq1LU/ngr8U 6o2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gUxIAmthnSefMdz8N9JmvqTHL6xpML+oeFt8Q9okgVk=; b=HbcNqIN61+k9ENcl7DogiRa8uPRRoXiUg+U59ELkxTePBYWcez7Zb4BNvQ8iAZ0rFx ++g06hDDWXu7PHEYPyJVSDTAT5VacGdpXzvhfwHayp4R0i98dH0kAgdP0EQAGkDeNH4Q fWm/CBmRZRshCyz1D6joSP1Rl9s6Hfdb8yrZtJlwbtS6NzGVya4SYxvFwfw4hZV1ZenW jqM9E9+R9eK8IAR+7NA3ZCdPISXSmActpBHmH3XeRZ6aYp1zSvaOpUQ6q9rp7vbEQqrA InbJcI6iiRNrUJvPuj3hwDgMGHIv4sTWVIeHazxswCNLqGJfnzbg+L3+9/IliL89Ltll vIdQ== X-Gm-Message-State: AO0yUKU414Tkt1DceQjsSQ6v6+DUk3vMHrlc1x50Bi+PLW6cES2N7yvn S3WK5cZsl1iWw5+YE2KGAIc8DA== X-Google-Smtp-Source: AK7set/QsnulLzeizQU9xncBgfIA6gXrbh5vhOYmNUzCmL8kKL/1YFBi9zwux4X6Ewwsp5egN8gZHQ== X-Received: by 2002:a05:6a20:54a0:b0:bd:b061:9527 with SMTP id i32-20020a056a2054a000b000bdb0619527mr9905772pzk.4.1675879983403; Wed, 08 Feb 2023 10:13:03 -0800 (PST) Return-Path: Received: from sunil-laptop ([49.206.14.226]) by smtp.gmail.com with ESMTPSA id c2-20020a637242000000b004db367c10b0sm9917408pgn.46.2023.02.08.10.13.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 10:13:02 -0800 (PST) Date: Wed, 8 Feb 2023 23:42:56 +0530 From: "Sunil V L" To: "Kinney, Michael D" Cc: "devel@edk2.groups.io" , "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul R" , Daniel Schaefer , Gerd Hoffmann , Abner Chang Subject: Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 05/20] UefiCpuPkg: Add CpuTimerDxe module Message-ID: References: <20230128191807.2080547-1-sunilvl@ventanamicro.com> <20230128191807.2080547-6-sunilvl@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 08, 2023 at 06:02:44PM +0000, Kinney, Michael D wrote: > Hi Sunil, > > One comment on the name of this module. CpuTimerDxe is a very generic name, but the > Implementation is for RISCV only and depends on SBL services. Correct? > > If I look at other TimerDxe modules, they have in their name some indication of > the timer hardware/software dependencies in their name, > > * LocalApicTimerDxe.inf > * HpetTimerDxe.inf > > How about RiscVTimerDxe or RiscVSbiTimerLib? > > Mike > Thanks!, Mike. Your suggestion makes sense. Since most of the drivers in UefiCpuPkg were named as Cpu*, I named it like this. Let me change it to RiscVTimerDxe. Thanks! Sunil