From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web08.8237.1666187221845156920 for ; Wed, 19 Oct 2022 06:47:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=LgNxPUQS; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29JDR55M024112; Wed, 19 Oct 2022 13:46:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=3hJWz1izySWpHvaMvHZnfENPdVGRfXKncehwTCKONmc=; b=LgNxPUQSjtKUfDdDNidMGRprWboBrQN+dswCncByE+0dNv3EFMPuv9kXL6AzJ0jCyAxf 5qU72TCgHof951CCQDQ8EpwvCqXrIG0nmFkMWtHbuskyzssftK3xiQ7o17M3j0ToDGAc 0q0nq3rb6lXSUxXj0uBrHKv8Ynf2CDntGR5HoCLPyldQHv2XVVyJqAnSOg0+TvGOTT0R TcyXwKbg5w2qrdhoQ4Z1/kcj4cpRY3XhV0wfum5X3xXmdhDxe9KKrRx+2qO2zeSC1AR9 Uf1RwwhaDAEWHaU+cPqeCrepTUuXAnPCCpPTk8cERnBy3+y+/GZMsQUQrmEEtZXyGabz nw== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3k9qwp3rrm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Oct 2022 13:46:44 +0000 Received: from pps.filterd (NASANPPMTA05.qualcomm.com [127.0.0.1]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 29JDkhb4015642; Wed, 19 Oct 2022 13:46:43 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NASANPPMTA05.qualcomm.com (PPS) with ESMTPS id 3k9scdvqhd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Oct 2022 13:46:43 +0000 Received: from NASANPPMTA05.qualcomm.com (NASANPPMTA05.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 29JDkhIh015637; Wed, 19 Oct 2022 13:46:43 GMT Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (PPS) with ESMTPS id 29JDkhQ3015634 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Oct 2022 13:46:43 +0000 Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Wed, 19 Oct 2022 06:46:40 -0700 Date: Wed, 19 Oct 2022 14:46:37 +0100 From: "Leif Lindholm" To: Sami Mujawar CC: Ard Biesheuvel , , Sunil V L , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Daniel Schaefer , "nd@arm.com" Subject: Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 25/29] OvmfPkg: Add NorFlashQemuLib library Message-ID: References: <20221010101202.1146624-1-sunilvl@ventanamicro.com> <20221010101202.1146624-26-sunilvl@ventanamicro.com> <2f9cdb28-7fa0-c2a2-d53c-7f2f7e87aef3@arm.com> <4679fd99-b2db-8ab5-5734-514480c4c830@arm.com> MIME-Version: 1.0 In-Reply-To: <4679fd99-b2db-8ab5-5734-514480c4c830@arm.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: GpRP5TUjx_Q5lx840iDFFNfwvYbP4hRq X-Proofpoint-ORIG-GUID: GpRP5TUjx_Q5lx840iDFFNfwvYbP4hRq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-19_08,2022-10-19_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 impostorscore=0 phishscore=0 bulkscore=0 mlxlogscore=720 malwarescore=0 adultscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210190077 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Wed, Oct 19, 2022 at 14:19:28 +0100, Sami Mujawar wrote: > > > Considering this, should QemuNorFlashDxe be called OvmfNorFlashDxe? > > > > > > [/SAMI] > > > > > Ah yes, good point. So using Qemu as a prefix is slightly problematic. > > > > My intent is for this driver to be optimized towards NOR flash > > emulation the way QEMU implements it. The main difference between the > > platforms is that some of them (notably, ArmVirtQemu.dsc) also execute > > from the emulated region, which requires an executable (read-only) > > memslot in KVM, as instruction fetches (as opposed to explicit loads > > and stores) cannot be emulated by KVM. KvmTool only uses the NOR flash > > for variables, so it doesn't really care how the emulation is > > implemented, as long as the loads and stores are carried out in the > > expected way. > > > > I don't think the Ovmf prefix makes sense here either - OVMF is still > > primarily x86, which uses a different flash emulation altogether. > > Maybe VirtNorFlashDxe, to emphasize that it does not expect to be > > dealing with actual NOR flash? > > VirtNorFlashDxe sounds good to me. Sounds good to me too. / Leif