From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mx.groups.io with SMTP id smtpd.web12.7299.1666183230279880651 for ; Wed, 19 Oct 2022 05:40:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=ZAwr3Wn8; spf=pass (domain: ventanamicro.com, ip: 209.85.214.182, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pl1-f182.google.com with SMTP id n7so17142564plp.1 for ; Wed, 19 Oct 2022 05:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Jr+hLWnsO4twpaqzCY6sL2fSGsA0vJtyXrkIam0vplE=; b=ZAwr3Wn8EN18L0xSdWiAn9Qj9pevLnBpil8upjfFB7iqFMkKdTfIm6bIy02Q7tvU29 em9AU3F7FZy7NYhd++DX44HPu+VFsHJ3XYbxMjJkgGrU9T8EX7zwS5DN1oggYVzBwqSN G+Pc6Bf2hWxh+xLv1A9AD3htHg+qsDv03g9CLzrcqTe0L9f4tS3tXC+MmQO+a/edHN4j 4M1Rio5qeoHn5pr60VQu32R1z4wdj+ccDkeK4XL68qgbMHTKt/FUmKNjO/szwAANUvDZ DDf27ZKN4QecnDVFyHlIBEYGV4EMJtr215irP1xWPQXzziKk/qVj4Or1Pra/3nggPgIa zgAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Jr+hLWnsO4twpaqzCY6sL2fSGsA0vJtyXrkIam0vplE=; b=l9OsaJr8HhOTUOdoeVunUMGnH3F/qB6lxbo5PLdnjXJIQpZvDScpjEPlZJblLd+yCo pnNz2zW3xS2NYWpAWH40yzXhw2X7A9rXyFGYOoYLezltnmDApHXo3fO8wMspo/nK5ks3 JaBd8Bjnqf7W9xIbS1p5Xu7d9bKiogHxmFbfVlLqEBj3/8SCgkXyeg8ny7yAP/QqHtPk Pn8hzg3SdfBR3OIcCGShM/1LB19d3pVFTgumV0J2warxDjlSstxfjU64w3PC4f9jZJNg LBqTgqvvZj6/KjlbhsQgpnNLjNwGCFd72W8MlF95Hy3jS4TWVj3bA4gjsF68RzKqHjMt fKXA== X-Gm-Message-State: ACrzQf3Co2CnHAlFhSr181tIFA4TcqbOzO6KZKu9aBqCoUd1Z16fSi6V xcBfnoIrYm3yLF70pc1iSi+qug== X-Google-Smtp-Source: AMsMyM7uOODVhGZHSETyEkEoiYLqern7+CUkGV7wtfXWgZ7Lqobw0RNW2h/yfb/fThi+9f8fBJba7g== X-Received: by 2002:a17:90b:4d8c:b0:20d:2935:7058 with SMTP id oj12-20020a17090b4d8c00b0020d29357058mr44895964pjb.86.1666183229702; Wed, 19 Oct 2022 05:40:29 -0700 (PDT) Return-Path: Received: from sunil-laptop ([49.206.13.138]) by smtp.gmail.com with ESMTPSA id y26-20020aa79afa000000b00538056de6ecsm11377912pfp.52.2022.10.19.05.40.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 05:40:29 -0700 (PDT) Date: Wed, 19 Oct 2022 18:10:22 +0530 From: "Sunil V L" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Daniel Schaefer Subject: Re: [edk2-staging/RiscV64QemuVirt PATCH 25/29] OvmfPkg: Add NorFlashQemuLib library Message-ID: References: <20221010101202.1146624-1-sunilvl@ventanamicro.com> <20221010101202.1146624-26-sunilvl@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 19, 2022 at 02:19:28PM +0200, Ard Biesheuvel wrote: > On Mon, 10 Oct 2022 at 12:13, Sunil V L wrote: > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 > > > > This is copied from ArmVirtPkg since it is required for > > other architectures also. > > > > It also adds the instance for single flash drive which has > > both code and variables. This is copied from SbsaQemu. > > > > Cc: Ard Biesheuvel > > Cc: Jiewen Yao > > Cc: Jordan Justen > > Cc: Gerd Hoffmann > > Cc: Daniel Schaefer > > Signed-off-by: Sunil V L > > Let's call these > > QemuNorFlashPlatformLib [for the library class] > > QemuNorFlashDeviceTreeLib > QemuNorFlashStaticLib > > and for the driver > > QemuNorFlashDxe Sure. I will make these changes when I send next version. > > > i sent out some patches for edk2-platforms to eliminate the dependency > on ArmPlatformPkg's NorFlashDxe and NorFlashPlatformLib definitions. > Once we move everything in OvmfPkg over to these ones, we can drop the > old one altogether. Sure. Thanks! Sunil