From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by mx.groups.io with SMTP id smtpd.web12.7310.1666183319566918294 for ; Wed, 19 Oct 2022 05:41:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=GmP4VIMr; spf=pass (domain: ventanamicro.com, ip: 209.85.217.42, mailfrom: sunilvl@ventanamicro.com) Received: by mail-vs1-f42.google.com with SMTP id 3so17557921vsh.5 for ; Wed, 19 Oct 2022 05:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=57J0unH0eg6pVjRm11MZbqIafAI1GK4cVvI3eRbHjUM=; b=GmP4VIMrslNgZlMB4RFjKWVoSaYn/tlds7OGnRlfnfZYVt7qArJ1+6hYSqoBZ2dOWR 5MAMBGIE3KGnWQe0AVsVpPRMH0fqmZ+DY7KcpEJRikE2sOIwvj74dFgbf5W7K1lEwYCw PgUm2oIWV+NjUiLBCyjN467dvYwZQHqmwAl3ppvCJDTR35mLsMg+oJAvXtZ/shkn2mwK eB2bvkbYBs6IscXcGBOfmhsQTT7YtseiI6mKdbWHvz1Lr9X8mnUaOkanLQULAmBIuaVw H/GES3V5mRiBtneLEc6fNHyJ+MKRCcUsZNF+adLg70rGyr7hJw78SE6QPwox2CLry2lN LekA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=57J0unH0eg6pVjRm11MZbqIafAI1GK4cVvI3eRbHjUM=; b=X5XqpG6w6QYm/QtBn9otzWiphnrzO62JilJnpjw80ay3fGFtAkCCrsHSeLbCBhrZmk 1zNmmgVg6DsLnKX9+Fv7W+3BOkuAMiHt4o2Or2PAE6lnVPyfF45vANnLJSD2SZMiVGvg Doiw6RYAcTYF2qYwQmOZRYfBJSTJRgwwEf5tRVBLoFTvzHTbtCuvWnn4K6/sEzgyPvr8 trJudTE+c19xuWFp6Pjn6DpC/6IAEh4rxeZjySP7hNdVXvsh1I3+cYc5zHn0GyzsYbt4 SN3aeJgLxdQagSMiCcf6G7x6MoPcOqprcKB1EAcC/L7yqxxJ7xBAhSsNx8zkffuw6iSf eF2w== X-Gm-Message-State: ACrzQf1GutAAYjOk1uLJWmNCvPmZPL7KXNSw4OPuwXQBVwOoifakfpe1 WRo38jpa2kM/MxOjS++Il+DYyJwinkgnRA== X-Google-Smtp-Source: AMsMyM7ebdJr7rSRJjCLLILJU5Izg/qbqYoSKUw09BHnN42oFJOkxjGnJRZo+641f7ElCGvqgBAcAQ== X-Received: by 2002:aa7:8504:0:b0:563:1ae2:6dc0 with SMTP id v4-20020aa78504000000b005631ae26dc0mr8470492pfn.48.1666183307968; Wed, 19 Oct 2022 05:41:47 -0700 (PDT) Return-Path: Received: from sunil-laptop ([49.206.13.138]) by smtp.gmail.com with ESMTPSA id b14-20020a170903228e00b00176e8f85147sm10847518plh.83.2022.10.19.05.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 05:41:47 -0700 (PDT) Date: Wed, 19 Oct 2022 18:11:41 +0530 From: "Sunil V L" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann Subject: Re: [edk2-staging/RiscV64QemuVirt PATCH V4 29/34] OvmfPkg: Add Qemu NOR flash DXE driver Message-ID: References: <20221014164836.1513036-1-sunilvl@ventanamicro.com> <20221014164836.1513036-30-sunilvl@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 19, 2022 at 11:00:30AM +0200, Ard Biesheuvel wrote: > On Fri, 14 Oct 2022 at 18:50, Sunil V L wrote: > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 > > > > RISC-V needs NorFlashDxe driver for qemu virt machine. The > > ArmPlatformPkg has this driver but migrating it to generic > > package like MdeModulePkg introduces circular dependencies. > > So, add NorFlashDxe driver in OvmfPkg which is mostly the > > copy of the driver in ArmPlatformPkg except the support > > for PcdNorFlashCheckBlockLocked feature. This approach also > > allows to optimize the driver for virtual platforms. > > > > Cc: Ard Biesheuvel > > Cc: Jiewen Yao > > Cc: Jordan Justen > > Cc: Gerd Hoffmann > > Signed-off-by: Sunil V L > > --- > > OvmfPkg/Drivers/NorFlashDxe/NorFlashDxe.inf | 67 ++ > > OvmfPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf | 61 ++ > > I don't think we need the StandaloneMm variant here Sure. Will remove it in the next version. Thanks Sunil