From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mx.groups.io with SMTP id smtpd.web09.6879.1666100035771538207 for ; Tue, 18 Oct 2022 06:33:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=E3dtzWcL; spf=pass (domain: ventanamicro.com, ip: 209.85.216.45, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pj1-f45.google.com with SMTP id n18-20020a17090ade9200b0020b0012097cso1715748pjv.0 for ; Tue, 18 Oct 2022 06:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O4we69U5V8suMvmQhvDkT32b1RbbWlzqcTqFQFmIYN0=; b=E3dtzWcLxOSFaLPCRpLKMDkLOMxQYcKgfGaeqW5gMkeJifJSgYEAKT4JOBXCf8v6m6 W10Ao2x3DUAqkYxUuXl56PjmS3Z9j17sl9xHqA0nBfYVhtyRZsn4VkJJpSNka0suDCj2 W6mvVlX5qauAUX/4/VKuNJAuxu/nFUk1NqBux1q86ikvQiMuNhDY4INh9Rtuo4KmWVMy kJlzciFZsSXZZPKcdmjC3aYJHGhKjtWCZTkHk7vV69Zpk98fsIbewUvTqt9ji5eJbvUG RPC9XFkT3a6DEpWNkE+ye+ucby/ZdacZX/aMt9waBFCy4fXjRJJjQdq94sutMwzLHPVQ sSrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O4we69U5V8suMvmQhvDkT32b1RbbWlzqcTqFQFmIYN0=; b=ORNwfVedUYnAOmtO3UvNNrd3R04DKqFsJhjFSmfqgUHRxBOAWSNr75NQjSFoG998o5 7oMC+7losNKEt9HJYWUzWbstrlp8d2fskL048F/e82HtaK64C+JKC9wpd7Oz9yPaJDeo P07OWgNctYOJKt6VAtpDIa0dFVOSUSEYcd3QYJ2yK+HfCwPOjdqZnIC1gSNjNHw0e61H 7cGpzrX8+zKJNanHvxL1B0oyVaB1UY6ntiy0nqD6NNPMJ180S4GJjoROd52gQ3dgzBMm S6ZC+8uDFQrRIlnpqqK7EWnde6Xu5olZH9SVwwX4lijAruW8Yt12H2Ax4h4K67tct0ju riMQ== X-Gm-Message-State: ACrzQf0I11XxSDsoIHFMD37H6qPpd/Kn6C9o3MwpkTBiYg9bRHcqdBUk tBAGKCWUfTH8gqfFRRO6n6XOjw== X-Google-Smtp-Source: AMsMyM6m2ns0LKYCQeKaGABIngLB82mxUljcThDaVh9WMFZzESFqhOi4jiuZoNL2SUNycw8ZBnW8ow== X-Received: by 2002:a17:902:d2d2:b0:182:a32f:5ba1 with SMTP id n18-20020a170902d2d200b00182a32f5ba1mr3067008plc.88.1666100035124; Tue, 18 Oct 2022 06:33:55 -0700 (PDT) Return-Path: Received: from sunil-laptop ([49.206.13.138]) by smtp.gmail.com with ESMTPSA id u16-20020a17090341d000b00185480a85f1sm6741440ple.285.2022.10.18.06.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Oct 2022 06:33:54 -0700 (PDT) Date: Tue, 18 Oct 2022 19:03:48 +0530 From: "Sunil V L" To: abner.chang@amd.com Cc: devel@edk2.groups.io, Ray Ni , Michael D Kinney , Abdul Lateef Attar , Leif Lindholm Subject: Re: [tianocore-docs][PATCH V2 2/2] edk II C Coding Standard: Updates 4.2 and 4.3 sections Message-ID: References: <20221015114757.383-1-abner.chang@amd.com> MIME-Version: 1.0 In-Reply-To: <20221015114757.383-1-abner.chang@amd.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Abner, Just few minor comments below. Otherwise, Acked-by: Sunil V L On Sat, Oct 15, 2022 at 07:47:57PM +0800, abner.chang@amd.com wrote: > From: Abner Chang > > Updates 4.2 Directory names and 4.3 file names for > the guidelines of module directory and file naming. > > PR: https://github.com/tianocore-docs/edk2-CCodingStandardsSpecification/pull/2/files > > Signed-off-by: Abner Chang > Cc: Ray Ni > Cc: Michael D Kinney > Cc: Sunil V L > Cc: Abdul Lateef Attar > Cc: Leif Lindholm > --- > 4_naming_conventions/42_directory_names.md | 101 +++++++++++++++++++ > 4_naming_conventions/43_file_names.md | 108 ++++++++++++++++++++- > 2 files changed, 208 insertions(+), 1 deletion(-) > > diff --git a/4_naming_conventions/42_directory_names.md b/4_naming_conventions/42_directory_names.md > index 766ccb1..959a3c9 100644 > --- a/4_naming_conventions/42_directory_names.md > +++ b/4_naming_conventions/42_directory_names.md > @@ -2,6 +2,7 @@ > 4.2 Directory Names > > Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
> + Copyright (c) 2022, Intel Corporation. All rights reserved.
> > Redistribution and use in source (original document form) and 'compiled' > forms (converted to PDF, epub, HTML and other formats) with or without > @@ -28,3 +29,103 @@ > ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > --> > + > +## 4.2 Directory Names > +Below sections are the directory naming guidelines for EDK II modules. The guidelines are not > +just considering the the uniformity of directory naming, but it also provides the flexibility of ^ An extra "the". "it also provides" -> "they also provide" ? > +directory name construction for the scenario of different EDK II module designs; such as the > +support for multiple processor architectures and vendors. It may require the further discussions "the further" -> further > +between EDK II maintainers and contributors in order to determine the best naming of the EDK II ^ remove "in order" ? > +module directory. > + > +#### 4.2.1 EDKII package directory > + > +``` > +Pkg > + > + REQUIRED * > +``` > + > +#### 4.2.2 EDKII Module directory > + > +* The guideline below is applied to all CPU architectures support, specific CPU architecture and vendors support, or the implementation is shared by certain CPU archs: Better to use architectures instead of "archs" ? Thanks Sunil