From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mx.groups.io with SMTP id smtpd.web10.413.1665678565318804779 for ; Thu, 13 Oct 2022 09:29:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=lheV7lAp; spf=pass (domain: ventanamicro.com, ip: 209.85.214.171, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pl1-f171.google.com with SMTP id l1so2241311pld.13 for ; Thu, 13 Oct 2022 09:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LwdBn6mWv0buQzR96IzNTPiYF9OfOAel5r8sYHIJljw=; b=lheV7lApGkiD7YMBUiBMF8G3eYBiQFO4Y47IVAczZ3kLBBOcVbg/l60oei7wgZwMQ3 uotAuR8XjrJpqZNvyU74uVywinBpkPplu5SHDKLQc1EIugFJg0RxrfVxS4GLaQNYNkCH 4mHsgMn42eQpWX4j6XL6HPa6V1pAGICybKVrrqDjXyJ4mc+y/sD2bo18w5UZehBVi/Iv VbD8uz8ELkLqzu8DgdNhFl12WTeOU9rUgff0bPbEXWy9uxqeMPs7e2aPDNIYaLMLs3qI 0mpjOq9e66kEjA/jFM6+J+CkxmlZ6gEAUEc3deKDEs4EZNa+uGAQQxx0zWP1bQY3qnHh JTiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LwdBn6mWv0buQzR96IzNTPiYF9OfOAel5r8sYHIJljw=; b=zuoD29BxN9xMi1bSJwfMq7Z1uRHaZw+9sTSM2Jhh1yEnyUjllSDzUK4lMqatfb1SHl hbZ/VUEwP/IApZqy0R8mik5TLUq2WFDnPShuUY7vUcQ1ZgrZChJWh+M3Nu8qlrecZezJ qS9U28yBJW4WbILP7K/zKLl4ywIqYJpEQmLK0ajTwqjjmDyo6wN+JhZilY0UjC01IPOH +TtyPdlA9lfZOfp1pFB0jmcV2JMg1Tj+5QHDrOMtZ0qb+NSzbXR47PeCBWpLOJIP6Jnf 4lpcUAfYYNB565T5l9+ktBwq7ps8ImWagDIEbUrAnfJvtyOFZKKbadsNWKHJu22W2ytj F7xg== X-Gm-Message-State: ACrzQf177qFlSUuVF6Q257Lm2K1289NbMKfk2mwpEFsoZRB7ta79ZZ4z tCw0aKoc9Z6rM12raG2wffjUjA== X-Google-Smtp-Source: AMsMyM7kkdLt9gZMV2Ln977yh2FRlJLHZEJvQGlYxtsuf8GZC7KSrflNIdLLvWVAhmNFSywCsvERHQ== X-Received: by 2002:a17:903:2591:b0:17f:8b74:f3c0 with SMTP id jb17-20020a170903259100b0017f8b74f3c0mr748642plb.36.1665678564301; Thu, 13 Oct 2022 09:29:24 -0700 (PDT) Return-Path: Received: from sunil-laptop ([49.206.13.138]) by smtp.gmail.com with ESMTPSA id t15-20020aa7946f000000b00560af825c13sm2290535pfq.91.2022.10.13.09.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Oct 2022 09:29:23 -0700 (PDT) Date: Thu, 13 Oct 2022 21:59:17 +0530 From: "Sunil V L" To: "Chang, Abner" Cc: "devel@edk2.groups.io" , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V3 02/34] MdePkg: Add RISCV_EFI_BOOT_PROTOCOL related definitions Message-ID: References: <20221013095829.1454581-1-sunilvl@ventanamicro.com> <20221013095829.1454581-3-sunilvl@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 13, 2022 at 12:40:14PM +0000, Chang, Abner wrote: > [AMD Official Use Only - General] > > > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Sunil V L via > > groups.io > > Sent: Thursday, October 13, 2022 5:58 PM > > To: devel@edk2.groups.io > > Cc: Michael D Kinney ; Liming Gao > > ; Zhiguang Liu > > Subject: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V3 02/34] MdePkg: > > Add RISCV_EFI_BOOT_PROTOCOL related definitions > > > > Caution: This message originated from an External Source. Use proper caution > > when opening attachments, clicking links, or responding. > > > > > > REF: > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla. > > tianocore.org%2Fshow_bug.cgi%3Fid%3D4076&data=05%7C01%7Cabner. > > chang%40amd.com%7C0df18d1274f04083208208daad018bc2%7C3dd8961fe48 > > 84e608e11a82d994e183d%7C0%7C0%7C638012519406523318%7CUnknown% > > 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2Bynu9ig0EeeuMDr5V0F > > ON3iY1p4nrTdb77O0j8SGkxs%3D&reserved=0 > > > > RISC-V UEFI based platforms need to support RISCV_EFI_BOOT_PROTOCOL. > > Add this protocol GUID definition and the header file required. > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Signed-off-by: Sunil V L > > --- > > MdePkg/MdePkg.dec | 6 ++++ > > MdePkg/Include/Protocol/RiscVBootProtocol.h | 32 +++++++++++++++++++++ > > 2 files changed, 38 insertions(+) > > create mode 100644 MdePkg/Include/Protocol/RiscVBootProtocol.h > > > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > > f1ebf9e251c1..8f1bcfdc3e97 100644 > > --- a/MdePkg/MdePkg.dec > > +++ b/MdePkg/MdePkg.dec > > @@ -1915,6 +1915,12 @@ [Protocols] > > ## Include/Protocol/ShellDynamicCommand.h > > gEfiShellDynamicCommandProtocolGuid = { 0x3c7200e9, 0x005f, 0x4ea4, > > {0x87, 0xde, 0xa3, 0xdf, 0xac, 0x8a, 0x27, 0xc3 }} > > > > + # > > + # Protocols defined for RISC-V systems # ## > > + Include/Protocol/RiscVBootProtocol.h > > + gRiscVEfiBootProtocolGuid = { 0xccd15fec, 0x6f73, 0x4eec, { 0x83, > > + 0x95, 0x3e, 0x69, 0xe4, 0xb9, 0x40, 0xbf }} > > + > > # > > # [Error.gEfiMdePkgTokenSpaceGuid] > > # 0x80000001 | Invalid value provided. > > diff --git a/MdePkg/Include/Protocol/RiscVBootProtocol.h > > b/MdePkg/Include/Protocol/RiscVBootProtocol.h > > new file mode 100644 > > index 000000000000..cb94f61cd46c > > --- /dev/null > > +++ b/MdePkg/Include/Protocol/RiscVBootProtocol.h > > @@ -0,0 +1,32 @@ > > +/** @file > > + RISC-V Boot Protocol mandatory for RISC-V UEFI platforms. > > + > > + Specification available at > > + > I found here are some whitespaces in the patch. You can check it again. > And I can't apply this patch on edk2 master. Is your edk2-staging branch rebase to edk2 master? Thanks Abner. Please use git am with --quoted-cr=nowarn and --keep-cr arguments. https://www.mail-archive.com/devel@edk2.groups.io/msg47612.html Thanks Sunil