From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39])
 by mx.groups.io with SMTP id smtpd.web08.7457.1666256331630416331
 for <devel@edk2.groups.io>;
 Thu, 20 Oct 2022 01:58:51 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=CloZross;
 spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 199.106.114.39, mailfrom: quic_llindhol@quicinc.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim;
  t=1666256331; x=1697792331;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=P0T0HBGZFO5aeaGxBt+u4zv3bEI6Hm9o2A0ELqjyLyw=;
  b=CloZross5rxUjBgzIpJ9kCgQfE+xNtT8Dw9aywMESEf8aDe+63g2eSRP
   QgMoUo93ir0lGxqOli9tjhaEX5zHwUwWlkHHrpD+L5dZtzpXcXhB1W/+V
   2oszy/zn0mjA2r5T6kZLLeS4eAfWvK8lWWxmP43agE5Z6lDltgRsZHBny
   4=;
Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30])
  by alexa-out-sd-02.qualcomm.com with ESMTP; 20 Oct 2022 01:58:51 -0700
X-QCInternal: smtphost
Received: from nasanex01c.na.qualcomm.com ([10.45.79.139])
  by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2022 01:58:51 -0700
Received: from qc-i7.hemma.eciton.net (10.80.80.8) by
 nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.2.986.29; Thu, 20 Oct 2022 01:58:49 -0700
Date: Thu, 20 Oct 2022 09:58:46 +0100
From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: <devel@edk2.groups.io>, <ardb@kernel.org>
CC: Alexander Graf <agraf@csgraf.de>, Gerd Hoffmann <kraxel@redhat.com>, Sami
 Mujawar <Sami.Mujawar@arm.com>
Subject: Re: [edk2-devel] [PATCH v3 resend 01/11] ArmVirtPkg: remove EbcDxe from all platforms
Message-ID: <Y1ENxrqP9BiN9W9E@qc-i7.hemma.eciton.net>
References: <20221019092211.465699-1-ardb@kernel.org>
 <20221019092211.465699-2-ardb@kernel.org>
MIME-Version: 1.0
In-Reply-To: <20221019092211.465699-2-ardb@kernel.org>
Return-Path: quic_llindhol@quicinc.com
X-Originating-IP: [10.80.80.8]
X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To
 nasanex01c.na.qualcomm.com (10.45.79.139)
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline

On Wed, Oct 19, 2022 at 11:22:01 +0200, Ard Biesheuvel wrote:
> The EBC interpreter is rarely, if ever, used on ARM, and is especially
> pointless on virtual machines. So let's drop it from the builds.
> 
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

> ---
>  ArmVirtPkg/ArmVirt.dsc.inc           | 5 -----
>  ArmVirtPkg/ArmVirtCloudHv.fdf        | 5 -----
>  ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 5 -----
>  ArmVirtPkg/ArmVirtXen.fdf            | 5 -----
>  4 files changed, 20 deletions(-)
> 
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index c39e2506a3ea..34575585adbb 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -422,8 +422,3 @@ [Components.AARCH64]
>      <LibraryClasses>
>        NULL|EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf
>    }
> -
> -  #
> -  # EBC support
> -  #
> -  MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
> diff --git a/ArmVirtPkg/ArmVirtCloudHv.fdf b/ArmVirtPkg/ArmVirtCloudHv.fdf
> index 81c539590a76..a5f172d79bfc 100644
> --- a/ArmVirtPkg/ArmVirtCloudHv.fdf
> +++ b/ArmVirtPkg/ArmVirtCloudHv.fdf
> @@ -195,11 +195,6 @@ [FV.FvMain]
>    INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
>    INF MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
>    INF ArmVirtPkg/CloudHvAcpiPlatformDxe/CloudHvAcpiPlatformDxe.inf
> -
> -  #
> -  # EBC support
> -  #
> -  INF MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
>  !endif
>  
>    #
> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> index d4df6dede0fe..787286133095 100644
> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> @@ -146,11 +146,6 @@ [FV.FvMain]
>    INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
>    INF MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
>    INF OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
> -
> -  #
> -  # EBC support
> -  #
> -  INF MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
>  !endif
>  
>    #
> diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf
> index 132480f03059..770fbf7289be 100644
> --- a/ArmVirtPkg/ArmVirtXen.fdf
> +++ b/ArmVirtPkg/ArmVirtXen.fdf
> @@ -201,11 +201,6 @@ [FV.FvMain]
>  !if $(ARCH) == AARCH64
>    INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
>    INF ArmVirtPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf
> -
> -  #
> -  # EBC support
> -  #
> -  INF MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
>  !endif
>  
>   #
> -- 
> 2.35.1
> 
> 
> 
> 
> 
>