From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: <devel@edk2.groups.io>, Alexander Graf <agraf@csgraf.de>,
Gerd Hoffmann <kraxel@redhat.com>,
Sami Mujawar <Sami.Mujawar@arm.com>
Subject: Re: [PATCH v3 resend 02/11] ArmVirtPkg: do not enable iSCSI driver by default
Date: Thu, 20 Oct 2022 10:03:34 +0100 [thread overview]
Message-ID: <Y1EO5jRsMuqZXPYl@qc-i7.hemma.eciton.net> (raw)
In-Reply-To: <20221019092211.465699-3-ardb@kernel.org>
On Wed, Oct 19, 2022 at 11:22:02 +0200, Ard Biesheuvel wrote:
> The iSCSI driver slows down the boot on a pristine variable store flash
> image, as it creates a couple of large EFI non-volatile variables to
> preserve state between boots.
>
> Since iSCSI boot for VMs is kind of niche anyway, let's default to
> disabled. If someone needs it in their build, they can use the -D build
> command option to re-enable it on the fly.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Apologies for bikeshedding, but ... I find the listing of tweakable
options in a block at the start of a .dsc very useful.
Could we explicitly set to FALSE instead?
Either way:
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com>
> ---
> ArmVirtPkg/ArmVirtQemu.dsc | 1 -
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 9369a88858fd..45c4a8fc84e0 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -40,7 +40,6 @@ [Defines]
> DEFINE NETWORK_SNP_ENABLE = FALSE
> DEFINE NETWORK_TLS_ENABLE = FALSE
> DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE
> - DEFINE NETWORK_ISCSI_ENABLE = TRUE
>
> !if $(NETWORK_SNP_ENABLE) == TRUE
> !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index 7f7d15d6eee3..66039f07f41b 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -38,7 +38,6 @@ [Defines]
> DEFINE NETWORK_SNP_ENABLE = FALSE
> DEFINE NETWORK_TLS_ENABLE = FALSE
> DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE
> - DEFINE NETWORK_ISCSI_ENABLE = TRUE
>
> !if $(NETWORK_SNP_ENABLE) == TRUE
> !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-10-20 9:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 9:22 [PATCH v3 resend 00/11] ArmVirtPkg/ArmVirtQemu: Performance streamlining Ard Biesheuvel
2022-10-19 9:22 ` [PATCH v3 resend 01/11] ArmVirtPkg: remove EbcDxe from all platforms Ard Biesheuvel
2022-10-20 8:58 ` [edk2-devel] " Leif Lindholm
2022-10-19 9:22 ` [PATCH v3 resend 02/11] ArmVirtPkg: do not enable iSCSI driver by default Ard Biesheuvel
2022-10-20 9:03 ` Leif Lindholm [this message]
2022-10-20 12:34 ` Ard Biesheuvel
2022-10-19 9:22 ` [PATCH v3 resend 03/11] ArmVirtPkg: make EFI_LOADER_DATA non-executable Ard Biesheuvel
2022-10-19 9:22 ` [PATCH v3 resend 04/11] ArmVirtPkg/ArmVirtQemu: wire up timeout PCD to Timeout variable Ard Biesheuvel
2022-10-19 9:22 ` [PATCH v3 resend 05/11] ArmVirtPkg/ArmVirtQemu: implement ArmPlatformLib with static ID map Ard Biesheuvel
2022-10-19 9:22 ` [PATCH v3 resend 06/11] ArmVirtPkg/ArmVirtQemu: use first 128 MiB as permanent PEI memory Ard Biesheuvel
2022-10-19 9:22 ` [PATCH v3 resend 07/11] ArmVirtPkg/ArmVirtQemu: enable initial ID map at early boot Ard Biesheuvel
2022-11-08 15:59 ` Gerd Hoffmann
2022-10-19 9:22 ` [PATCH v3 resend 08/11] ArmVirtPkg/ArmVirtQemu: Drop unused variable PEIM Ard Biesheuvel
2022-10-19 9:22 ` [PATCH v3 resend 09/11] ArmVirtPkg/ArmVirtQemu: avoid shadowing PEIMs unless necessary Ard Biesheuvel
2022-10-19 9:22 ` [PATCH v3 resend 10/11] ArmVirtPkg/QemuVirtMemInfoLib: use HOB not PCD to record the memory size Ard Biesheuvel
2022-10-19 9:22 ` [PATCH v3 resend 11/11] ArmVirtPkg/ArmVirtQemu: omit PCD PEIM unless TPM support is enabled Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1EO5jRsMuqZXPYl@qc-i7.hemma.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox