From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.7575.1666256641928563225 for ; Thu, 20 Oct 2022 02:04:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=eCHm2r1r; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29K7tUJW014600; Thu, 20 Oct 2022 09:03:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=7iB8Lp5euIbB92QJCh1tXBY/f+shR0mLHkFSrBQmj6U=; b=eCHm2r1rxxXU1Ipr5kFfX7M5tD5X4Cs2W03DG8ZwScJtmbjJ7Hd0fDFhSILJhUCAKMG4 I69/kuodM3CewSVa5iCxEjBwL5+SplZl0wXK0hNCtUgre4p+b5U6ADE3OImN+f693cvK 8DgjFxRd//iMP/Tjvw1RwnYnT5O6C8jcEoMCUjcX60ImQu7g5ghaJ7FhMQXKxjOfoCdy fYIdv2S1dDj6Xzbhfrk9s9Dyp55A46qmtlKfc3a2P47AtHOZ4oEVQgOfKHFg8El/UQHn p8jvjfoyJpUhsDBF3IubplrJEkFk0HKPNj/sKlnprmwK03lWh8hmMivJOvs6nnsZ3EpA nQ== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3kb2c6053e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Oct 2022 09:03:39 +0000 Received: from pps.filterd (NASANPPMTA03.qualcomm.com [127.0.0.1]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 29K8xUa6001347; Thu, 20 Oct 2022 09:03:38 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NASANPPMTA03.qualcomm.com (PPS) with ESMTPS id 3kaeutgf0u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Oct 2022 09:03:38 +0000 Received: from NASANPPMTA03.qualcomm.com (NASANPPMTA03.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 29K93cv6007186; Thu, 20 Oct 2022 09:03:38 GMT Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (PPS) with ESMTPS id 29K93cx7007182 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Oct 2022 09:03:38 +0000 Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Thu, 20 Oct 2022 02:03:37 -0700 Date: Thu, 20 Oct 2022 10:03:34 +0100 From: "Leif Lindholm" To: Ard Biesheuvel CC: , Alexander Graf , Gerd Hoffmann , Sami Mujawar Subject: Re: [PATCH v3 resend 02/11] ArmVirtPkg: do not enable iSCSI driver by default Message-ID: References: <20221019092211.465699-1-ardb@kernel.org> <20221019092211.465699-3-ardb@kernel.org> MIME-Version: 1.0 In-Reply-To: <20221019092211.465699-3-ardb@kernel.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 57E6UrwB2NOoyn0SsHAm7uSH8jcK86Z3 X-Proofpoint-ORIG-GUID: 57E6UrwB2NOoyn0SsHAm7uSH8jcK86Z3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-20_02,2022-10-19_04,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 clxscore=1015 impostorscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 mlxlogscore=511 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210200053 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Wed, Oct 19, 2022 at 11:22:02 +0200, Ard Biesheuvel wrote: > The iSCSI driver slows down the boot on a pristine variable store flash > image, as it creates a couple of large EFI non-volatile variables to > preserve state between boots. > > Since iSCSI boot for VMs is kind of niche anyway, let's default to > disabled. If someone needs it in their build, they can use the -D build > command option to re-enable it on the fly. > > Signed-off-by: Ard Biesheuvel Apologies for bikeshedding, but ... I find the listing of tweakable options in a block at the start of a .dsc very useful. Could we explicitly set to FALSE instead? Either way: Acked-by: Leif Lindholm > --- > ArmVirtPkg/ArmVirtQemu.dsc | 1 - > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index 9369a88858fd..45c4a8fc84e0 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -40,7 +40,6 @@ [Defines] > DEFINE NETWORK_SNP_ENABLE = FALSE > DEFINE NETWORK_TLS_ENABLE = FALSE > DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE > - DEFINE NETWORK_ISCSI_ENABLE = TRUE > > !if $(NETWORK_SNP_ENABLE) == TRUE > !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only" > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index 7f7d15d6eee3..66039f07f41b 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -38,7 +38,6 @@ [Defines] > DEFINE NETWORK_SNP_ENABLE = FALSE > DEFINE NETWORK_TLS_ENABLE = FALSE > DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE > - DEFINE NETWORK_ISCSI_ENABLE = TRUE > > !if $(NETWORK_SNP_ENABLE) == TRUE > !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only" > -- > 2.35.1 >