From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mx.groups.io with SMTP id smtpd.web12.3098.1666846067508126064 for ; Wed, 26 Oct 2022 21:47:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=OsPduZKq; spf=pass (domain: ventanamicro.com, ip: 209.85.210.181, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pf1-f181.google.com with SMTP id m6so413673pfb.0 for ; Wed, 26 Oct 2022 21:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=B7YOzpiXeCfiVbwTWnw7ujwQwx4Ho7/gTSh+oqGyzyA=; b=OsPduZKqVcg9r8b873esHGIgKPw2As+9SUDep0hLD5Q8a00HIyzwUbvs+MLub4tMEC KO00l40Dx03+jNWO3MBZBBsyyMgdTEfLC9CUKBQ2YJoaqbQFv2Qk1Mw61whqaSCx7Hhn K1DlUCusgHB6ibypRDVn1Q95r/nh1SVAuUBzkR18KZmrRqolfCcFP8olgU6DqN1PqG6x 26Gm1Exz1rrLAxoI2qXAuX8rfrfqcngBYcmLQWhDKu8Smnb70G4vhH6tqlAcukLoO8Fk bF6x7IemZa3dxkTgy5x/x7sqQ/v/gDVzXzfIFJreVoUpbeZpdrG9fqAlsue1L3P+szdd NKNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B7YOzpiXeCfiVbwTWnw7ujwQwx4Ho7/gTSh+oqGyzyA=; b=4bo5nlcw2DLhy1eyZS2JnrpWWw+zvzt41/+LVD3NgoPB/5kHl8oyishUFT0iTbtV9O +h2cNIqmCcvl7xnzd01D7odQnykLM2hQcm6WPjMc4yXYPnb6WSPk8S6OgtiY0qIYnyZu mSm3tpvzzAB4Qgiq5Y0QSL9Lv5Qg+PP1ahOJFLScsjuASXIWqvDiKew+fFFsqHIPs+dr LoqcZXn6cc4WnqKTceoAW1tIpPUOamGJRf7gLeDJlbEVcUVGJziRh/PFLLYhnhc+0MwW GzRoASlfj15nMjqI+HHK3WIqaJVBV/5usRrMKDmIkpXqpnKzf9DJkUo72/k8OTvvouCc 6gUg== X-Gm-Message-State: ACrzQf0j7EOr9Ho8Oiuf/J8MIH24m16EFkWB5c0jnG/rbp+y18Eho+8m qgeBF4Jz66Pr3nJuZi9jDomCYQ== X-Google-Smtp-Source: AMsMyM6jQWkm5ASBP2HlTgP+gdSwQUcjfazwhWeD7krzmE/hwiR8PGc9Py9cH4kvaL8tc1+HSej1eg== X-Received: by 2002:a63:6905:0:b0:43c:d4:eef4 with SMTP id e5-20020a636905000000b0043c00d4eef4mr39530362pgc.126.1666846067025; Wed, 26 Oct 2022 21:47:47 -0700 (PDT) Return-Path: Received: from sunil-laptop ([2409:4071:248a:a502:e897:f319:3c10:6e76]) by smtp.gmail.com with ESMTPSA id y4-20020a17090a390400b00212735c8898sm1860277pjb.30.2022.10.26.21.47.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 21:47:45 -0700 (PDT) Date: Thu, 27 Oct 2022 10:17:37 +0530 From: "Sunil V L" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Gerd Hoffmann , Sami Mujawar , Leif Lindholm Subject: Re: [PATCH 00/11] ArmVirtPkg: introduce VirtNorFlashDxe Message-ID: References: <20221024170122.594577-1-ardb@kernel.org> MIME-Version: 1.0 In-Reply-To: <20221024170122.594577-1-ardb@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 24, 2022 at 07:01:11PM +0200, Ard Biesheuvel wrote: > Create a new driver VirtNorFlashDxe that targets QEMU and KvmTool's NOR > flash emulation specifically, and retire the ArmPlatformPkg one. > > This permits new virt implementations to wire up QEMU's NOR flash > emulation without having to rely on ARM specific packages. It also > permits us to implement some tweaks to work around some rough > performance edges of KVM memslot backed NOR flash. > Thank you very much!. Looks good to me. May be you want to fix the include gaurd in NorFlash.h and VirtNorFlashPlatformLib.h as per the coding standards. Reviewed-by: Sunil V L