From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mx.groups.io with SMTP id smtpd.web11.32679.1670283385362490317 for ; Mon, 05 Dec 2022 15:36:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@canonical.com header.s=20210705 header.b=Zj4sf2Wv; spf=pass (domain: canonical.com, ip: 185.125.188.122, mailfrom: dann.frazier@canonical.com) Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 4DB4142259 for ; Mon, 5 Dec 2022 23:36:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1670283383; bh=/B9+HvVGLibLzhddJ7vsum9a+zsg8h6iu1cTMoc41vo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=Zj4sf2WvlNDYVUHJASzHe0zwHQT0v1YSNh2J1gXdJRs1zUbAS5qH5qjkJkYrQJawv GgZ9UctXB9TtgeIFvIGboVBk09q+gcSXLbCk7pdj7SS1+QTZxYVeHD9LxO1/slb44I VYmy1zjavhpQ85rZJObwMkNVzLvqj9SzInPdqNKrKYH6SxKjl6qMpVDZFcXsZvmhBB reRJREYuNHRw7LDIVaiOXQnmeQEOPvNbq7aGsRpkUWmKt2alOxNCIG88JKTGrkhrbo EdlDjnWP/9JZLIngSrLWRZ5GJvEgJ5/zrh8xu6J98z8QcFX56PWDwY/w2PO2IlIFyW RMrboKcAnU7rQ== Received: by mail-il1-f197.google.com with SMTP id a14-20020a921a0e000000b00302a8ffa8e5so13096954ila.2 for ; Mon, 05 Dec 2022 15:36:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/B9+HvVGLibLzhddJ7vsum9a+zsg8h6iu1cTMoc41vo=; b=rVsHcwy1n9iydFc5hSEmszDe5ZDP5B4ADgkeV2zE/5qb3YykZa/8uhRDCkcPEQWuZ6 Xi1/ksGgV3eVmaRyp77wcI4fGV25FSVfNbDaJlHQrXnu5d7ovkiVwG1M5kNLcAodWQzN IVdWGSoqDGtlPG6eO8ZOeZtygDMwJSmVoK0ueaFb3Pny9o3PrbDMaaaPlZZeKuoM8qph P5W10exdDYE8OBD/WWmulUXgYh37e8E6+A5GzyaJA02aq1nXgqxeFwklISElXvwDqhtZ IUyn6t53g2CrHQFliS4sQ/Wlo1y1R8l+J6u0j/7ILI+Thc1cUJnUfzDpcO9tsSC1AYo2 o6Kg== X-Gm-Message-State: ANoB5pmK88aiXbmLL8tUrI9YjqR77lccsNgMRNT5gwjVpdyznZkD4Xzr oISx3DQ75bP6Pl6Mtd00z5Hsja+J5yABcS1lblzLlDFdEdDQAjqXHZ2niwy3Hg1UeM9axWlsFWu UDaAEqU14c0wL+dfOtc5WPxfxsfxAMnw= X-Received: by 2002:a92:ad0c:0:b0:302:e073:6149 with SMTP id w12-20020a92ad0c000000b00302e0736149mr26913757ilh.241.1670283381469; Mon, 05 Dec 2022 15:36:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf65IMs9LRP3YMhgejgFV3BLOhlDAEjsRQXQ/6Yfx1c9fvmh33cO85S4GZKieTEjSXh0/cFang== X-Received: by 2002:a92:ad0c:0:b0:302:e073:6149 with SMTP id w12-20020a92ad0c000000b00302e0736149mr26913744ilh.241.1670283381187; Mon, 05 Dec 2022 15:36:21 -0800 (PST) Received: from xps13.dannf ([38.15.56.166]) by smtp.gmail.com with ESMTPSA id p13-20020a02b00d000000b00375664a365esm6172235jah.1.2022.12.05.15.36.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 15:36:19 -0800 (PST) Date: Mon, 5 Dec 2022 16:36:15 -0700 From: "dann frazier" To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Sebastien Boeuf , Brijesh Singh , Erdem Aktas , James Bottomley , Min Xu , Tom Lendacky Subject: Re: [edk2-devel] [Patch 1/2] OvmfPkg: Change default to disable MptScsi and PvScsi Message-ID: References: <20220726194640.1920-1-michael.d.kinney@intel.com> <20220726194640.1920-2-michael.d.kinney@intel.com> MIME-Version: 1.0 In-Reply-To: <20220726194640.1920-2-michael.d.kinney@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 26, 2022 at 12:46:39PM -0700, Michael D Kinney wrote: > The email addresses for the reviewers of the MptScsi and > PvScsi are no longer valid. Disable the MptScsi and PvScsi > drivers in all DSC files until new maintainers/reviewers can > be identified. Hi Michael, This seems likely to be the reason for the following regression report in Debian: https://bugs.debian.org/1016359 I'm trying to decide whether or not this is something we should force back on for our users to avoid the regression, and/or if we need to actively move users off of it (mark it deprecated, etc). Do you know if there are known issues with this code, other than the lack of reviewers? Is there a plan to remove this code at some point? -dann > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Sebastien Boeuf > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Min Xu > Cc: Tom Lendacky > Signed-off-by: Michael D Kinney > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 4 ++-- > OvmfPkg/CloudHv/CloudHvX64.dsc | 4 ++-- > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 4 ++-- > OvmfPkg/Microvm/MicrovmX64.dsc | 4 ++-- > OvmfPkg/OvmfPkgIa32.dsc | 4 ++-- > OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++-- > OvmfPkg/OvmfPkgX64.dsc | 4 ++-- > 7 files changed, 14 insertions(+), 14 deletions(-) > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc > index 726521c94381..90e8a213ef77 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > @@ -43,8 +43,8 @@ [Defines] > # > # Device drivers > # > - DEFINE PVSCSI_ENABLE = TRUE > - DEFINE MPT_SCSI_ENABLE = TRUE > + DEFINE PVSCSI_ENABLE = FALSE > + DEFINE MPT_SCSI_ENABLE = FALSE > DEFINE LSI_SCSI_ENABLE = FALSE > > # > diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc b/OvmfPkg/CloudHv/CloudHvX64.dsc > index 0bfe542f8a88..f0d700f14477 100644 > --- a/OvmfPkg/CloudHv/CloudHvX64.dsc > +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc > @@ -49,8 +49,8 @@ [Defines] > # > # Device drivers > # > - DEFINE PVSCSI_ENABLE = TRUE > - DEFINE MPT_SCSI_ENABLE = TRUE > + DEFINE PVSCSI_ENABLE = FALSE > + DEFINE MPT_SCSI_ENABLE = FALSE > DEFINE LSI_SCSI_ENABLE = FALSE > > # > diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc b/OvmfPkg/IntelTdx/IntelTdxX64.dsc > index 144d50aa9dba..71b1cf8e7090 100644 > --- a/OvmfPkg/IntelTdx/IntelTdxX64.dsc > +++ b/OvmfPkg/IntelTdx/IntelTdxX64.dsc > @@ -34,8 +34,8 @@ [Defines] > # > # Device drivers > # > - DEFINE PVSCSI_ENABLE = TRUE > - DEFINE MPT_SCSI_ENABLE = TRUE > + DEFINE PVSCSI_ENABLE = FALSE > + DEFINE MPT_SCSI_ENABLE = FALSE > DEFINE LSI_SCSI_ENABLE = FALSE > > # > diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc > index 61db9b6e4c83..52498bbe90a8 100644 > --- a/OvmfPkg/Microvm/MicrovmX64.dsc > +++ b/OvmfPkg/Microvm/MicrovmX64.dsc > @@ -47,8 +47,8 @@ [Defines] > # > # Device drivers > # > - DEFINE PVSCSI_ENABLE = TRUE > - DEFINE MPT_SCSI_ENABLE = TRUE > + DEFINE PVSCSI_ENABLE = FALSE > + DEFINE MPT_SCSI_ENABLE = FALSE > DEFINE LSI_SCSI_ENABLE = FALSE > > # > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index e708411076ca..725a01ae9a20 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -50,8 +50,8 @@ [Defines] > # > # Device drivers > # > - DEFINE PVSCSI_ENABLE = TRUE > - DEFINE MPT_SCSI_ENABLE = TRUE > + DEFINE PVSCSI_ENABLE = FALSE > + DEFINE MPT_SCSI_ENABLE = FALSE > DEFINE LSI_SCSI_ENABLE = FALSE > > # > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 0b036d8bb53f..adc813ba2e1e 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -49,8 +49,8 @@ [Defines] > # > # Device drivers > # > - DEFINE PVSCSI_ENABLE = TRUE > - DEFINE MPT_SCSI_ENABLE = TRUE > + DEFINE PVSCSI_ENABLE = FALSE > + DEFINE MPT_SCSI_ENABLE = FALSE > DEFINE LSI_SCSI_ENABLE = FALSE > > # > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 8ad04b50f74f..6e68f60dc90f 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -49,8 +49,8 @@ [Defines] > # > # Device drivers > # > - DEFINE PVSCSI_ENABLE = TRUE > - DEFINE MPT_SCSI_ENABLE = TRUE > + DEFINE PVSCSI_ENABLE = FALSE > + DEFINE MPT_SCSI_ENABLE = FALSE > DEFINE LSI_SCSI_ENABLE = FALSE > > #