From: "dann frazier" <dann.frazier@canonical.com>
To: devel@edk2.groups.io
Subject: feature flag change notifications
Date: Mon, 5 Dec 2022 17:09:55 -0700 [thread overview]
Message-ID: <Y46IU4y65fjAIG1y@xps13.dannf> (raw)
Hi,
I maintain the edk2 packages in the Debian and Ubuntu
distributions. A few times over the years I've had users report
regressions that turned out to be due to upstream build flag
changes. I wonder if it would be possible for upstream to communicate
such changes - either via release notes or, where possible, as
build-time checks - to us downstream projects. Here are the examples I
recall:
> commit 4de8d61bcec02a13ceed84f92b0cf3ea58adf9c5
> Author: Gerd Hoffmann <kraxel@redhat.com>
> Date: Wed Dec 15 12:39:20 2021 +0100
>
> OvmfPkg: rework TPM configuration
>
For this I needed to change -DTPM_ENABLE=TRUE to -DTPM2_ENABLE=TRUE. I
feel like a build-time check would've been a good way to communicate
this one, e.g.:
#ifdef TPM_ENABLE
#error TPM_ENABLE has been renamed to TPM2_ENABLE
#endif
> commit 1631bb26ae991e530d3c96fe3161ea15144b358e
> Author: Gary Lin <glin@suse.com>
> Date: Mon Jun 10 14:55:09 2019 +0800
>
> OvmfPkg/README: Update the network build flags
>
> The following network build flags changed due to the inclusion of
> NetworkPkg/Network.fdf.inc.
>
Similar to the above, I needed to deal with this by setting
-DNETWORK_HTTP_BOOT_ENABLE=TRUE instead of -DHTTP_BOOT_ENABLE=TRUE. It
seems like maybe an #error on the removed #define could've helped
here as well.
And finally:
> commit 57783adfb579da32b1eeda77b2bec028a5e0b7b3
> Author: Michael D Kinney <michael.d.kinney@intel.com>
> Date: Tue Jul 26 12:40:00 2022 -0700
>
> OvmfPkg: Change default to disable MptScsi and PvScsi
With this types of change, it would be useful just to know this is
coming and why so I can decide to either notify users of the change
and/or override the default to avoid the regression. Would it be
possible to describe such changes in the release notes at
https://github.com/tianocore/edk2/releases - and, if not urgent,
perhaps #warn of deprecation in the source for one stable release
cycle?
-dann
next reply other threads:[~2022-12-06 0:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 0:09 dann frazier [this message]
2022-12-06 1:22 ` [edk2-devel] feature flag change notifications Michael D Kinney
2022-12-07 0:59 ` 回复: " gaoliming
2022-12-07 1:24 ` dann frazier
2022-12-07 1:22 ` dann frazier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y46IU4y65fjAIG1y@xps13.dannf \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox