From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mx.groups.io with SMTP id smtpd.web10.33497.1670285402944684894 for ; Mon, 05 Dec 2022 16:10:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@canonical.com header.s=20210705 header.b=jE5tk8hk; spf=pass (domain: canonical.com, ip: 185.125.188.122, mailfrom: dann.frazier@canonical.com) Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id A9E6F3F0A2 for ; Tue, 6 Dec 2022 00:10:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1670285400; bh=LErbytTE+24zBNHlL7u0i02MjQMHpcAoaeGLfNv/9O4=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=jE5tk8hkP5V4EAs9faoGFpegQO2zsHBAfTo7GzRINmrgZ0usLi4HESGGWzYoRISNI WdAP4lhEvLUu0h0psOcrX4sandq6RqD1znmA1ggsh5GmQd2sqi5/7KJhS6Rm7IRqoC nT0z9cof11KC8MbwDried4LF11/lKWXRB8Gi+d4FDIV8ZTRu4GwY8CU0P2fhPl+CrT gv9g0I61JhnavzELyt6cA/8e2X8oGfWSaoTRDDWj1urBuz92dlT1tLRzItZr80ZTda cxS13rcoLSEai2EstlSXn6+9nt2DoFbtjy7KJ9Dybxc4xhInImG9u9+dpqfLi7nF87 QJK3OVBwEZCxw== Received: by mail-il1-f198.google.com with SMTP id l13-20020a056e021c0d00b003034e24b866so6185606ilh.22 for ; Mon, 05 Dec 2022 16:10:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LErbytTE+24zBNHlL7u0i02MjQMHpcAoaeGLfNv/9O4=; b=rx9XoJASR5YXrL6S+HOi0WxP5jA1aDl74zBPDN6kbrS3UwwO+yOCWPvsSTQB8DaIrw TaKyoIa/s7NPfRkvXbasoz7PV3O0S2+PuX3V/SlYVTScPAneT0clpY9bXCQgUMMF0n9g vexrk6TGUakDKfNla4t5TpeK4RN38M+FH3GzxhnYaNG2czdVIPMtxzF96b4ND8spxAID 4hPnIcwAqawpH10BXvjE+vz2PsRyGy1sUqPCF4ZGHwQWdJBDgVUe1mukS8uxJ+7eScaG ToYpQf2XIlZxPt7izSEvjVO018YKhjr+FkE5YK5ETL9H+sVkfWm35/Gt1LsvU7sfipN1 46yw== X-Gm-Message-State: ANoB5pm4/mjgxYTuxE/iwQtCOc+Un8VV4gwcT4W4lAgre+xYA6ovfPLW cSeO6Thvgz9DZBvB0YdqZPkreYjbjWeI/gzAtYH8c1cJs7zaACAx+gPXo1s22FjfMSVaNITWJyY p0YaqXeBIUhO0e3elt1fC4JdFsbnPs3s= X-Received: by 2002:a05:6602:2498:b0:6de:3990:de0e with SMTP id g24-20020a056602249800b006de3990de0emr29473124ioe.203.1670285398650; Mon, 05 Dec 2022 16:09:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf4nfTTrb3+1lslcVYT/uaEmDcyewoOs+Z0J2+RGcp8Jz+QjHPkosAcm6hUwGOvx4cNykv/PQg== X-Received: by 2002:a05:6602:2498:b0:6de:3990:de0e with SMTP id g24-20020a056602249800b006de3990de0emr29473118ioe.203.1670285398284; Mon, 05 Dec 2022 16:09:58 -0800 (PST) Received: from xps13.dannf ([38.15.56.166]) by smtp.gmail.com with ESMTPSA id g20-20020a05663810f400b00374d6db7566sm6168164jae.117.2022.12.05.16.09.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 16:09:57 -0800 (PST) Date: Mon, 5 Dec 2022 17:09:55 -0700 From: "dann frazier" To: devel@edk2.groups.io Subject: feature flag change notifications Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, I maintain the edk2 packages in the Debian and Ubuntu distributions. A few times over the years I've had users report regressions that turned out to be due to upstream build flag changes. I wonder if it would be possible for upstream to communicate such changes - either via release notes or, where possible, as build-time checks - to us downstream projects. Here are the examples I recall: > commit 4de8d61bcec02a13ceed84f92b0cf3ea58adf9c5 > Author: Gerd Hoffmann > Date: Wed Dec 15 12:39:20 2021 +0100 > > OvmfPkg: rework TPM configuration > For this I needed to change -DTPM_ENABLE=TRUE to -DTPM2_ENABLE=TRUE. I feel like a build-time check would've been a good way to communicate this one, e.g.: #ifdef TPM_ENABLE #error TPM_ENABLE has been renamed to TPM2_ENABLE #endif > commit 1631bb26ae991e530d3c96fe3161ea15144b358e > Author: Gary Lin > Date: Mon Jun 10 14:55:09 2019 +0800 > > OvmfPkg/README: Update the network build flags > > The following network build flags changed due to the inclusion of > NetworkPkg/Network.fdf.inc. > Similar to the above, I needed to deal with this by setting -DNETWORK_HTTP_BOOT_ENABLE=TRUE instead of -DHTTP_BOOT_ENABLE=TRUE. It seems like maybe an #error on the removed #define could've helped here as well. And finally: > commit 57783adfb579da32b1eeda77b2bec028a5e0b7b3 > Author: Michael D Kinney > Date: Tue Jul 26 12:40:00 2022 -0700 > > OvmfPkg: Change default to disable MptScsi and PvScsi With this types of change, it would be useful just to know this is coming and why so I can decide to either notify users of the change and/or override the default to avoid the regression. Would it be possible to describe such changes in the release notes at https://github.com/tianocore/edk2/releases - and, if not urgent, perhaps #warn of deprecation in the source for one stable release cycle? -dann