From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.160848.1669751777550421823 for ; Tue, 29 Nov 2022 11:56:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=WWPLy+Zv; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ATJnRoB012788; Tue, 29 Nov 2022 19:56:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=ZXGCuIpmcQQOEaHblpbSM7U7ZzhZmylwe9BwajGXHCU=; b=WWPLy+ZvrcK/dJShEdLgdRCoDmbeb+zctIR/Ry7ZXozudwFAziw4uHtWThjEXIFMHbia oKxGvt/O64/dzaawlh7XTuiZW0pKk66WU5SqrJ6vL1VNgOXHNivaO0VqW8obckLWIGif sA+xT3jIHTn5K0CeSmOVINvJ5tY8+eOtEmIGIOgljCs3Neh57USj41VaVQOSd6WEojSE Zi/w/RR8pxp49dj0rzRKaBJ3WOmgjQj1yoHGhLE5q3DLEMmzE9owb0YIM5cABDgYvbc6 xzyDeEwsqq3hliRT+osYJIza08pPCE96LMdvUeqkxyBBVzX1RwulpLkOCOSivvhNfEy/ Nw== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3m5dnead3b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Nov 2022 19:56:06 +0000 Received: from nasanex01c.na.qualcomm.com (corens_vlan604_snip.qualcomm.com [10.53.140.1]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2ATJu5GH007993 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Nov 2022 19:56:05 GMT Received: from qc-i7.hemma.eciton.net (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 29 Nov 2022 11:56:04 -0800 Date: Tue, 29 Nov 2022 19:56:01 +0000 From: "Leif Lindholm" To: Rebecca Cran CC: , Ard Biesheuvel , "Abner Chang" , Daniel Schaefer Subject: Re: [PATCH 1/1] EmbeddedPkg/MetronomeDxe: Update TickPeriod doc to remove mention of lower bound Message-ID: References: <20221129124056.125316-1-rebecca@quicinc.com> MIME-Version: 1.0 In-Reply-To: <20221129124056.125316-1-rebecca@quicinc.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: f745ZUqKZ_8YvX_9YJd9udoHwk2_uOcx X-Proofpoint-ORIG-GUID: f745ZUqKZ_8YvX_9YJd9udoHwk2_uOcx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-29_11,2022-11-29_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 impostorscore=0 clxscore=1011 spamscore=0 phishscore=0 mlxlogscore=935 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211290115 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Tue, Nov 29, 2022 at 05:40:56 -0700, Rebecca Cran wrote: > There was previously a lower bound on the value of TickPeriod such that > it couldn't be less than 10 us. However, that was removed from the PI > Specification in the 1.0 errata released in 2007. From the revision > history: > > "M171 Remove 10 us lower bound restriction for the TickPeriod in the > Metronome" > > Update the documentation of TickPeriod in MetronomeDxe/Metronome.c to > remove mention of the lower bound. > > Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm I updated the subject line to pass patchcheck.py and pushed it as 8aff08c. Thanks! Diffing this file against the MdeModulePkg original, this seems inferior in every way other than possibly reducing the risk of counter overflow on 32-bit architectures. I will follow up with a patch that adds a #warning on all non-32-bit architectures. / Leif > --- > EmbeddedPkg/MetronomeDxe/Metronome.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/EmbeddedPkg/MetronomeDxe/Metronome.c b/EmbeddedPkg/MetronomeDxe/Metronome.c > index a0892315827f..63db6d513969 100644 > --- a/EmbeddedPkg/MetronomeDxe/Metronome.c > +++ b/EmbeddedPkg/MetronomeDxe/Metronome.c > @@ -43,10 +43,9 @@ WaitForTick ( > > @param TickPeriod > The period of platform's known time source in 100 nS units. > - This value on any platform must be at least 10 uS, and must not > - exceed 200 uS. The value in this field is a constant that must > - not be modified after the Metronome architectural protocol is > - installed. All consumers must treat this as a read-only field. > + This value on any platform must not exceed 200 uS. The value in this field > + is a constant that must not be modified after the Metronome architectural > + protocol is installed. All consumers must treat this as a read-only field. > > **/ > EFI_METRONOME_ARCH_PROTOCOL gMetronome = { > -- > 2.30.2 >