From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mx.groups.io with SMTP id smtpd.web10.30230.1670450361292203105 for ; Wed, 07 Dec 2022 13:59:22 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@canonical.com header.s=20210705 header.b=ehI/NgAF; spf=pass (domain: canonical.com, ip: 185.125.188.123, mailfrom: dann.frazier@canonical.com) Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 360014154A for ; Wed, 7 Dec 2022 21:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1670450359; bh=x/6QzARTS9w1qSD9CLYqEu7IEJ9A1SDiRCTeqldpPqo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=ehI/NgAFsk0L146SevMK6ETlBQEtBnACjod6pYv2HYgYXzE+zV4iwXP5ZnTIHk2kq sWBk0wM82uLmPp3plEa4jGpBToJDC/q4W94lnJopxURcRHvZi74ovn9vXPSq61Kfnf 6+IEvoln6CnO0s1CiPBD7ln+cLqn4pAQsY7P7WX9K92yPgTtnYS0gZ1+0x1/i4OlTH WVjuIwfrS/Ld+4JumlggefQOjdbfOTBpSAb8CvJaKWTeCDvZ+Gy/KVTUY5stezYyzd eH8kGkNkRmmF0Vlri/BKCrT1lf0DSiwFxd801M3GOZjoVYhq9WqjTCwpEsKgwimOWV WND159Io4iHUQ== Received: by mail-io1-f71.google.com with SMTP id y5-20020a056602120500b006cf628c14ddso14298363iot.15 for ; Wed, 07 Dec 2022 13:59:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x/6QzARTS9w1qSD9CLYqEu7IEJ9A1SDiRCTeqldpPqo=; b=k8dHpEokVUmc/fQm5o/TvbZs4ElIBQJWPrr6o/jcS88XIU1YZCeCqYbxqLDLeXNPuE eTyFFTmCKQu4pRyAVz3uelAHckc4P6kdB8MMm5XpN31ZTx7f+T5tVgIaq+Y6JtK6qX1r MOUn1+Lv1qNIaH6LCCO6L1AIUjMaZirttivLKvyixW6EjIcvwtO5YJ1lTz/C3cuEl191 y5UOv50p0BPYfi6TalV7cYUFpGKReqmzCkhs30PKiDWPVXgFCmOpTHwzSiwtUFhRbXj8 Io3xLaBEg3F1Y7ayADKhUxu98yvSsCRd0Gn7hRbRwscho7V4c40FfqAftvzw6hSdMcGT PHTA== X-Gm-Message-State: ANoB5pmK8t/SYA7YmvHcjOCN47X5YfSUG+aLFzvmp/6nY+RmRKSXqPQZ oWAPWEeVkzkjfCpji6Nf4mCVcvI25fanGDGJtUIJ4MJIezAo/fkNk0AXdKH5rVw3lAo1O2t9k9l grlStr7TPFipF5+1OUCQB4H+lj1LePJw= X-Received: by 2002:a5e:c643:0:b0:6e0:11bf:599e with SMTP id s3-20020a5ec643000000b006e011bf599emr618663ioo.0.1670450358079; Wed, 07 Dec 2022 13:59:18 -0800 (PST) X-Google-Smtp-Source: AA0mqf5Ou7jIm9lV0W+TNT+4HQzsEpQlkMksz+kbG23e251WXQER7nuLtOntvuziiJv2SEYf6goTmg== X-Received: by 2002:a5e:c643:0:b0:6e0:11bf:599e with SMTP id s3-20020a5ec643000000b006e011bf599emr618648ioo.0.1670450357735; Wed, 07 Dec 2022 13:59:17 -0800 (PST) Received: from xps13.dannf ([38.15.56.166]) by smtp.gmail.com with ESMTPSA id l7-20020a6b3e07000000b006e02c489089sm1916182ioa.32.2022.12.07.13.59.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 13:59:16 -0800 (PST) Date: Wed, 7 Dec 2022 14:59:14 -0700 From: "dann frazier" To: James Bottomley Cc: Ard Biesheuvel , Gerd Hoffmann , Mike Maslenkin , devel@edk2.groups.io, michael.d.kinney@intel.com, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Sebastien Boeuf , Brijesh Singh , Erdem Aktas , Min Xu , Tom Lendacky , 1016359@bugs.debian.org Subject: Re: [edk2-devel] [Patch 1/2] OvmfPkg: Change default to disable MptScsi and PvScsi Message-ID: References: <20221206055649.33rbcbkyuavpxqdk@sirius.home.kraxel.org> <20221207074123.ccj63ciwywubqj6k@sirius.home.kraxel.org> <887bc678bbd4a356edd420809bffa0964e0b162b.camel@linux.ibm.com> <20221207160140.ilh63xxxgefs5hff@sirius.home.kraxel.org> <9365af87923dc2dd59b7cd6aa59e1fba33f4bb5a.camel@linux.ibm.com> MIME-Version: 1.0 In-Reply-To: <9365af87923dc2dd59b7cd6aa59e1fba33f4bb5a.camel@linux.ibm.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 07, 2022 at 11:22:10AM -0500, James Bottomley wrote: > On Wed, 2022-12-07 at 17:04 +0100, Ard Biesheuvel wrote: > > On Wed, 7 Dec 2022 at 17:02, Gerd Hoffmann wrote: > > >=20 > > > On Wed, Dec 07, 2022 at 09:14:39AM -0500, James Bottomley wrote: > > > > On Wed, 2022-12-07 at 15:09 +0100, Ard Biesheuvel wrote: > > > > > So at some point, these drivers will be removed rather than > > > > > kept > > > > > alive by the core team unless someone steps up. > > > >=20 > > > > How important is keeping them alive? > > >=20 > > > Most common use case is probably bootimg images created on other > > > hypervisors on qemu.=A0 Otherwise there is little reason to use > > > something which is not virtio-scsi. > > >=20 > > > > I can volunteer to "maintain" them which I anticipate won't be > > > > much effort (plus I'm used to looking after obsolete SCSI > > > > equipment).=A0 The hardware is obsolete, so the mechanics of thei= r > > > > emulation isn't going to change, the only potential risk is > > > > changes in the guest to host transmission layer that breaks > > > > something. > > >=20 > >=20 > > Thanks James, that would be very helpful. > >=20 > > > Yes, I don't expect it being much effort, but knowing oldish scsi > > > stuff certainly helps understanding the driver code if needed.=A0 I= f > > > you want step up sent a patch updating Maintainers.txt accordingly. > > >=20 > >=20 > > Having the informed opinion of a domain expert should allow us to > > diagnose issued related to these drivers with more confidence, and > > also give us insight in how obsolete those drivers actually are. > >=20 > > I can send the patch if you prefer. >=20 > Sure, who can resist someone else doing all the work. >=20 > I note we do have a maintained LSI driver: OvmfPkg/LsiScsiDxe. It > seems to be based on the 53c896 which is really only a marginal subset > of the 1030 ... if I'm remembering correctly the 1030 did Low Voltage > Differential (so a faster SCSI Parallel bus), but since that's a SCSI > Bus protocol, it should have no real impact on the utility of the > emulation. Is the LsiScsiDxe usable by Debian? I tried it, but it doesn't seem to enumerate any blk devices. The driver loads and reports that it is managing a device: Shell> drivers T D D Y C I R P F A V VERSION E G G #D #C DRIVER NAME IMAGE NAME =3D=3D =3D=3D=3D=3D=3D=3D=3D=3D =3D =3D =3D =3D=3D =3D=3D =3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D [...] 6E 00000010 D - - 1 - LSI 53C895A SCSI Controller Driver LsiScsiDxe [...] But no blk devices. Using the same VM config and just swapping the controller from lsilogic to virtio-scsi, yields the expected blk devices. To be clear, I'm unaware of OVMF ever working with this device in Debian. -dann