From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by mx.groups.io with SMTP id smtpd.web10.6037.1670475514651037503 for ; Wed, 07 Dec 2022 20:58:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=id9+rN9B; spf=pass (domain: ventanamicro.com, ip: 209.85.161.52, mailfrom: sunilvl@ventanamicro.com) Received: by mail-oo1-f52.google.com with SMTP id e11-20020a4ab14b000000b0049be568062bso76751ooo.4 for ; Wed, 07 Dec 2022 20:58:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mKBzbbAffuOK2YXp7g4wm5EXTfDmaQQ8XIYfDdAPDWI=; b=id9+rN9BLyTbCoImkH842r/Svt7nL966GraRn00jkQ/HkyF6bEqaJDmLLghLC7It9E xxFJunTprNEeFd5b/vuneLu0Oo44Dhbq4kdzWY8N8Cr0qpLaFbjGNtxgP+m6uEgNDvuu SO8pi3akIYtVvhu6aNoySdG86BMnTlGsMeER8YorzZ9jNPrO68xSZR+MG0viT7DRPguS iujuqiXdgwWt/s9v7vtnxpfC6g+OeopcRzdA164+8o37z2QI8r9Lkadg99X8sYrDNZaC AZq3y2iiH01P/ggoVR/VTWdedWDii08u+VloRMLp/tn/y+j4x/kdOFDVKYXBoPejul/2 cXaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mKBzbbAffuOK2YXp7g4wm5EXTfDmaQQ8XIYfDdAPDWI=; b=bBMR1JqeLAXLPXkfsw7IAv7XGzt1sT7uHfwkIY/UNYFO9KSdDtyWlb3SEw0YJyo3HQ yTgPxm43Ox+Aib4ZmnP9PmEyLpmz6rH5r3GPvcSzyEQdwrglHYvPtzPKWZQM0ExYOhHK LXTPJrjcV3RXrnv3zmrrQnyXtBJXPou3w9CSF9O6onjcc59TwVJDMHRZtT0LQOZYuJOd YI8/lVhXkMZ28Ff6YbDrhaH8aS939eqKHOPxN9WB6Jm2bw5qlVefLDOwOQkW6bVqxG8T BU9PnYPLTxNU+WhboljKlbqY4uBI2BbYdVguO2sN49NPGYsNNRegNPgdFgK6c+v6CMNg yDcw== X-Gm-Message-State: ANoB5pkeyMj1MHL66Mtla8OPvZS80IqCDgnyfIEPDsRWSUXbHJze+ld7 nBm6S7ZhwwHjQdSEknYJ0cSTKENjOM85j77VHIA= X-Google-Smtp-Source: AA0mqf4Ftr6pWViN+3TZhUQJwgB0rtc7r+85hXf80R+9dPwqiDrBDJN8uQPQw6TJIMSycDWUCXYnog== X-Received: by 2002:a4a:5a85:0:b0:49f:d0ed:be4c with SMTP id v127-20020a4a5a85000000b0049fd0edbe4cmr634848ooa.9.1670475513784; Wed, 07 Dec 2022 20:58:33 -0800 (PST) Return-Path: Received: from sunil-laptop ([49.206.14.51]) by smtp.gmail.com with ESMTPSA id e9-20020a4ae0c9000000b004a05e943f9esm4872670oot.21.2022.12.07.20.58.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 20:58:33 -0800 (PST) Date: Thu, 8 Dec 2022 10:28:22 +0530 From: "Sunil V L" To: devel@edk2.groups.io, ray.ni@intel.com Cc: "Wang, Jian J" , "Gao, Liming" , "Dong, Eric" , "Kumar, Rahul R" , "De, Debkumar" , "West, Catharine" , Daniel Schaefer , Abner Chang , Leif Lindholm , Andrew Fish , Ard Biesheuvel , Heinrich Schuchardt , Anup Patel Subject: Re: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V support in DxeCpuExceptionHandlerLib Message-ID: References: <20220907113626.540065-1-sunilvl@ventanamicro.com> <20220907113626.540065-11-sunilvl@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 08, 2022 at 12:30:04AM +0000, Ni, Ray wrote: > Sunil, > Is there any source code sharing between Risc-V and IA32X64? > From the patch, I cannot see any. > If that's the case, I would prefer we don't mix the two separate implementations together into one component. > Can you please create a new CpuExceptionHandlerLib instance for Risc-V instead of including the Risc-V sources into the existing INF? > Thank you very much Ray. Sure. That approach is also fine with me. BTW, https://edk2.groups.io/g/devel/message/95726 was the latest series. Sorry for the confusion. Let me update this series and send new version. I think your input is valid for other modules also like TimerLib. Thanks Sunil