Re: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V support in DxeCpuExceptionHandlerLib

["Sunil V L" <sunilvl@ventanamicro.com>]

Hi Ray,

I have updated the series as per your suggestion
(https://edk2.groups.io/g/devel/message/97440). Patches 5/23 - 9/23 are
for UefiCpuPkg. Please review and let me know if this is acceptable
approach.

Thanks
Sunil

On Wed, Dec 14, 2022 at 12:37:04PM +0000, Ni, Ray wrote:
> No.
> I agree that rename can avoid confusion in future but that will cause lots of build break in all x86 platforms.
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif Lindholm
> > Sent: Wednesday, December 14, 2022 5:39 PM
> > To: Ni, Ray <ray.ni@intel.com>
> > Cc: Sunil V L <sunilvl@ventanamicro.com>; devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; De,
> > Debkumar <debkumar.de@intel.com>; West, Catharine <catharine.west@intel.com>; Daniel Schaefer
> > <git@danielschaefer.me>; Abner Chang <Abner.Chang@amd.com>; Andrew Fish <afish@apple.com>; Ard Biesheuvel
> > <ardb@kernel.org>; Heinrich Schuchardt <heinrich.schuchardt@canonical.com>; Anup Patel <apatel@ventanamicro.com>
> > Subject: Re: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V support in DxeCpuExceptionHandlerLib
> > 
> > Hi Ray,
> > 
> > Should we then consider renaming DxeCpuExceptionHandlerLib
> > DxeCpuExceptionHandlerLibIA32X64?
> > 
> > Best Regards,
> > 
> > Leif
> > 
> > 
> > On Thu, Dec 08, 2022 at 08:32:31 +0000, Ni, Ray wrote:
> > > Yes. I am not sure if the preference for modules in other packages.
> > > But for code in UefiCpuPkg, I don't prefer this way.
> > >
> > > Thanks,
> > > Ray
> > >
> > > > -----Original Message-----
> > > > From: Sunil V L <sunilvl@ventanamicro.com>
> > > > Sent: Thursday, December 8, 2022 12:58 PM
> > > > To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>
> > > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> > > > <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>; Kumar,
> > > > Rahul R <rahul.r.kumar@intel.com>; De, Debkumar
> > > > <debkumar.de@intel.com>; West, Catharine <catharine.west@intel.com>;
> > > > Daniel Schaefer <git@danielschaefer.me>; Abner Chang
> > > > <Abner.Chang@amd.com>; Leif Lindholm <quic_llindhol@quicinc.com>;
> > > > Andrew Fish <afish@apple.com>; Ard Biesheuvel <ardb@kernel.org>;
> > > > Heinrich Schuchardt <heinrich.schuchardt@canonical.com>; Anup Patel
> > > > <apatel@ventanamicro.com>
> > > > Subject: Re: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V
> > > > support in DxeCpuExceptionHandlerLib
> > > >
> > > > On Thu, Dec 08, 2022 at 12:30:04AM +0000, Ni, Ray wrote:
> > > > > Sunil,
> > > > > Is there any source code sharing between Risc-V and IA32X64?
> > > > > From the patch, I cannot see any.
> > > > > If that's the case, I would prefer we don't mix the two separate
> > > > implementations together into one component.
> > > > > Can you please create a new CpuExceptionHandlerLib instance for Risc-V
> > > > instead of including the Risc-V sources into the existing INF?
> > > > >
> > > > Thank you very much Ray. Sure. That approach is also fine with me.
> > > >
> > > > BTW, https://edk2.groups.io/g/devel/message/95726 was the latest series.
> > > > Sorry for the confusion. Let me update this series and send new version.
> > > > I think your input is valid for other modules also like TimerLib.
> > > >
> > > > Thanks
> > > > Sunil
> > 
> > 
> > 
> > 
> 
> 
> 
> 
> 
>