From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mx.groups.io with SMTP id smtpd.web11.6550.1671168191390212646 for ; Thu, 15 Dec 2022 21:23:11 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=aY1XVrYL; spf=pass (domain: ventanamicro.com, ip: 209.85.216.47, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pj1-f47.google.com with SMTP id n65-20020a17090a2cc700b0021bc5ef7a14so1371743pjd.0 for ; Thu, 15 Dec 2022 21:23:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+QXhqRBkk8ah3wrnaqqYFEjSL5bF4SakERY+Rgely7I=; b=aY1XVrYLEsASq52aVah1oEBJRpHlNOinv62ky8Jnck4eov/kbXbjzAX+p5t9nVHPeO xOeyRT8v5jEHuVZ0TThlwlT9UszCs0eytkVfmfsY6iSlozraXEw3nBxgdjuI6W6MHULp O7VH7iMj/Kr+8J90RBHPEMyuHQdEOkrnWHgCu63PjJUfdXCoEVClE9V5BXIev6iiysav Y9Rx/CtYUqdDNwuT06x37r2OOFiUsaCmn1xFGDO067scWwDlBqpchMf1bBJQBPo0mwXp mNsiRTkm3+nxdKeoPR3Z30bEYqbZlS82kAXEWy6qijzNZpH8b+V+F4m6kcsqqWRJAJFj ozgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+QXhqRBkk8ah3wrnaqqYFEjSL5bF4SakERY+Rgely7I=; b=PC9MfGd7HywYJWUFXPwVrFIfyCbKiv3SKtcNflcTYl3TylXeRUsfEieFR/81Q/gm8g TgDlOhFcduQbL3jaraNKqlFM9bsjiMRTcQm9tWQW8suHM9KeQcQwLYCUsCUBDLU1Meyf FK3s/NlkdYwRD0fYMrC8OBuejT+hY+BaEDYWbWmfgGDdwYw/W4Cx/eMA+h1uuu0EL2ks hBVGXQ8QuA1tN/9rZa6rAsQTFhnZrYm+ZI3qC2i8I6wuQiWtEDENZRciP9Zfi9iPZxqi QVW6S+A07ti/4DBuY1ev9xUNbH5u1/lJdbx8kNipBnldY0sQre/GrQgVvbeqDUOF1jck Uxvg== X-Gm-Message-State: ANoB5pnKb1MYiSSHAa8N9CRhGQEqndaqcbCY7e4tG3G+wtpyIpOoyJ8Y rQM5Djm27lkoxY5oWvm96yp8d4XdLlWXh/MqfA4= X-Google-Smtp-Source: AA0mqf6yEG6YOQvJ7SsdqmusSLPfRNEoVPBrhR5GtGcBJb8K5kuA4J/O2BTZQl8jLwWrgRd/pr8ehA== X-Received: by 2002:a17:903:4111:b0:189:cc58:7784 with SMTP id r17-20020a170903411100b00189cc587784mr28885304pld.45.1671168190584; Thu, 15 Dec 2022 21:23:10 -0800 (PST) Return-Path: Received: from sunil-laptop ([49.206.11.246]) by smtp.gmail.com with ESMTPSA id p1-20020a170902a40100b00180033438a0sm578301plq.106.2022.12.15.21.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 21:23:10 -0800 (PST) Date: Fri, 16 Dec 2022 10:52:59 +0530 From: "Sunil V L" To: devel@edk2.groups.io, ray.ni@intel.com Cc: "quic_llindhol@quicinc.com" , "Wang, Jian J" , "Gao, Liming" , "Dong, Eric" , "Kumar, Rahul R" , "De, Debkumar" , "West, Catharine" , Daniel Schaefer , Abner Chang , Andrew Fish , Ard Biesheuvel , Heinrich Schuchardt , Anup Patel Subject: Re: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V support in DxeCpuExceptionHandlerLib Message-ID: References: <20220907113626.540065-1-sunilvl@ventanamicro.com> <20220907113626.540065-11-sunilvl@ventanamicro.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Ray, I have updated the series as per your suggestion (https://edk2.groups.io/g/devel/message/97440). Patches 5/23 - 9/23 are for UefiCpuPkg. Please review and let me know if this is acceptable approach. Thanks Sunil On Wed, Dec 14, 2022 at 12:37:04PM +0000, Ni, Ray wrote: > No. > I agree that rename can avoid confusion in future but that will cause lots of build break in all x86 platforms. > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Leif Lindholm > > Sent: Wednesday, December 14, 2022 5:39 PM > > To: Ni, Ray > > Cc: Sunil V L ; devel@edk2.groups.io; Wang, Jian J ; Gao, Liming > > ; Dong, Eric ; Kumar, Rahul R ; De, > > Debkumar ; West, Catharine ; Daniel Schaefer > > ; Abner Chang ; Andrew Fish ; Ard Biesheuvel > > ; Heinrich Schuchardt ; Anup Patel > > Subject: Re: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V support in DxeCpuExceptionHandlerLib > > > > Hi Ray, > > > > Should we then consider renaming DxeCpuExceptionHandlerLib > > DxeCpuExceptionHandlerLibIA32X64? > > > > Best Regards, > > > > Leif > > > > > > On Thu, Dec 08, 2022 at 08:32:31 +0000, Ni, Ray wrote: > > > Yes. I am not sure if the preference for modules in other packages. > > > But for code in UefiCpuPkg, I don't prefer this way. > > > > > > Thanks, > > > Ray > > > > > > > -----Original Message----- > > > > From: Sunil V L > > > > Sent: Thursday, December 8, 2022 12:58 PM > > > > To: devel@edk2.groups.io; Ni, Ray > > > > Cc: Wang, Jian J ; Gao, Liming > > > > ; Dong, Eric ; Kumar, > > > > Rahul R ; De, Debkumar > > > > ; West, Catharine ; > > > > Daniel Schaefer ; Abner Chang > > > > ; Leif Lindholm ; > > > > Andrew Fish ; Ard Biesheuvel ; > > > > Heinrich Schuchardt ; Anup Patel > > > > > > > > Subject: Re: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V > > > > support in DxeCpuExceptionHandlerLib > > > > > > > > On Thu, Dec 08, 2022 at 12:30:04AM +0000, Ni, Ray wrote: > > > > > Sunil, > > > > > Is there any source code sharing between Risc-V and IA32X64? > > > > > From the patch, I cannot see any. > > > > > If that's the case, I would prefer we don't mix the two separate > > > > implementations together into one component. > > > > > Can you please create a new CpuExceptionHandlerLib instance for Risc-V > > > > instead of including the Risc-V sources into the existing INF? > > > > > > > > > Thank you very much Ray. Sure. That approach is also fine with me. > > > > > > > > BTW, https://edk2.groups.io/g/devel/message/95726 was the latest series. > > > > Sorry for the confusion. Let me update this series and send new version. > > > > I think your input is valid for other modules also like TimerLib. > > > > > > > > Thanks > > > > Sunil > > > > > > > > > > > > > >