From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mx.groups.io with SMTP id smtpd.web11.7096.1672898741601716203 for ; Wed, 04 Jan 2023 22:05:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=XXjdX9sZ; spf=pass (domain: ventanamicro.com, ip: 209.85.214.173, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pl1-f173.google.com with SMTP id 17so38448008pll.0 for ; Wed, 04 Jan 2023 22:05:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=948vmfV/74w21k3cOijyxI9Mn68Oj1LlmZ0e6rr0pRA=; b=XXjdX9sZEEXOLiRg2bcE0gTLolhu0+A+uOqOHQXqstFzNt+/3kOCpcShKS4OkbEFLS BlCFa8gthLeSjDc4BYLIYb6dChacPzfEruOrC8ZiE7YfzCLM09Auf+u00hFLG5WGUk0j GIaByg2kE5ZbyIEMpOh7evFXUD8NpY7TOSw2EnlzDVNa6r3H/I63kcQfLjqQXMDhxTTT +6RmxkTDOsXQ5eCt554T1IlZ0dWvj1gftRrCFNeDtXLup/bqg70wNV9ShDvgRGygbcGD eojYwePbWFkV2haGdUhLECjEqwM256RBzG2bT9rlidHy1YsNBXOKkpf+5OZZASJy+/GK rOcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=948vmfV/74w21k3cOijyxI9Mn68Oj1LlmZ0e6rr0pRA=; b=YeYiTlvPHh5xIYXOyJnSM42e5dTi2mYJie2IyIRxYZzYclnE0A0iTGZMqN0aVwMWJV SJh+5a47fq1S1e0uQwVdNJoc/fvy5GGnAT4t4XK5mQcu86hVJNh3T1oZf2LRQ84ozXpm VT4i70Ie5MIRa2d8JC+axgeC7/G7GcAwU5gQOiKxcxhe1wkRrd+E9DMQbSQxFG3si/wH spEGx5AwWUsbGtBeLjcgsQhGvSzs7aFiRlz8AVkav9DYSZxqVx/ayxPrv2XRCMB6rqve x/1ulXZDWKwuKVqCCXxPcqSZgMxfl09PuovMA/rMyE2yQ1dZ46L4NoVvDK185gLxpFKE M5xg== X-Gm-Message-State: AFqh2kq9uRDYCisZfhVqpUX74NnnDDk02pdidnR1/JLe2LxOr2+/XGNG MS4leMcqia2itgJATVnUaPvBnmTXZ0/y7k5c X-Google-Smtp-Source: AMrXdXvwh7SxiP+y7f1zS9TDtiU/XrxeVRG61pg5NjO9s2MeMqKtBtkjGcjfGa6O8FG/QlbK6bc/2w== X-Received: by 2002:a05:6a20:a6a7:b0:9d:efbe:e601 with SMTP id ba39-20020a056a20a6a700b0009defbee601mr68754681pzb.29.1672898741007; Wed, 04 Jan 2023 22:05:41 -0800 (PST) Return-Path: Received: from sunil-laptop ([49.206.11.246]) by smtp.gmail.com with ESMTPSA id m129-20020a625887000000b00562677968aesm23596769pfb.72.2023.01.04.22.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 22:05:40 -0800 (PST) Date: Thu, 5 Jan 2023 11:35:34 +0530 From: "Sunil V L" To: Dongdong Zhang Cc: devel@edk2.groups.io, zhuwenjun@eswincomputing.com, zhengyu@eswincomputing.com, jinyanjiang@eswincomputing.com, git@danielschaefer.me Subject: Re: [PATCH 1/1] Platform/RISC-V/PlatformPkg:fix image link error Message-ID: References: <20221228054550.6530-1-zhangdongdong@eswincomputing.com> <20221228054550.6530-2-zhangdongdong@eswincomputing.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Thanks for the patch!. Reviewed-by: Sunil V L On Thu, Jan 05, 2023 at 11:02:43AM +0800, Dongdong Zhang wrote: > Hi, all > Sorry, forgot to add Maintainer and Reviewer. > Add Sunil V L > Add Daniel Schaefer > > > -----原始邮件-----发件人:"Dongdong Zhang" 发送时间:2022-12-28 13:45:50 (星期三)收件人:devel@edk2.groups.io抄送:zhuwenjun@eswincomputing.com, zhengyu@eswincomputing.com, jinyanjiang@eswincomputing.com, "Dongdong Zhang" 主题:[PATCH 1/1] Platform/RISC-V/PlatformPkg:fix image link error > > > > Edk2OpensbiPlatformWrapperLib Library and RiscVSpecialPlatformLib > > Library mark the serial number in the figure is opposite to > > the text description, fix it and adjust the text order. > > > > Signed-off-by: Dongdong Zhang > > --- > > Platform/RISC-V/PlatformPkg/Readme.md | 14 ++++++++------ > > 1 file changed, 8 insertions(+), 6 deletions(-) > > > > diff --git a/Platform/RISC-V/PlatformPkg/Readme.md b/Platform/RISC-V/PlatformPkg/Readme.md > > index 5a344a8..d7166ba 100644 > > --- a/Platform/RISC-V/PlatformPkg/Readme.md > > +++ b/Platform/RISC-V/PlatformPkg/Readme.md > > @@ -35,19 +35,21 @@ are from OpenSBI project. edk2 libraries are introduced as the wrapper libraries > > [Indicated as #2 in the figure](#risc-v-edk2-port-design-diagrams) > > > ***OpenSbiPlatformLib*** provides the generic RISC-V platform initialization code. Platform vendor can just utilize this library if they don't have additional requirements on the platform initialization. > > > > -##### RiscVSpecialPlatformLib Library > > -[Indicated as #3 in the figure](#risc-v-edk2-port-design-diagrams) > > -> The major use case of this library is to facilitate the interfaces for platform vendors to provide the special > > -platform initialization based on the generic platform initialization library. > > - > > ##### Edk2OpensbiPlatformWrapperLib Library > > -[Indicated as #4 in the figure](#risc-v-edk2-port-design-diagrams) > > + > > +[Indicated as #3 in the figure](#risc-v-edk2-port-design-diagrams) > > > In order to providing the flexibility to edk2 RISC-V firmware solution, ***Edk2OpensbiPlatformWrapperLib*** is the wrapper library of [OpenSbiPlatformLib](#OpenSbiPlatformLib-library) to provide the interfaces for OEM. The ***platform_ops_address***in the generic platform structure is replaced with ***Edk2OpensbiplatformOps*** in SEC > > module. The platform function invoked by OpenSBI core is hooked to ***Edk2OpensbiPlatformWrapperLib***. This gives > > a change to OEM for implementing platform-specific initialization before and after the generic platform code. OEM > > can override this library under their platform folder on demand without touching ***RiscVOpensbiLib*** library > > source files and other common source files. > > > > +##### RiscVSpecialPlatformLib Library > > + > > +[Indicated as #4 in the figure](#risc-v-edk2-port-design-diagrams) > > +> The major use case of this library is to facilitate the interfaces for platform vendors to provide the special > > +platform initialization based on the generic platform initialization library. > > + > > ##### Next Phase Address and Privilege Mode > > [Indicated as #5 in the figure](#risc-v-edk2-port-design-diagrams) > > > Once OpenSBI finishes the boot initialization, it will jump to the next phase with the default privilege set to > > -- > > 2.17.1