From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp26.services.sfr.fr (smtp26.services.sfr.fr [93.17.128.3]) by mx.groups.io with SMTP id smtpd.web10.13340.1674985507055697563 for ; Sun, 29 Jan 2023 01:45:07 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@polynum.com header.s=202006 header.b=NHMNtUbE; spf=pass (domain: sfr.fr, ip: 93.17.128.3, mailfrom: thierry.laronde@sfr.fr) X-mail-filterd: {"version":"1.6.0","queueID":"4P4RHj2cWYz1LQKd9","contextId": "8baafafb-af3c-4c24-8739-23a699c8f30b"} Received: from cauchy.polynum.local (20.204.0.93.rev.sfr.net [93.0.204.20]) by msfrf2611.sfr.fr (SMTP Server) with ESMTP id 4P4RHj2cWYz1LQKd9; Sun, 29 Jan 2023 10:45:05 +0100 (CET) X-mail-filterd: {"version":"1.6.0","queueID":"4P4RHh0bxJz1LQKcm","contextId": "d8a45f25-dd9a-4ca5-a2b3-c192115190db"} X-sfr-mailing: LEGIT X-sfr-spamrating: 36 X-sfr-spam: not-spam DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=polynum.com; s=202006; t=1674985505; h=Date:From:To:Cc:Subject:References:In-Reply-To; bh=3gZCGNt9SG aeIP2tY7I7LcPHCQJaVE6aXMy6idZdUro=; b=NHMNtUbEwdPSJ+1ndvyk9O5tFKou8zav+VoHCF n4EjlUdRp6rWqY/6fIQ9icUvSDmEyFrWTlWmfgT+fVhhOajGPqLE4qu+IG1pH6zEepme47m6T48j pL8N6WhAKlYGz1uARn/gkgAbmpi6zHfvUy4ESgsYbHoLre3U95TPWq5/x0OQd4MEwfRO+jXTGOSk vsVeKwCPWbkZumVkwiyuI6CRjs8jSoQdcBM7VNklKfhcF8gmvEQCL38Ox+a6SrzXtQk483kvhxTW IQ5HXPQ7MrGemY3t/kKG05b2YDlOejThxW/LiLxwainqWiwGgTD3uGiTtssGP7qMEGM4ofXLF65A == X-List-Unsubscribe: Received: from cauchy.polynum.local (20.204.0.93.rev.sfr.net [93.0.204.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: thierry.laronde@sfr.fr) by msfrf2611.sfr.fr (SMTP Server) with ESMTPSA id 4P4RHh0bxJz1LQKcm; Sun, 29 Jan 2023 10:45:03 +0100 (CET) Authentication-Results: sfr.fr; auth=pass (LOGIN) smtp.auth=thierry.laronde@sfr.fr Received: from cauchy.polynum.local (localhost [127.0.0.1]) by cauchy.polynum.local (8.15.2/8.15.2) with ESMTP id 30T9j3ia000661; Sun, 29 Jan 2023 10:45:03 +0100 (CET) Received: (from tlaronde@localhost) by cauchy.polynum.local (8.15.2/8.14.9/Submit) id 30T9j28B000660; Sun, 29 Jan 2023 10:45:02 +0100 (CET) X-Authentication-Warning: cauchy.polynum.local: tlaronde set sender to thierry.laronde@sfr.fr using -f Date: Sun, 29 Jan 2023 10:45:02 +0100 From: "tlaronde@polynum.com" To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: "'Bob Feng'" , "'Yuwei Chen'" Subject: Re: [edk2-devel] ??: [PATCH 1/1] BaseTools: remove useless header inclusion Message-ID: References: <011101d93385$52b411e0$f81c35a0$@byosoft.com.cn> MIME-Version: 1.0 In-Reply-To: <011101d93385$52b411e0$f81c35a0$@byosoft.com.cn> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, Le Sun, Jan 29, 2023 at 09:59:29AM +0800, gaoliming via groups.io a =E9crit= : > With this change, does GenFv pass build on Linux environment? It should: there is absolutely nothing in GenFvInternalLib.c using uuid_* or UUID_*. Furthermore, the API exposed by FreeBSD uuid.h and util-linux-ng uuid/uuid.h are totally different; so this is why I wondered, from the start, what the inclusions were achieving. If the Linux build should fail, this would be by side-effect because a header included via uuid.h is missing. I can not test a Linux environment: I have none. BTW, in the patch, I should have removed the -luuid in GNUMakefile too. >=20 > > -----????----- > > ???: tlaronde@polynum.com > > ????: 2023?1?26? 18:03 > > ???: devel@edk2.groups.io > > ??: Bob Feng ; Liming Gao > > ; Yuwei Chen > > ??: [PATCH 1/1] BaseTools: remove useless header inclusion > >=20 > > GenFvInternalLib.c: useless inclusion and dependency on uuid.h. > >=20 > > From 6c0ba96fa11390750e102ebd277f59ef38970394 Mon Sep 17 00:00:00 > > 2001 > > From: Thierry LARONDE > > Date: Thu, 26 Jan 2023 10:49:12 +0100 > > Subject: [PATCH] Remove useless uuid.h include. > >=20 > > Signed-off-by: Thierry LARONDE > > --- > > BaseTools/Source/C/GenFv/GenFvInternalLib.c | 5 ----- > > 1 file changed, 5 deletions(-) > >=20 > > diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c > > b/BaseTools/Source/C/GenFv/GenFvInternalLib.c > > index 6bd59515b1..2df7182f8b 100644 > > --- a/BaseTools/Source/C/GenFv/GenFvInternalLib.c > > +++ b/BaseTools/Source/C/GenFv/GenFvInternalLib.c > > @@ -14,11 +14,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > // Include files > > // > >=20 > > -#if defined(__FreeBSD__) > > -#include > > -#elif defined(__GNUC__) > > -#include > > -#endif > > #ifdef __GNUC__ > > #include > > #endif > > -- > > 2.39.0 > >=20 > > -- > > Thierry Laronde > > http://www.kergis.com/ > > http://kertex.kergis.com/ > > Key fingerprint =3D 0FF7 E906 FBAF FE95 FD89 250D 52B1 AE95 6006 F40C >=20 >=20 >=20 >=20 >=20 >=20 >=20 --=20 Thierry Laronde http://www.kergis.com/ http://kertex.kergis.com/ Key fingerprint =3D 0FF7 E906 FBAF FE95 FD89 250D 52B1 AE95 6006 F40C