From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mx.groups.io with SMTP id smtpd.web10.40237.1675083939356151325 for ; Mon, 30 Jan 2023 05:05:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=aofczDSe; spf=pass (domain: ventanamicro.com, ip: 209.85.216.49, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pj1-f49.google.com with SMTP id mi9so1879286pjb.4 for ; Mon, 30 Jan 2023 05:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Cn+HQISylejtv+hfvy8WdmigC8CGzfyycqzmw8oFDzM=; b=aofczDSeVHR0X30pIQwNnz0xtyMF5YlAe7lDV7k3e8+L25VKXjUMj8rS2MrQL4SY6l 9x0eKsC4BAFsJrqW7HRl0DYp+G1zdEixoVobnkyiOVC1bfD69kxxwj7+IudZtxDMBwax rXPINIGlcw4KFbfypiO6i+APwgXpI4eei/gb2EdFw3b3F28Y1bP1ekQ1foChl6E9+KCX 3B+A4A8vGEvz5k04yPQot0EkY1Uv2QFibnwAiFGbnihbs0yxRbjQssdYuOGYzB7aBkuu 5aFkoex9JkjzDSdB1wwD/hLd198ayJwqx0H22qvyJR3xMMDEQISwHTo/mstzofSDdoSX iUow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Cn+HQISylejtv+hfvy8WdmigC8CGzfyycqzmw8oFDzM=; b=MtO1IHQfjqV5CbvCwAKjBp809v4JcY8Sf9d2k1fWcF3aRcD12qD4yL26xo3KUSF6BU DnWCW71WXzERoNVTUUqj5IedoIWu8awMtYKrmVbwRddqNsFD+1df5nw7KbwFpl1Hkv4L YEBU1gV6rMqIRVm9insvaZ4EMMP3ciUJdKlicyRRfsqlGfQNq19pB/KfBWObUO1346An bZlb9MvW5scaK19ZIoj/9oX0j1B/BXTV+MVYwoITEQBQflN+kVYoJ/BveuY4Jdr+JmhO GhnK6rpQw5zKHl3m5HQIRCNFj7dyjgx0NRS1T8T+HAomGe2AaKtdJT4axdrioD6cl0D4 2fIw== X-Gm-Message-State: AFqh2krymUD3jJ1z6bvRWhcKPHmZPLiSX4t+T7RbiV7FR7YbV3mOyLmW HOlZ8Xje6Vj8AeiBzDqZ7k2meA== X-Google-Smtp-Source: AMrXdXvLmYzzg7VP1UMjQw0zbbJl7sgU0tvhenDcjBMtbWVfV/be8xwliRd7mA725y+dkhASV29OrQ== X-Received: by 2002:a17:902:d650:b0:193:13fc:8840 with SMTP id y16-20020a170902d65000b0019313fc8840mr46554625plh.21.1675083938883; Mon, 30 Jan 2023 05:05:38 -0800 (PST) Return-Path: Received: from sunil-laptop ([49.206.11.246]) by smtp.gmail.com with ESMTPSA id a1-20020a170902ecc100b001948720f6bdsm7734929plh.98.2023.01.30.05.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 05:05:38 -0800 (PST) Date: Mon, 30 Jan 2023 18:35:34 +0530 From: "Sunil V L" To: dhaval@rivosinc.com Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 17/20] OvmfPkg/RiscVVirt: Add PciCpuIo2Dxe module Message-ID: References: <20230128191807.2080547-18-sunilvl@ventanamicro.com> <26729.1675073578100850032@groups.io> MIME-Version: 1.0 In-Reply-To: <26729.1675073578100850032@groups.io> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 30, 2023 at 02:12:58AM -0800, dhaval@rivosinc.com wrote: > What I see in the current implementation is: > > * UEFICpuPkg implements gEfiCpuIo2ProtocolGuid which does not seem to be generic. > * ARMPkg implements it which seems similar to what RV needs. > Yes, this is exact copy of the ArmPkg version. I guess Loongarch also will need the same. > Do we really expect this to be platform specific implementation and hence it should be in respective platform folders? Neither x86/ARM seem to follow this model? Correct. Both real and virtual platforms would need it. But adding inside UefiCpuPkg/CpuI02Dxe looked bit messy which needs bit more discussion and not sure whether it is a good idea to create parallel to CpuIo2Dxe. So, I thought it is better to add it in RiscVVirt for now instead of delaying the virt support even further. Let us take that as a separate activity after this series with inputs from different CPU architectures. Thanks Sunil