public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "tlaronde@polynum.com" <tlaronde@polynum.com>
To: devel@edk2.groups.io
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>,
	Bob Feng <bob.c.feng@intel.com>,
	"Chen, Christine" <yuwei.chen@intel.com>
Subject: [PATCH 1/1 v2] BaseTools: remove useless dependency on libuuid
Date: Mon, 30 Jan 2023 11:58:43 +0100	[thread overview]
Message-ID: <Y9ei48XYdOCJJRDk@polynum.com> (raw)

As asked by Bob Feng, I created a pull request #3969:

https://github.com/tianocore/edk2/pull/3969

CI check test passed successfully.

v2:
	- Remove also unneeded libuuid linking in GNUMakefile.


>From d8967e70cf649ed8d9412ba6996906c5ae2ff47d Mon Sep 17 00:00:00 2001
From: Thierry LARONDE <tlaronde@polynum.com>
Date: Mon, 30 Jan 2023 10:58:43 +0100
Subject: [PATCH] Remove useless libuuid dependency.

Signed-off-by: Thierry LARONDE <tlaronde@polynum.com>
---
 BaseTools/Source/C/GenFv/GNUmakefile        | 6 +-----
 BaseTools/Source/C/GenFv/GenFvInternalLib.c | 5 -----
 2 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/BaseTools/Source/C/GenFv/GNUmakefile b/BaseTools/Source/C/GenFv/GNUmakefile
index 7c7b95ba1b..872b981f6a 100644
--- a/BaseTools/Source/C/GenFv/GNUmakefile
+++ b/BaseTools/Source/C/GenFv/GNUmakefile
@@ -14,10 +14,6 @@ include $(MAKEROOT)/Makefiles/app.makefile
 
 LIBS = -lCommon
 ifeq ($(CYGWIN), CYGWIN)
-  LIBS += -L/lib/e2fsprogs -luuid
-endif
-
-ifeq ($(LINUX), Linux)
-  LIBS += -luuid
+  LIBS += -L/lib/e2fsprogs
 endif
 
diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c b/BaseTools/Source/C/GenFv/GenFvInternalLib.c
index 6bd59515b1..2df7182f8b 100644
--- a/BaseTools/Source/C/GenFv/GenFvInternalLib.c
+++ b/BaseTools/Source/C/GenFv/GenFvInternalLib.c
@@ -14,11 +14,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 // Include files
 //
 
-#if defined(__FreeBSD__)
-#include <uuid.h>
-#elif defined(__GNUC__)
-#include <uuid/uuid.h>
-#endif
 #ifdef __GNUC__
 #include <sys/stat.h>
 #endif
-- 
2.39.0

-- 
        Thierry Laronde <tlaronde +AT+ polynum +dot+ com>
                     http://www.kergis.com/
                    http://kertex.kergis.com/
Key fingerprint = 0FF7 E906 FBAF FE95 FD89  250D 52B1 AE95 6006 F40C

                 reply	other threads:[~2023-01-30 10:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9ei48XYdOCJJRDk@polynum.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox