From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mx.groups.io with SMTP id smtpd.web10.41014.1675086244637110634 for ; Mon, 30 Jan 2023 05:44:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=d7HZZ8Of; spf=pass (domain: ventanamicro.com, ip: 209.85.214.171, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pl1-f171.google.com with SMTP id r8so4793395pls.2 for ; Mon, 30 Jan 2023 05:44:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iHOuM902QdSsuoK1Mk41U2r90Okbr+Q+9SMMW79cKJ8=; b=d7HZZ8OfwbbdD6vBnTzwx4xFbr+hjR0xidNyOzJj1ROXeY1GTfiwIogtGF1W4X1MIE lZjWWMEydMbZ4Ls0I9LQokKM4/f8KQ6uhcj3bQkV8Vc8+tJR2+i1PZH4qt+S4dYPa2uZ R8WD+05PQCUsjOUNcKpYEhVH0HBhLeXJd6XOQaMRFFdu4MZAB/fFSckis3oKInt6AURj BSMUOfYE8PW0YxG5bj2/x9QPJwf1KmeWnSF0Prxv73d5ZpSTDaVGtFBJlxfA5g4oSTOn ywCwFMhKcHPM39iT7ZYkfiQcWvIJDGaljW345Gtq7wkijOCP2d/avUuQ43ozMMtG7w7y tOBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iHOuM902QdSsuoK1Mk41U2r90Okbr+Q+9SMMW79cKJ8=; b=Q1k+8a9GNczYn0itSiZ4D5/xPnpyj1Qz1X8D1vQuESWutezTAVhvIOCe8A4o7KYqpW VIKAqegytTgHWmDX7zTHrRG+wjuSpu5DoN5MUthRRxFFtmu5QLnCPzgMhNqqyLjdRYlH 4V/PaKGZCS8FuHcbvn/hX5y5QeDFjag/EGsXUD+Z0K4JNsV6S+dbc1lHjA0CG2LfvVen tPoP2j6eyAzebIBvucdB/FugqUlRsqpKYYhk4FXcKUEpCByQ0v+r+XU22xatgRHQ2fuE sPzfXkpz88UutdkwJYy4FCBN4XoLBt97UCcEeicsGRO4gG7owH47XMHj5rDV7t84ferY WyhA== X-Gm-Message-State: AO0yUKXSLJPeTyTZdVI/OnnMaGNbjxLFqZFzb56grZ1ZV0n+4Zemhojh pNevV3ZiteXifoM2WML7fXi4HVhV/aw0v57D X-Google-Smtp-Source: AK7set9jbuAwTGrDw/OIaT2VtZkE3Gs6FBBqEE98sC5tFbhSUre/ecQHeG//WdiyXRvibK3QseCl5g== X-Received: by 2002:a05:6a20:5497:b0:bc:aa13:c8ae with SMTP id i23-20020a056a20549700b000bcaa13c8aemr8879672pzk.42.1675086243827; Mon, 30 Jan 2023 05:44:03 -0800 (PST) Return-Path: Received: from sunil-laptop ([49.206.11.246]) by smtp.gmail.com with ESMTPSA id q21-20020a632a15000000b004c974bb9a4esm6791265pgq.83.2023.01.30.05.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 05:44:03 -0800 (PST) Date: Mon, 30 Jan 2023 19:13:57 +0530 From: "Sunil V L" To: devel@edk2.groups.io, Ard Biesheuvel , Leif Lindholm Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann Subject: Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 11/20] ArmVirtPkg/PlatformHasAcpiDtDxe: Move to OvmfPkg Message-ID: References: <20230128191807.2080547-1-sunilvl@ventanamicro.com> <173E8F29CD0D02D8.27165@groups.io> MIME-Version: 1.0 In-Reply-To: <173E8F29CD0D02D8.27165@groups.io> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Ard, Leif, Do you see any issues with this migration? Thanks! Sunil On Sun, Jan 29, 2023 at 12:47:58AM +0530, Sunil V L via groups.io wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 > > This module is required by other architectures like RISC-V. > Hence, move this to OvmfPkg. > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Signed-off-by: Sunil V L > --- > ArmVirtPkg/ArmVirtPkg.dec | 9 --------- > OvmfPkg/OvmfPkg.dec | 7 +++++++ > {ArmVirtPkg => OvmfPkg}/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf | 3 +-- > {ArmVirtPkg => OvmfPkg}/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.c | 0 > 4 files changed, 8 insertions(+), 11 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirtPkg.dec b/ArmVirtPkg/ArmVirtPkg.dec > index 89d21ec3a364..4645c91a8375 100644 > --- a/ArmVirtPkg/ArmVirtPkg.dec > +++ b/ArmVirtPkg/ArmVirtPkg.dec > @@ -34,8 +34,6 @@ [Guids.common] > gEarly16550UartBaseAddressGuid = { 0xea67ca3e, 0x1f54, 0x436b, { 0x97, 0x88, 0xd4, 0xeb, 0x29, 0xc3, 0x42, 0x67 } } > gArmVirtSystemMemorySizeGuid = { 0x504eccb9, 0x1bf0, 0x4420, { 0x86, 0x5d, 0xdc, 0x66, 0x06, 0xd4, 0x13, 0xbf } } > > - gArmVirtVariableGuid = { 0x50bea1e5, 0xa2c5, 0x46e9, { 0x9b, 0x3a, 0x59, 0x59, 0x65, 0x16, 0xb0, 0x0a } } > - > [PcdsFeatureFlag] > # > # Feature Flag PCD that defines whether TPM2 support is enabled > @@ -69,10 +67,3 @@ [PcdsFixedAtBuild, PcdsPatchableInModule] > # Cloud Hypervisor has no other way to pass Rsdp address to the guest except use a PCD. > # > gArmVirtTokenSpaceGuid.PcdCloudHvAcpiRsdpBaseAddress|0x0|UINT64|0x00000005 > - > -[PcdsDynamic] > - # > - # Whether to force disable ACPI, regardless of the fw_cfg settings > - # exposed by QEMU > - # > - gArmVirtTokenSpaceGuid.PcdForceNoAcpi|0x0|BOOLEAN|0x00000003 > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec > index a22eb246c625..e52602db5b79 100644 > --- a/OvmfPkg/OvmfPkg.dec > +++ b/OvmfPkg/OvmfPkg.dec > @@ -157,6 +157,7 @@ [Guids] > gVMMBootOrderGuid = {0x668f4529, 0x63d0, 0x4bb5, {0xb6, 0x5d, 0x6f, 0xbb, 0x9d, 0x36, 0xa4, 0x4a}} > gUefiOvmfPkgTdxAcpiHobGuid = {0x6a0c5870, 0xd4ed, 0x44f4, {0xa1, 0x35, 0xdd, 0x23, 0x8b, 0x6f, 0x0c, 0x8d}} > gEfiNonCcFvGuid = {0xae047c6d, 0xbce9, 0x426c, {0xae, 0x03, 0xa6, 0x8e, 0x3b, 0x8a, 0x04, 0x88}} > + gOvmfVariableGuid = {0x50bea1e5, 0xa2c5, 0x46e9, {0x9b, 0x3a, 0x59, 0x59, 0x65, 0x16, 0xb0, 0x0a}} > > [Ppis] > # PPI whose presence in the PPI database signals that the TPM base address > @@ -463,6 +464,12 @@ [PcdsDynamic, PcdsDynamicEx] > # 2 - set by GOP Driver. > gUefiOvmfPkgTokenSpaceGuid.PcdVideoResolutionSource|0|UINT8|0x64 > > + # > + # Whether to force disable ACPI, regardless of the fw_cfg settings > + # exposed by QEMU > + # > + gUefiOvmfPkgTokenSpaceGuid.PcdForceNoAcpi|0x0|BOOLEAN|0x69 > + > [PcdsFeatureFlag] > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE|BOOLEAN|0x1c > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|FALSE|BOOLEAN|0x1d > diff --git a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf b/OvmfPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > similarity index 89% > rename from ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > rename to OvmfPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > index e900aa992661..85873f73b2eb 100644 > --- a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > +++ b/OvmfPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > @@ -19,7 +19,6 @@ [Sources] > PlatformHasAcpiDtDxe.c > > [Packages] > - ArmVirtPkg/ArmVirtPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > @@ -38,7 +37,7 @@ [Guids] > gEdkiiPlatformHasDeviceTreeGuid ## SOMETIMES_PRODUCES ## PROTOCOL > > [Pcd] > - gArmVirtTokenSpaceGuid.PcdForceNoAcpi > + gUefiOvmfPkgTokenSpaceGuid.PcdForceNoAcpi > > [Depex] > gEfiVariableArchProtocolGuid > diff --git a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.c b/OvmfPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.c > similarity index 100% > rename from ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.c > rename to OvmfPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.c > -- > 2.38.0 > > > > > >