public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "tlaronde@polynum.com" <tlaronde@polynum.com>
To: devel@edk2.groups.io
Subject: CI passed yesterday; failing today only for PatchCheck
Date: Tue, 31 Jan 2023 10:52:49 +0100	[thread overview]
Message-ID: <Y9jk8WPRgfKFyA4P@polynum.com> (raw)

As requested, yesterday, for a trivial correction in BaseTools,
removing useless libuuid dependency in GenFv/, I made a Pull Request
and triggered a CI check test. All went fine.

Today, looking if the patches have been reviewed and merged, I saw that
since the master has changed, it required a merge. I did it and this
triggered once more a CI check and this time, there is one failure: the
PatchCheck (required) while everything builds without ado.

So some questions:

1) When a pull request with a CI check test has been made and passed
successfully, should one simply leave it as is---even if the head
moves---waiting for reviewer approval and merge?

2) Is it known that this procedure (merging and re-trigerring) leads to
a failure of PatchCheck for whatever reason?

3) In my case, the source modification should have impacted only Unix
like GCC builds: the modification of the GNUmakefile; the removal of
inclusions that dependend on __FreeBSD__ and __GNUC__ that is only GCC
related compilations. Is there a way to limit the CI compilation to a
subset (in this case GCC builds)? Because it seems to me a waste
of computer time for such a limited modification...

-- 
        Thierry Laronde <tlaronde +AT+ polynum +dot+ com>
                     http://www.kergis.com/
                    http://kertex.kergis.com/
Key fingerprint = 0FF7 E906 FBAF FE95 FD89  250D 52B1 AE95 6006 F40C

             reply	other threads:[~2023-01-31  9:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31  9:52 tlaronde [this message]
2023-01-31 15:43 ` [edk2-devel] CI passed yesterday; failing today only for PatchCheck Michael D Kinney
2023-01-31 15:54   ` tlaronde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9jk8WPRgfKFyA4P@polynum.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox