From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp26.services.sfr.fr (smtp26.services.sfr.fr [93.17.128.207]) by mx.groups.io with SMTP id smtpd.web10.3215.1675192464949091328 for ; Tue, 31 Jan 2023 11:14:25 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@polynum.com header.s=202006 header.b=RjGUPAUW; spf=pass (domain: sfr.fr, ip: 93.17.128.207, mailfrom: thierry.laronde@sfr.fr) X-mail-filterd: {"version":"1.6.0","queueID":"4P5vqg10Twz1LQL1j","contextId": "1cf5854d-a53b-4c6c-b953-d9ffc56d304a"} Received: from cauchy.polynum.local (20.204.0.93.rev.sfr.net [93.0.204.20]) by msfrf2628.sfr.fr (SMTP Server) with ESMTP id 4P5vqg10Twz1LQL1j; Tue, 31 Jan 2023 20:14:23 +0100 (CET) X-mail-filterd: {"version":"1.6.0","queueID":"4P5vqf5R8Dz1LQKcy","contextId": "64b67208-2fc2-47dc-a6d7-7098097962ac"} X-sfr-mailing: LEGIT X-sfr-spamrating: 36 X-sfr-spam: not-spam DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=polynum.com; s=202006; t=1675192463; h=Date:From:To:Cc:Subject:References:In-Reply-To; bh=2yLo+JCRbR /3d2NBw6B8PiNOTp22T29Et5ipbRszrX4=; b=RjGUPAUW6UO+Nz3yJmKQzR9grAMWzGYwgSlEwt A18vWIZ7IotPiA0eqzAs9P+VTEpF/GwSjJUEH95D4CHZGNIcW56K1I/1CcBFDf1jN5Rx3aw76xdI me2bpUpf0e3lPXyzT4qQMkjQrU8i/G15/Z3zedgRpmac5Ui5O7WgOsCbAecd6u7LAUQtufoBMBOR SWNSSSrmI68ouMbMRjdDdP/imP1vNNYFc+yhYuJtQpZ1eytJ00wZfh6IO8ANtnH6VeER1/Lmu90g udmxDzCNdYdy20uv631CxQTKvQ4PpSm0O7OM5+R/61S9RqL782yOKyzmWNPbTfZxCPLZ4cMyILUA == Received: from cauchy.polynum.local (20.204.0.93.rev.sfr.net [93.0.204.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: thierry.laronde@sfr.fr) by msfrf2628.sfr.fr (SMTP Server) with ESMTPSA id 4P5vqf5R8Dz1LQKcy; Tue, 31 Jan 2023 20:14:22 +0100 (CET) Authentication-Results: sfr.fr; auth=pass (LOGIN) smtp.auth=thierry.laronde@sfr.fr Received: from cauchy.polynum.local (localhost [127.0.0.1]) by cauchy.polynum.local (8.15.2/8.15.2) with ESMTP id 30VJELGp004964; Tue, 31 Jan 2023 20:14:21 +0100 (CET) Received: (from tlaronde@localhost) by cauchy.polynum.local (8.15.2/8.14.9/Submit) id 30VJELNp003412; Tue, 31 Jan 2023 20:14:21 +0100 (CET) X-Authentication-Warning: cauchy.polynum.local: tlaronde set sender to thierry.laronde@sfr.fr using -f Date: Tue, 31 Jan 2023 20:14:21 +0100 From: "tlaronde@polynum.com" To: devel@edk2.groups.io Cc: "Gao, Liming" , Bob Feng , "Chen, Christine" , michael.d.kinney@intel.com Subject: Re: [edk2-devel] [PATCH 1/1 v2] BaseTools: remove useless dependency on libuuid Message-ID: References: <173F110BAB855CF8.21443@groups.io> MIME-Version: 1.0 In-Reply-To: <173F110BAB855CF8.21443@groups.io> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable New pull request #3975: https://github.com/tianocore/edk2/pull/3975 CI tests passed. Could this trivial clean-up please be merged? TIA T. Laronde Le Mon, Jan 30, 2023 at 11:58:43AM +0100, tlaronde@polynum.com a =E9crit = : > As asked by Bob Feng, I created a pull request #3969: >=20 > https://github.com/tianocore/edk2/pull/3969 >=20 > CI check test passed successfully. >=20 > v2: > - Remove also unneeded libuuid linking in GNUMakefile. >=20 >=20 > >From d8967e70cf649ed8d9412ba6996906c5ae2ff47d Mon Sep 17 00:00:00 2001 > From: Thierry LARONDE > Date: Mon, 30 Jan 2023 10:58:43 +0100 > Subject: [PATCH] Remove useless libuuid dependency. >=20 > Signed-off-by: Thierry LARONDE > --- > BaseTools/Source/C/GenFv/GNUmakefile | 6 +----- > BaseTools/Source/C/GenFv/GenFvInternalLib.c | 5 ----- > 2 files changed, 1 insertion(+), 10 deletions(-) >=20 > diff --git a/BaseTools/Source/C/GenFv/GNUmakefile b/BaseTools/Source/C/= GenFv/GNUmakefile > index 7c7b95ba1b..872b981f6a 100644 > --- a/BaseTools/Source/C/GenFv/GNUmakefile > +++ b/BaseTools/Source/C/GenFv/GNUmakefile > @@ -14,10 +14,6 @@ include $(MAKEROOT)/Makefiles/app.makefile > =20 > LIBS =3D -lCommon > ifeq ($(CYGWIN), CYGWIN) > - LIBS +=3D -L/lib/e2fsprogs -luuid > -endif > - > -ifeq ($(LINUX), Linux) > - LIBS +=3D -luuid > + LIBS +=3D -L/lib/e2fsprogs > endif > =20 > diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c b/BaseTools/So= urce/C/GenFv/GenFvInternalLib.c > index 6bd59515b1..2df7182f8b 100644 > --- a/BaseTools/Source/C/GenFv/GenFvInternalLib.c > +++ b/BaseTools/Source/C/GenFv/GenFvInternalLib.c > @@ -14,11 +14,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > // Include files > // > =20 > -#if defined(__FreeBSD__) > -#include > -#elif defined(__GNUC__) > -#include > -#endif > #ifdef __GNUC__ > #include > #endif > --=20 > 2.39.0 >=20 --=20 Thierry Laronde http://www.kergis.com/ http://kertex.kergis.com/ Key fingerprint =3D 0FF7 E906 FBAF FE95 FD89 250D 52B1 AE95 6006 F40C