Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 10/20] EmbeddedPkg: Enable PcdPrePiCpuIoSize for RISC-V

["Sunil V L" <sunilvl@ventanamicro.com>]

Hi Ard, Leif,

Irrespective of refactoring gets accepted or not, this change is
necessary for RISC-V. This is a simple change and it will be great if
you could merge before freeze window starts.

In fact, I don't know why this PCD PcdPrePiCpuIoSize is required in
PrePiLib.inf since it is not used in the library. So, it should work
if it gets removed from PrePiLib.inf. Any of these two solutions will allow
us to use the library for RISC-V.

Thanks!
Sunil

On Sun, Jan 29, 2023 at 12:47:57AM +0530, Sunil V L via groups.io wrote:
> This PCD is required to be enabled so that PrePiLib
> can be used in RISC-V.
> 
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> ---
>  EmbeddedPkg/EmbeddedPkg.dec | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec
> index 341ef5e6a679..2965f01444e9 100644
> --- a/EmbeddedPkg/EmbeddedPkg.dec
> +++ b/EmbeddedPkg/EmbeddedPkg.dec
> @@ -165,6 +165,9 @@ [PcdsFixedAtBuild.IA32]
>  [PcdsFixedAtBuild.X64]
>    gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16|UINT8|0x00000011
>  
> +[PcdsFixedAtBuild.RISCV64]
> +  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|0|UINT8|0x00000011
> +
>  [PcdsFixedAtBuild.common, PcdsDynamic.common]
>    #
>    # Value to add to a host address to obtain a device address, using
> -- 
> 2.38.0
> 
> 
> 
> 
> 
>