From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mx.groups.io with SMTP id smtpd.web11.7190.1675417576059749044 for ; Fri, 03 Feb 2023 01:46:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=EyqkrICC; spf=pass (domain: ventanamicro.com, ip: 209.85.210.173, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pf1-f173.google.com with SMTP id g9so3152753pfo.5 for ; Fri, 03 Feb 2023 01:46:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=woDaTVD/DznPDT5Hej6dE/CcZXhlFLs4yX6q/2M09AM=; b=EyqkrICCK05dLK7g3zwtfdMKh0W1tNN2fC1oVpC3cxGrSyizoRrmSVAvOw309D8R7O rQnAiPXYDTVWXLiPYGxzXnPaJBOTvHvBBJYGW8KB+nzKWCV5FfbP1mLS1WjiRFIM53Fe T2vqr7FRyAVec08FZD6eER5/DtCaQKcwN9T9fg5Ok7UCoRxzkP5DORhK5T6avfCtK8YR mnmI9E0w16Sdpd/Zsv2LTiwNSsrIuA1XfrqyG2kFvki8audVBQ6Zurr39NuVSS1UD1O+ SuDYfR5KKMvJFHA7g5S70+4tAQQoSNWsS+E392h1JiErmbJCObYxxqyYn0p2pOuZwbTL 5A+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=woDaTVD/DznPDT5Hej6dE/CcZXhlFLs4yX6q/2M09AM=; b=jV8grF3bcqln+EYlzPQ7e0+5LS2RBdLy1tVEe7jZogT4PFs0FCr65+JMUCoy27uz5p ufmiJXcjjyXiGW5Pkc6+GjNhYY1gMfdLCK3eJ49dYrWQU1fkRzMAZfXCVpquvwbx9qGr ioxLXuemFeXOXdiVeDOloIZkcJGFojGTJI21g9gR0vIhBuIVesHkHhE+yUeNQ0jT5jFL Q6Bdq3h9VXo9ELYHfTuCxzTgAaCxjCwuPxOnrFRCVVTDzGWSAtpYNhrxPrNYgvv6NZQv gW6d4kPfukat076yw8nKyC3tXRW2d+EeequmBToiyCF/UcojNZyJkFZL9uOaiMaK8OXH gR6w== X-Gm-Message-State: AO0yUKVxJhg4oX5XChpLckKseWPJ1RHNpJviRmpO5YU80RXwTjyjb3Qf kwKqukyMZ0LVXx5jOEquTzL/VQiHQyn0qzON X-Google-Smtp-Source: AK7set+XspH9vBxYW89WsTQjkd0PAkgnmBUl1YTEVD1e2ExVXtfTNgzmgijCAt+WybFiZzHdhs2Tjw== X-Received: by 2002:aa7:96ac:0:b0:58d:9ad4:adaa with SMTP id g12-20020aa796ac000000b0058d9ad4adaamr9059661pfk.17.1675417575401; Fri, 03 Feb 2023 01:46:15 -0800 (PST) Return-Path: Received: from sunil-laptop ([49.206.14.226]) by smtp.gmail.com with ESMTPSA id x190-20020a6231c7000000b0058d9a5bac88sm1224471pfx.203.2023.02.03.01.46.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 01:46:15 -0800 (PST) Date: Fri, 3 Feb 2023 15:16:09 +0530 From: "Sunil V L" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer Subject: Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 10/20] EmbeddedPkg: Enable PcdPrePiCpuIoSize for RISC-V Message-ID: References: <20230128191807.2080547-1-sunilvl@ventanamicro.com> <173E8F293E682CB4.27165@groups.io> MIME-Version: 1.0 In-Reply-To: <173E8F293E682CB4.27165@groups.io> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Ard, Leif, Irrespective of refactoring gets accepted or not, this change is necessary for RISC-V. This is a simple change and it will be great if you could merge before freeze window starts. In fact, I don't know why this PCD PcdPrePiCpuIoSize is required in PrePiLib.inf since it is not used in the library. So, it should work if it gets removed from PrePiLib.inf. Any of these two solutions will allow us to use the library for RISC-V. Thanks! Sunil On Sun, Jan 29, 2023 at 12:47:57AM +0530, Sunil V L via groups.io wrote: > This PCD is required to be enabled so that PrePiLib > can be used in RISC-V. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Abner Chang > Cc: Daniel Schaefer > Signed-off-by: Sunil V L > --- > EmbeddedPkg/EmbeddedPkg.dec | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec > index 341ef5e6a679..2965f01444e9 100644 > --- a/EmbeddedPkg/EmbeddedPkg.dec > +++ b/EmbeddedPkg/EmbeddedPkg.dec > @@ -165,6 +165,9 @@ [PcdsFixedAtBuild.IA32] > [PcdsFixedAtBuild.X64] > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16|UINT8|0x00000011 > > +[PcdsFixedAtBuild.RISCV64] > + gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|0|UINT8|0x00000011 > + > [PcdsFixedAtBuild.common, PcdsDynamic.common] > # > # Value to add to a host address to obtain a device address, using > -- > 2.38.0 > > > > > >