From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mx.groups.io with SMTP id smtpd.web11.8290.1675423000989292527 for ; Fri, 03 Feb 2023 03:16:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=Tns45AER; spf=pass (domain: ventanamicro.com, ip: 209.85.216.41, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pj1-f41.google.com with SMTP id pj3so4713974pjb.1 for ; Fri, 03 Feb 2023 03:16:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=skD8n1vnjjlkSduvA0pVDecD86mA58od6WQXZ2BeZy8=; b=Tns45AERAQ6W9pNXyBSPCa+7mlMPiWDAbI2zxsi2uv1dyV1+YJtoz6+1/JUpS4Spoc MPa/Sc339J1dmX+RHCuQDmcHQIxoyYpfjPesjbat5z5GI3lkSTHQZ5ZQaSn3mQ0cIZRs kYo7y8iBS2Gor0tVBD+fS6vZMxrtNAvn2R8+ZDlMRCCGPgoSVuOdRyYDbrCGmwdP2vpU k7LVOdw6tr2R4HUJjm60+wzLz+kVptF7HC24fDiHcYsCSmz8Hxgx/i7bJZsXZdocqT8I Gasw1VEpmgU18hYNuiMbmYLFgA86d5QubWwCWHBnk70c9OiJGXOoMREfVTJ8RhrGR4I6 MDOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=skD8n1vnjjlkSduvA0pVDecD86mA58od6WQXZ2BeZy8=; b=u6yy/GhziwFJ1ZTO5l2xdQT1R4FFjxeA5I7Au6lnIk71/jsTnA29lNnoSjo0xtVXDP 91EtSBNpiQiCSVn8KzHmMz8E89ZVbvftTwYP8o9EuosOfUiTlvLF68hqfreoOvAxSko9 VqPsTY7yW3nNAgNJDdUpxMwXihUuCyUN91oeGihD1XpUKNPVP/Qiz2KE1G153nZLEAhb u4wABGDfMfYCJfAsfKlAsjd9nHmLCO56TeNtRonHeqhekcV6moZ+bx/m2hR6ypmziKLF SDiTZiXaMlQ0iOfyVnBJcbN9Cg/nv+zpg6U+VqYcZKm1PuWLih33XUHyJrD+/QN5gicB bJTQ== X-Gm-Message-State: AO0yUKXm50ua7NtLQMY148QVenFWpoTDr7hZHXiHCitSSQHSNNkWAfjR HS4BeBrqjvw60U99QihZ4588Yw== X-Google-Smtp-Source: AK7set9lyRpjV8TcmmgpYbzTotAmvV7Tj+urPvjyW/oZS/9QZtDpzqxZuiT/HF/Jnzf8sQ5g92hwcQ== X-Received: by 2002:a17:902:e550:b0:195:f3e3:b923 with SMTP id n16-20020a170902e55000b00195f3e3b923mr10755518plf.8.1675423000486; Fri, 03 Feb 2023 03:16:40 -0800 (PST) Return-Path: Received: from sunil-laptop ([49.206.14.226]) by smtp.gmail.com with ESMTPSA id y7-20020a637d07000000b0048988ed9e4bsm1282595pgc.19.2023.02.03.03.16.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 03:16:40 -0800 (PST) Date: Fri, 3 Feb 2023 16:46:35 +0530 From: "Sunil V L" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Leif Lindholm , Abner Chang , Daniel Schaefer Subject: Re: [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize Message-ID: References: <20230203110843.2349736-1-ardb@kernel.org> MIME-Version: 1.0 In-Reply-To: <20230203110843.2349736-1-ardb@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thanks a lot!, Ard. Reviewed-by: Sunil V L On Fri, Feb 03, 2023 at 12:08:43PM +0100, Ard Biesheuvel wrote: > The code never references the PCD so the INF should not reference it > either. The last reference was moved to PrePiHobLib in commit > 05e48e00834b32e4bd2 (dated 2011!) and dropped from there as well in > commit 97106391955337155e7. > > Cc: Leif Lindholm > Cc: Abner Chang > Cc: Daniel Schaefer > Reported-by: Sunil V L > Signed-off-by: Ard Biesheuvel > --- > EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > index 3c749ca22943..090bfe888f52 100644 > --- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > +++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > @@ -58,8 +58,6 @@ [Protocols] > > > [FixedPcd.common] > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize > - > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType > -- > 2.39.1 >