public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ilias Apalodimas" <ilias.apalodimas@linaro.org>
To: Sami Mujawar <sami.mujawar@arm.com>
Cc: devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 1/3 v7] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver
Date: Sat, 27 Mar 2021 22:49:37 +0200	[thread overview]
Message-ID: <YF+aYQhRtdFqCcgq@enceladus> (raw)
In-Reply-To: <14174.1616876741028136783@groups.io>

On Sat, Mar 27, 2021 at 01:25:41PM -0700, Sami Mujawar wrote:
> Hi Ilias,
> 
> On Sat, Mar 13, 2021 at 10:31 AM, Ilias Apalodimas wrote:
> 
> > 
> > + NumBytes =3D NumLba * Instance->BlockSize;=0D
> > + Base =3D (VOID *)Instance->MemBaseAddress + Start * Instance->BlockSiz=
> > e;=0D
> > + Buf =3D AllocatePool (NumLba * Instance->BlockSize);=0D
> > + if (Buf =3D=3D NULL) {=0D
> > + return EFI_DEVICE_ERROR;=0D
> > + }=0D
> > + SetMem64 (Buf, NumLba * Instance->BlockSize, ~0UL);=0D
> > + // Write the device=0D
> > + Status =3D ReadWriteRpmb (=0D
> > + SP_SVC_RPMB_WRITE,=0D
> > + (UINTN)Buf,=0D
> > + NumBytes,=0D
> > + Start * Instance->BlockSize=0D
> > + );=0D
> > + if (EFI_ERROR (Status)) {=0D
> 
> I think there is a memory leak here as Buf is not freed. If you agree, I will fix this locally before merging the changes.

Yes there is, please do and let me know if you need anything else.
Thanks for the catch!

Cheers
/Ilias
> 
> > 
> > + return Status;=0D
> > + }=0D
> > + // Update the in memory copy=0D
> > + SetMem64 (Base, NumLba * Instance->BlockSize, ~0UL);=0D
> > + FreePool (Buf);=0D
> > + }=0D
> > +=0D
> > + VA_END (Args);=0D
> > +=0D
> > + return EFI_SUCCESS;=0D
> > +}=0D
> 
> Regards,
> 
> Sami Mujawar

  reply	other threads:[~2021-03-27 20:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-13 18:31 [PATCH 0/3 v7] Add support for running StandaloneMm as OP-TEE TA Ilias Apalodimas
2021-03-13 18:31 ` [PATCH 1/3 v7] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver Ilias Apalodimas
2021-03-27 20:25   ` [edk2-devel] " Sami Mujawar
2021-03-27 20:49     ` Ilias Apalodimas [this message]
2021-03-28 10:30       ` Sami Mujawar
2021-03-13 18:31 ` [PATCH 2/3 v7] StMMRpmb: Add support for building StandaloneMm image for OP-TEE Ilias Apalodimas
2021-03-13 18:31 ` [PATCH 3/3 v7] Maintainers: Add maintainers for StandAloneMM and RPMB driver Ilias Apalodimas
2021-03-28 10:29   ` Sami Mujawar
2021-03-28 10:52 ` [PATCH 0/3 v7] Add support for running StandaloneMm as OP-TEE TA Sami Mujawar
2021-03-28 11:30   ` Ilias Apalodimas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YF+aYQhRtdFqCcgq@enceladus \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox