From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mx.groups.io with SMTP id smtpd.web10.6210.1616931020686303130 for ; Sun, 28 Mar 2021 04:30:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=D1jU5XQm; spf=pass (domain: linaro.org, ip: 209.85.221.47, mailfrom: ilias.apalodimas@linaro.org) Received: by mail-wr1-f47.google.com with SMTP id j18so10009501wra.2 for ; Sun, 28 Mar 2021 04:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=m7StXVoiCIQ0nkx64XV9AGqYcfKsk5ADLIJA8AEBhgo=; b=D1jU5XQmSZxkvU9zUATC1p7rmrOjJQR4eIJ5MMIM+el3Btzg7Rka4LcgwQyoMWHqXL 3uKxjb4t4tnpHIS99jjRKfkg52n9dLFGkhsDLetJSfnesJTQXVmRGQl/LoIrhpbN1ex7 V3pzVRNWlTuHiCgcJXmShK2GFKEho0Qq8cGkZRqF/zTejAk/q0ULf/dUPbHn2XRJqgW4 UeJrZprgIDFAnez27Juo5MnU2gRWgWK9gOaFgFzUmsybvu2pvPbd931W7DOTdECP2l/9 x6BUTzpAqxJaSS4rRwLn24/duufEEHnz4NnziBJ9iEIvqmnqSuBe6c0XV0ofGeQdqR4v Kf6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m7StXVoiCIQ0nkx64XV9AGqYcfKsk5ADLIJA8AEBhgo=; b=c0CVhSvxHNgq4JpCcZXpt3r50m2PlyLkKWEuKAekcO4m2yW1cSWIASmZVfBjDfzt4q IKk32712WZ844HAkIAgnQyYIeoTFikkkX0IZr/MpHqS6xeTXDrmUzt8/lvWBH4CItYHG hYGXnrus5AuFr2Il3L+SDg7lMYMy/g6cXo0Id6xpIDEkjCVLZtFWTWy0ihC8o6+n6IcC XtHtPmTt7rxCb0J12Rc4xwBJYQ+PQFbzru0e1qXORJqWkKYekUCzfAYvLkVtz6MXPssc ks538e2WNGQj5f7G1/y/K5xpixjh3eWjrkx+8tc/Z57XC/rpm9D0/vQN0h3yxJp2A1Ve w8uA== X-Gm-Message-State: AOAM5314PEVHRTXuCpUaGTydaPnprJoPZfzkJe39u++ESlVQtH36kGIT s5ho3G7xe7xNdo80gWXKR7DHvw== X-Google-Smtp-Source: ABdhPJwLglpFIQYT48yqCC503jecEo6mlejBBCw7ZPchjvscGsFKnItLQwviYLP3BWLfQB+kktKj3A== X-Received: by 2002:a5d:5487:: with SMTP id h7mr23847820wrv.348.1616931019283; Sun, 28 Mar 2021 04:30:19 -0700 (PDT) Return-Path: Received: from apalos.home (ppp-94-64-113-158.home.otenet.gr. [94.64.113.158]) by smtp.gmail.com with ESMTPSA id p10sm24316247wrw.33.2021.03.28.04.30.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Mar 2021 04:30:18 -0700 (PDT) Date: Sun, 28 Mar 2021 14:30:16 +0300 From: "Ilias Apalodimas" To: Sami Mujawar Cc: "devel@edk2.groups.io" , Pierre Gondois , "ardb+tianocore@kernel.org" , "sughosh.ganu@linaro.org" , "leif@nuviainc.com" , nd Subject: Re: [PATCH 0/3 v7] Add support for running StandaloneMm as OP-TEE TA Message-ID: References: <20210313183139.3256104-1-ilias.apalodimas@linaro.org> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Mar 28, 2021 at 10:52:19AM +0000, Sami Mujawar wrote: > Hi ilias, > > Thank you for this series. > > Pushed as afb0ce7e9756..89f6170d6686 > Thanks Sami! > Regards, > > Sami Mujawar > > > From: Ilias Apalodimas > Date: Saturday, 13 March 2021 at 18:32 > To: devel@edk2.groups.io , Sami Mujawar , Pierre Gondois > Cc: ardb+tianocore@kernel.org , sughosh.ganu@linaro.org , leif@nuviainc.com , Ilias Apalodimas > Subject: [PATCH 0/3 v7] Add support for running StandaloneMm as OP-TEE TA > Hi, > This is v7 of [1] > > Changes since V6: > - Added param[in,out] in comments > - Fixed an error on Maintainers entry > > Changes since V5: > - Addressed coding style fixes from Pierre > - Removed redundant checks in memory allocation and block usage > - Removed unused COMPRESSION_TOOL_GUID > - Renamed the files and directories following Leif's sugestion > - Added Sami and myself as maintainers > > Changes since V4: > - More coding stule fixes proposed by Sami, which Ecc or Patchcheck didn't > report. > - Adding missing error handling in InitializeFvAndVariableStoreHeaders(). > An allocation wasn't properly checked for success > > Changes since V3: > - Coding style fixes proposed by Sami > - Fixed all reported PatchCheck errors > - Added overflow checks on the base aaddress allocated for EFI variables. > The size of the partition is user defined (via Pcd's) and the memory layout > and allocation address depends on OP-TEE. So let's make sure we won't overflow > when calculating the 3 partitions needed for FTW > - Switched some PcdGet/Set32 to 64 to accomodate 64-bit addressing > - Removed some duplicate entries in Platform/StMMRpmb/PlatformStandaloneMm.dsc > - Added reviewed-by tags on patch 2/2 > > Changes since V2: > - Allocate a dynamic number of pages based on the Pcd values instead > of a static number > - Clean up unused structs in header file > - Added checks in OpTeeRpmbFvbGetBlockSize and handle NumLba=0 > > Changes since V1: > Some enhancements made by Ilias to the Optee Rpmb driver > > [1] https://edk2.groups.io/g/devel/message/66483?p=,,,20,0,0,0::Created,,ilias+apalodimas,20,2,0,77703661 > > Ilias Apalodimas (3): > Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver > StMMRpmb: Add support for building StandaloneMm image for OP-TEE > Maintainers: Add maintainers for StandAloneMM and RPMB driver > > Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c | 81 ++ > Drivers/OpTee/OpteeRpmbPkg/FixupPcd.inf | 43 + > Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFv.inf | 58 ++ > Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c | 861 ++++++++++++++++++ > Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h | 51 ++ > Maintainers.txt | 10 + > .../PlatformStandaloneMmRpmb.dsc | 162 ++++ > .../PlatformStandaloneMmRpmb.fdf | 111 +++ > 8 files changed, 1377 insertions(+) > create mode 100644 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.c > create mode 100644 Drivers/OpTee/OpteeRpmbPkg/FixupPcd.inf > create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFv.inf > create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c > create mode 100644 Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h > create mode 100644 Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc > create mode 100644 Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.fdf > > -- > 2.30.1