From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by mx.groups.io with SMTP id smtpd.web10.18.1627383432040977379 for ; Tue, 27 Jul 2021 03:57:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@citrix.com header.s=securemail header.b=WM2HtJj7; spf=pass (domain: citrix.com, ip: 216.71.155.175, mailfrom: anthony.perard@citrix.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1627383431; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/4lJtc4lvOgT7ajLovjX6NHBRP26nAQcQFkAw6gwtS0=; b=WM2HtJj7EvhOG/NF+wN4pgDiSuX9lMTa6T1m2KM7xhdPPHYp4lxKJFZ6 XLqmxhHEv6nPpNuSt3sDvFoWWIkFTtlJO42wfVyE0b4qVj8rSgDZ75frl GGCJqsZgrGC8lW51ZLLqPhPQWDZCZHBqs5hY8CeIzNX7LGYKHiH6FJwU0 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: msxY7M3Ahl6/JsbfLH/H4kUH6OSq2aSsR6QB8HB3z5dCxs9hlcBeAAnUs6FY78OP9dgTH7dMns T/Fayv5aS7Q1UAQIDWWjnmVNpb6FLbLY7WUsGNX77IHHPmFuCjtVeWTlVifAU0ZoQhZvUVShEb yvjyqA5pmKyezySlA1s+tV1C2URsp3VZM/PFT7HRTEfoKY37ABPf6/QYWiJvqLPD/23h9oo45l 4w5VOzxlCb9nJ/6YVsQYjWr1DO+nfLrQ5wiDP+bm/WXXpVBmwiJtqjwxzwGVj1oB+dXzR9LgV3 1t9RUpj2yoNY3LYecisBeF66 X-SBRS: 5.1 X-MesageID: 49207040 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:MtY7UKF+firiB2jtpLqEEseALOsnbusQ8zAXPiBKJCC9vPb5qy nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2KhbGI/9SKIVydygcy78 Zdm6gVMqyMMbB55/yKnDVRxbwbsaa6GKPDv5ah8590JzsaDJ2Jd21Ce32m+ksdfnghObMJUK Cyy+BgvDSadXEefq2AdwM4t7iqnayzqHr+CyR2fyIa1A== X-IronPort-AV: E=Sophos;i="5.84,273,1620705600"; d="scan'208";a="49207040" Date: Tue, 27 Jul 2021 11:57:07 +0100 From: "Anthony PERARD" To: Gary Lin CC: , Ard Biesheuvel , Jordan Justen , Julien Grall , Jim Fehlig Subject: Re: [edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization Message-ID: References: <20210708040549.8364-1-glin@suse.com> <16936D3065173CA9.5055@groups.io> MIME-Version: 1.0 In-Reply-To: Return-Path: anthony.perard@citrix.com Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Wed, Jul 21, 2021 at 02:56:46PM +0800, Gary Lin wrote: > BTW, it seems to me that QEMU fwcfg is only used for Xen Direct Kernel > Boot. However, per xl.cfg manpage, it's possible to turn on or off S3 > support by setting "acpi_s3" in xl.cfg, but PcdAcpiS3Enable wasn't set > in the current OvmfXen implementation. Just wonder how xl passes the S3 > support bit to OvmfXen. It doesn't. "acpi_s3" doesn't have any control over PcdAcpiS3Enable, and doesn't have any control over QEMU, so QEMU would probably always say S3 is available. What happen when "acpi_s3" is set or not is: - the value is stored in xenstore - hvmloader (which runs before OVMF) read the xenstore value and adds the appropriate ACPI SSDT table to allow S3. Cheers, -- Anthony PERARD