[PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe

[PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe

[Gary Lin]

Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download
the kernel, initrd, and kernel command line from QEMU's fw_cfg.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Julien Grall <julien@xen.org>
Cc: Jim Fehlig <jfehlig@suse.com>
Signed-off-by: Gary Lin <glin@suse.com>
---
 OvmfPkg/OvmfXen.dsc | 1 +
 OvmfPkg/OvmfXen.fdf | 1 +
 2 files changed, 2 insertions(+)

diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
index 3c1ca6bfd493..1a9c06c164a8 100644
--- a/OvmfPkg/OvmfXen.dsc
+++ b/OvmfPkg/OvmfXen.dsc
@@ -587,6 +587,7 @@ [Components]
       NULL|OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
 !endif
   }
+  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
   OvmfPkg/XenIoPvhDxe/XenIoPvhDxe.inf
   OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf
   OvmfPkg/XenBusDxe/XenBusDxe.inf
diff --git a/OvmfPkg/OvmfXen.fdf b/OvmfPkg/OvmfXen.fdf
index aeb9336fd5b7..8b5823555937 100644
--- a/OvmfPkg/OvmfXen.fdf
+++ b/OvmfPkg/OvmfXen.fdf
@@ -324,6 +324,7 @@ [FV.DXEFV]
 INF  MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf
 INF  MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
 INF  MdeModulePkg/Application/UiApp/UiApp.inf
+INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
 INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
 INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
 INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
-- 
2.31.1

Re: [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe

[Ard Biesheuvel]

On Fri, 9 Jul 2021 at 05:24, Gary Lin <glin@suse.com> wrote:
>
> Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download
> the kernel, initrd, and kernel command line from QEMU's fw_cfg.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Jim Fehlig <jfehlig@suse.com>
> Signed-off-by: Gary Lin <glin@suse.com>

I don't understand Xen on x86 well enough to decide whether we should
care about QEMU in the first place. Xen folks, please have a look.


> ---
>  OvmfPkg/OvmfXen.dsc | 1 +
>  OvmfPkg/OvmfXen.fdf | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
> index 3c1ca6bfd493..1a9c06c164a8 100644
> --- a/OvmfPkg/OvmfXen.dsc
> +++ b/OvmfPkg/OvmfXen.dsc
> @@ -587,6 +587,7 @@ [Components]
>        NULL|OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
>  !endif
>    }
> +  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>    OvmfPkg/XenIoPvhDxe/XenIoPvhDxe.inf
>    OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf
>    OvmfPkg/XenBusDxe/XenBusDxe.inf
> diff --git a/OvmfPkg/OvmfXen.fdf b/OvmfPkg/OvmfXen.fdf
> index aeb9336fd5b7..8b5823555937 100644
> --- a/OvmfPkg/OvmfXen.fdf
> +++ b/OvmfPkg/OvmfXen.fdf
> @@ -324,6 +324,7 @@ [FV.DXEFV]
>  INF  MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf
>  INF  MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
> +INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>  INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> --
> 2.31.1
>

Re: [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe

[Anthony PERARD]

On Fri, Jul 09, 2021 at 11:24:23AM +0800, Gary Lin wrote:
> Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download
> the kernel, initrd, and kernel command line from QEMU's fw_cfg.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Jim Fehlig <jfehlig@suse.com>
> Signed-off-by: Gary Lin <glin@suse.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

And now I understand what the patch "OvmfPkg/OvmfXen: set
PcdAcpiS3Enable at initialization" is about. "HVM Direct Kernel Boot"
with OVMF simply doesn't work without that other patch.

Thanks,

-- 
Anthony PERARD

Re: [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe

[Ard Biesheuvel]

On Mon, 19 Jul 2021 at 17:46, Anthony PERARD <anthony.perard@citrix.com> wrote:
>
> On Fri, Jul 09, 2021 at 11:24:23AM +0800, Gary Lin wrote:
> > Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download
> > the kernel, initrd, and kernel command line from QEMU's fw_cfg.
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Anthony Perard <anthony.perard@citrix.com>
> > Cc: Julien Grall <julien@xen.org>
> > Cc: Jim Fehlig <jfehlig@suse.com>
> > Signed-off-by: Gary Lin <glin@suse.com>
>
> Acked-by: Anthony PERARD <anthony.perard@citrix.com>
>
> And now I understand what the patch "OvmfPkg/OvmfXen: set
> PcdAcpiS3Enable at initialization" is about. "HVM Direct Kernel Boot"
> with OVMF simply doesn't work without that other patch.
>

Thanks. I'll file this one and merge it along with the other S3 patch
once it has been reviewed.