* [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe
@ 2021-07-09 3:24 Gary Lin
2021-07-19 7:36 ` Ard Biesheuvel
2021-07-19 15:46 ` Anthony PERARD
0 siblings, 2 replies; 4+ messages in thread
From: Gary Lin @ 2021-07-09 3:24 UTC (permalink / raw)
To: devel
Cc: Ard Biesheuvel, Jordan Justen, Anthony Perard, Julien Grall,
Jim Fehlig
Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download
the kernel, initrd, and kernel command line from QEMU's fw_cfg.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Julien Grall <julien@xen.org>
Cc: Jim Fehlig <jfehlig@suse.com>
Signed-off-by: Gary Lin <glin@suse.com>
---
OvmfPkg/OvmfXen.dsc | 1 +
OvmfPkg/OvmfXen.fdf | 1 +
2 files changed, 2 insertions(+)
diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
index 3c1ca6bfd493..1a9c06c164a8 100644
--- a/OvmfPkg/OvmfXen.dsc
+++ b/OvmfPkg/OvmfXen.dsc
@@ -587,6 +587,7 @@ [Components]
NULL|OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
!endif
}
+ OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
OvmfPkg/XenIoPvhDxe/XenIoPvhDxe.inf
OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf
OvmfPkg/XenBusDxe/XenBusDxe.inf
diff --git a/OvmfPkg/OvmfXen.fdf b/OvmfPkg/OvmfXen.fdf
index aeb9336fd5b7..8b5823555937 100644
--- a/OvmfPkg/OvmfXen.fdf
+++ b/OvmfPkg/OvmfXen.fdf
@@ -324,6 +324,7 @@ [FV.DXEFV]
INF MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf
INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
INF MdeModulePkg/Application/UiApp/UiApp.inf
+INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe
2021-07-09 3:24 [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Gary Lin
@ 2021-07-19 7:36 ` Ard Biesheuvel
2021-07-19 15:46 ` Anthony PERARD
1 sibling, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2021-07-19 7:36 UTC (permalink / raw)
To: Gary Lin
Cc: edk2-devel-groups-io, Ard Biesheuvel, Jordan Justen,
Anthony Perard, Julien Grall, Jim Fehlig
On Fri, 9 Jul 2021 at 05:24, Gary Lin <glin@suse.com> wrote:
>
> Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download
> the kernel, initrd, and kernel command line from QEMU's fw_cfg.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Jim Fehlig <jfehlig@suse.com>
> Signed-off-by: Gary Lin <glin@suse.com>
I don't understand Xen on x86 well enough to decide whether we should
care about QEMU in the first place. Xen folks, please have a look.
> ---
> OvmfPkg/OvmfXen.dsc | 1 +
> OvmfPkg/OvmfXen.fdf | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
> index 3c1ca6bfd493..1a9c06c164a8 100644
> --- a/OvmfPkg/OvmfXen.dsc
> +++ b/OvmfPkg/OvmfXen.dsc
> @@ -587,6 +587,7 @@ [Components]
> NULL|OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
> !endif
> }
> + OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
> OvmfPkg/XenIoPvhDxe/XenIoPvhDxe.inf
> OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf
> OvmfPkg/XenBusDxe/XenBusDxe.inf
> diff --git a/OvmfPkg/OvmfXen.fdf b/OvmfPkg/OvmfXen.fdf
> index aeb9336fd5b7..8b5823555937 100644
> --- a/OvmfPkg/OvmfXen.fdf
> +++ b/OvmfPkg/OvmfXen.fdf
> @@ -324,6 +324,7 @@ [FV.DXEFV]
> INF MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf
> INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> INF MdeModulePkg/Application/UiApp/UiApp.inf
> +INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe
2021-07-09 3:24 [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Gary Lin
2021-07-19 7:36 ` Ard Biesheuvel
@ 2021-07-19 15:46 ` Anthony PERARD
2021-07-19 16:49 ` Ard Biesheuvel
1 sibling, 1 reply; 4+ messages in thread
From: Anthony PERARD @ 2021-07-19 15:46 UTC (permalink / raw)
To: Gary Lin; +Cc: devel, Ard Biesheuvel, Jordan Justen, Julien Grall, Jim Fehlig
On Fri, Jul 09, 2021 at 11:24:23AM +0800, Gary Lin wrote:
> Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download
> the kernel, initrd, and kernel command line from QEMU's fw_cfg.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Jim Fehlig <jfehlig@suse.com>
> Signed-off-by: Gary Lin <glin@suse.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
And now I understand what the patch "OvmfPkg/OvmfXen: set
PcdAcpiS3Enable at initialization" is about. "HVM Direct Kernel Boot"
with OVMF simply doesn't work without that other patch.
Thanks,
--
Anthony PERARD
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe
2021-07-19 15:46 ` Anthony PERARD
@ 2021-07-19 16:49 ` Ard Biesheuvel
0 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2021-07-19 16:49 UTC (permalink / raw)
To: Anthony PERARD
Cc: Gary Lin, edk2-devel-groups-io, Ard Biesheuvel, Jordan Justen,
Julien Grall, Jim Fehlig
On Mon, 19 Jul 2021 at 17:46, Anthony PERARD <anthony.perard@citrix.com> wrote:
>
> On Fri, Jul 09, 2021 at 11:24:23AM +0800, Gary Lin wrote:
> > Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download
> > the kernel, initrd, and kernel command line from QEMU's fw_cfg.
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Anthony Perard <anthony.perard@citrix.com>
> > Cc: Julien Grall <julien@xen.org>
> > Cc: Jim Fehlig <jfehlig@suse.com>
> > Signed-off-by: Gary Lin <glin@suse.com>
>
> Acked-by: Anthony PERARD <anthony.perard@citrix.com>
>
> And now I understand what the patch "OvmfPkg/OvmfXen: set
> PcdAcpiS3Enable at initialization" is about. "HVM Direct Kernel Boot"
> with OVMF simply doesn't work without that other patch.
>
Thanks. I'll file this one and merge it along with the other S3 patch
once it has been reviewed.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-19 16:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-09 3:24 [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Gary Lin
2021-07-19 7:36 ` Ard Biesheuvel
2021-07-19 15:46 ` Anthony PERARD
2021-07-19 16:49 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox